From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Date: Thu, 31 Mar 2016 11:20:05 +0200 Message-ID: <20160331092005.GA18640@gmail.com> References: <1456750705-7141-1-git-send-email-mhocko@kernel.org> <20160330133217.GV3408@twins.programming.kicks-ass.net> <20160331085926.GB27831@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160331085926.GB27831@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org To: Michal Hocko Cc: Peter Zijlstra , Andrew Morton , LKML , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org * Michal Hocko wrote: > On Wed 30-03-16 15:32:17, Peter Zijlstra wrote: > > On Mon, Feb 29, 2016 at 01:58:14PM +0100, Michal Hocko wrote: > > > I have tested on x86 with OOM situations with high mmap_sem contention > > > (basically many parallel page faults racing with many parallel mmap/munmap > > > tight loops) so the waiters for the write locks are routinely interrupted > > > by SIGKILL. > > > > Aside from the one niggle (as per the other email) they look good to me > > and I would take them through the tip/locking tree. > > Thanks for the review! I understand that tip/locking would be the most > appropriate place [...] Yes. > [...] but I am wondering whether this causes some issues with the follow up > patches which use this new API and which I expect to go via Andrew's tree. So AFAIK Andrew's tree is based on top of linux-next, so once it goes into tip:locking/core, -mm can pick it up as well 1-2 days later. Please send the changes in isolation, for merge into the locking tree. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:36605 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756172AbcCaJUN (ORCPT ); Thu, 31 Mar 2016 05:20:13 -0400 Date: Thu, 31 Mar 2016 11:20:05 +0200 From: Ingo Molnar Subject: Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Message-ID: <20160331092005.GA18640@gmail.com> References: <1456750705-7141-1-git-send-email-mhocko@kernel.org> <20160330133217.GV3408@twins.programming.kicks-ass.net> <20160331085926.GB27831@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160331085926.GB27831@dhcp22.suse.cz> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michal Hocko Cc: Peter Zijlstra , Andrew Morton , LKML , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org Message-ID: <20160331092005.OMtKYfl3wX8UYwQUpz_ikgh5VZkhW8bJLioLnAiwUxI@z> * Michal Hocko wrote: > On Wed 30-03-16 15:32:17, Peter Zijlstra wrote: > > On Mon, Feb 29, 2016 at 01:58:14PM +0100, Michal Hocko wrote: > > > I have tested on x86 with OOM situations with high mmap_sem contention > > > (basically many parallel page faults racing with many parallel mmap/munmap > > > tight loops) so the waiters for the write locks are routinely interrupted > > > by SIGKILL. > > > > Aside from the one niggle (as per the other email) they look good to me > > and I would take them through the tip/locking tree. > > Thanks for the review! I understand that tip/locking would be the most > appropriate place [...] Yes. > [...] but I am wondering whether this causes some issues with the follow up > patches which use this new API and which I expect to go via Andrew's tree. So AFAIK Andrew's tree is based on top of linux-next, so once it goes into tip:locking/core, -mm can pick it up as well 1-2 days later. Please send the changes in isolation, for merge into the locking tree. Thanks, Ingo