From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:33652 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760367AbcDMMtx (ORCPT ); Wed, 13 Apr 2016 08:49:53 -0400 Date: Wed, 13 Apr 2016 14:49:43 +0200 From: Michal Hocko Subject: Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable Message-ID: <20160413124943.GH14351@dhcp22.suse.cz> References: <1460041951-22347-1-git-send-email-mhocko@kernel.org> <1460041951-22347-11-git-send-email-mhocko@kernel.org> <20160413090829.GB29579@gmail.com> <20160413091625.GF14351@dhcp22.suse.cz> <20160413091943.GA17858@gmail.com> <20160413102731.GA29896@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160413102731.GA29896@gmail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: LKML , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Andrew Morton , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, Josh Poimboeuf Message-ID: <20160413124943.F6UXIO76wyxM3hb9H6BOFWK0eN11F-gTZfYKFDEHkUg@z> On Wed 13-04-16 12:27:31, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > I'm testing your patches today, if they are otherwise OK [...] > > got this build failure: > > ./arch/x86/include/asm/rwsem.h:106:2: error: ‘asm’ operand has impossible constraints Hmm, I have no idea why 64b didn't have problem with the asm but 32b complains. Anyway, the following makes both happy. I have checked the generated code for 64b and it hasn't changed after the patch. 32b also seems to be generating a proper code. My gcc asm()-foo is rather weak so I would feel better if somebody double checked after me. ---