From mboxrd@z Thu Jan 1 00:00:00 1970 From: Niklas =?iso-8859-1?Q?S=F6derlund?= Subject: Re: [PATCH v5 3/9] dma-mapping: add dma_{map,unmap}_resource Date: Thu, 21 Apr 2016 11:48:20 +0200 Message-ID: <20160421094820.GM19650@bigcity.dyn.berto.se> References: <1457404974-1800-1-git-send-email-niklas.soderlund+renesas@ragnatech.se> <20160311125846.GF1111@bigcity.dyn.berto.se> <20160315082254.GE9136@infradead.org> <3286525.zPAGiD4Xk2@avalon> <20160321152601.GA11674@infradead.org> <20160413132916.GC19650@bigcity.dyn.berto.se> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20160413132916.GC19650@bigcity.dyn.berto.se> Sender: linux-renesas-soc-owner@vger.kernel.org To: Christoph Hellwig , Laurent Pinchart , Dan Williams , Vinod Koul , linux-renesas-soc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , iommu@lists.linux-foundation.org, robin.murphy@arm.com, geert+renesas@glider.be, Linus Walleij , Arnd Bergmann , linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org Hi Christoph, Have you had time to look at the audit? Is there anything else I can do= =20 make progress on this? On 2016-04-13 15:29:16 +0200, Niklas S=F6derlund wrote: > Hi Christoph, >=20 > On 2016-03-21 08:26:01 -0700, Christoph Hellwig wrote: > > On Thu, Mar 17, 2016 at 01:33:51PM +0200, Laurent Pinchart wrote: > > > The good news is that, given that no code uses this new API at th= e moment,=20 > > > there isn't much to audit. The patch series implements the resour= ce mapping=20 > > > for arch/arm only, and makes use of it in the rcar-dmac driver on= ly. Would you=20 > > > like anything audited else than the arch/arm dma mapping implemen= tation, the=20 > > > rcar-dmac driver and the code that then deals with the dma addres= ses (I'm=20 > > > thinking about the IOMMU subsystem and the ipmmu-vmsa driver in p= articular) ? > >=20 > > Yes, it would be good to do an audit of all the ARM dma_ops as well > > as generic code like drivers/base/dma-*.c, lib/dma-debug.c and > > include/linux/dma-*.h >=20 > I have now done an audit to the best of my abilities, thanks to Laure= nt=20 > for pointing me in the right direction. And from what I can tell we a= re=20 > good. >=20 > * drivers/dma/sh/rcar-dmac.c > Once the phys_addr_t is mapped to a dma_addr_t using=20 > dma_map_resource() it is only used to check that the transfere do n= ot=20 > cross 4GB boundaries and then only directly written to HW registers= =2E >=20 > * drivers/iommu/iommu.c > - iommu_map() > Check that it's align to min page size or return -EINVAL then cal= ls > domain->ops->map() >=20 > * drivers/iommu/ipmmu-vmsa.c > - ipmmu_map() > No logic only calls domain->ops->map() >=20 > * drivers/iommu/io-pgtable-arm.c > - arm_lpae_map() > No logic only calls __arm_lpae_map() > - __arm_lpae_map() > No logic only calls arm_lpae_init_pte() > - arm_lpae_init_pte() > Used to get a pte: > pte |=3D pfn_to_iopte(paddr >> data->pg_shift, data); >=20 > * drivers/iommu/io-pgtable-arm-v7s.c > - arm_v7s_map() > No logic only calls __arm_v7s_map() > - __arm_v7s_map() > No logic only calls arm_v7s_init_pte() > - arm_v7s_init_pte > Used to get a pte: > pte |=3D paddr & ARM_V7S_LVL_MASK(lvl); >=20 > * ARM dma-mapping > - dma_unmap_* > Only valid unmap is dma_unmap_resource() all others are an invali= d=20 > use case. > - dma_sync_single_* > Invalid use case, memmory that is mapped is device memmory > - dma_common_mmap() and dma_mmap_attrs() > Invalid use case > - dma_common_get_sgtable() and dma_get_sgtable_attrs() > Invalid use case, only for dma_alloc_* allocated memory, > - dma_mapping_error() > OK --=20 Regards, Niklas S=F6derlund From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f175.google.com ([209.85.217.175]:35013 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbcDUJsX (ORCPT ); Thu, 21 Apr 2016 05:48:23 -0400 Received: by mail-lb0-f175.google.com with SMTP id os9so23928375lbb.2 for ; Thu, 21 Apr 2016 02:48:22 -0700 (PDT) Date: Thu, 21 Apr 2016 11:48:20 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= Subject: Re: [PATCH v5 3/9] dma-mapping: add dma_{map,unmap}_resource Message-ID: <20160421094820.GM19650@bigcity.dyn.berto.se> References: <1457404974-1800-1-git-send-email-niklas.soderlund+renesas@ragnatech.se> <20160311125846.GF1111@bigcity.dyn.berto.se> <20160315082254.GE9136@infradead.org> <3286525.zPAGiD4Xk2@avalon> <20160321152601.GA11674@infradead.org> <20160413132916.GC19650@bigcity.dyn.berto.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160413132916.GC19650@bigcity.dyn.berto.se> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig , Laurent Pinchart , Dan Williams , Vinod Koul , linux-renesas-soc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , iommu@lists.linux-foundation.org, robin.murphy@arm.com, geert+renesas@glider.be, Linus Walleij , Arnd Bergmann , linux-arch@vger.kernel.org Message-ID: <20160421094820.GnN8fdSBLRzgQKScYpnHIHzOLyjRhck4rhII-7ldau4@z> Hi Christoph, Have you had time to look at the audit? Is there anything else I can do make progress on this? On 2016-04-13 15:29:16 +0200, Niklas Söderlund wrote: > Hi Christoph, > > On 2016-03-21 08:26:01 -0700, Christoph Hellwig wrote: > > On Thu, Mar 17, 2016 at 01:33:51PM +0200, Laurent Pinchart wrote: > > > The good news is that, given that no code uses this new API at the moment, > > > there isn't much to audit. The patch series implements the resource mapping > > > for arch/arm only, and makes use of it in the rcar-dmac driver only. Would you > > > like anything audited else than the arch/arm dma mapping implementation, the > > > rcar-dmac driver and the code that then deals with the dma addresses (I'm > > > thinking about the IOMMU subsystem and the ipmmu-vmsa driver in particular) ? > > > > Yes, it would be good to do an audit of all the ARM dma_ops as well > > as generic code like drivers/base/dma-*.c, lib/dma-debug.c and > > include/linux/dma-*.h > > I have now done an audit to the best of my abilities, thanks to Laurent > for pointing me in the right direction. And from what I can tell we are > good. > > * drivers/dma/sh/rcar-dmac.c > Once the phys_addr_t is mapped to a dma_addr_t using > dma_map_resource() it is only used to check that the transfere do not > cross 4GB boundaries and then only directly written to HW registers. > > * drivers/iommu/iommu.c > - iommu_map() > Check that it's align to min page size or return -EINVAL then calls > domain->ops->map() > > * drivers/iommu/ipmmu-vmsa.c > - ipmmu_map() > No logic only calls domain->ops->map() > > * drivers/iommu/io-pgtable-arm.c > - arm_lpae_map() > No logic only calls __arm_lpae_map() > - __arm_lpae_map() > No logic only calls arm_lpae_init_pte() > - arm_lpae_init_pte() > Used to get a pte: > pte |= pfn_to_iopte(paddr >> data->pg_shift, data); > > * drivers/iommu/io-pgtable-arm-v7s.c > - arm_v7s_map() > No logic only calls __arm_v7s_map() > - __arm_v7s_map() > No logic only calls arm_v7s_init_pte() > - arm_v7s_init_pte > Used to get a pte: > pte |= paddr & ARM_V7S_LVL_MASK(lvl); > > * ARM dma-mapping > - dma_unmap_* > Only valid unmap is dma_unmap_resource() all others are an invalid > use case. > - dma_sync_single_* > Invalid use case, memmory that is mapped is device memmory > - dma_common_mmap() and dma_mmap_attrs() > Invalid use case > - dma_common_get_sgtable() and dma_get_sgtable_attrs() > Invalid use case, only for dma_alloc_* allocated memory, > - dma_mapping_error() > OK -- Regards, Niklas Söderlund