From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [RFC][ATCH 3/3] syscalls: Remove start and number from syscall_get_arguments() args Date: Tue, 8 Nov 2016 14:21:57 -0500 Message-ID: <20161108142157.68c7db7c@gandalf.local.home> References: <20161107212634.529267342@goodmis.org> <20161107213233.754809394@goodmis.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Linus Torvalds , Ingo Molnar , Andrew Morton , Roland McGrath , Oleg Nesterov , linux-arch , Peter Zijlstra List-Id: linux-arch.vger.kernel.org On Mon, 7 Nov 2016 15:54:14 -0800 Andy Lutomirski wrote: > On Mon, Nov 7, 2016 at 1:26 PM, Steven Rostedt wrote: > > From: Steven Rostedt > > > > > diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h > > index e3c95e8e61c5..050891169b51 100644 > > --- a/arch/x86/include/asm/syscall.h > > +++ b/arch/x86/include/asm/syscall.h > > x86 part is: > > Reviewed-by: Andy Lutomirski > > Although I wonder why this takes a task argument. Thanks, although kbuild bot discovered a slight mistake: } else { # endif *args++ = regs->di; Should be: } else # endif { *args++ = regs->di; I'll update, and also look at making it a struct. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0139.hostedemail.com ([216.40.44.139]:41682 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751662AbcKHT1Z (ORCPT ); Tue, 8 Nov 2016 14:27:25 -0500 Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave08.hostedemail.com (Postfix) with ESMTP id EF11E2117B0 for ; Tue, 8 Nov 2016 19:22:01 +0000 (UTC) Date: Tue, 8 Nov 2016 14:21:57 -0500 From: Steven Rostedt Subject: Re: [RFC][ATCH 3/3] syscalls: Remove start and number from syscall_get_arguments() args Message-ID: <20161108142157.68c7db7c@gandalf.local.home> In-Reply-To: References: <20161107212634.529267342@goodmis.org> <20161107213233.754809394@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Linus Torvalds , Ingo Molnar , Andrew Morton , Roland McGrath , Oleg Nesterov , linux-arch , Peter Zijlstra Message-ID: <20161108192157.ddfhuLaQUXASb5KaAktSUfq6wdW7in-nJ85GhOIacbw@z> On Mon, 7 Nov 2016 15:54:14 -0800 Andy Lutomirski wrote: > On Mon, Nov 7, 2016 at 1:26 PM, Steven Rostedt wrote: > > From: Steven Rostedt > > > > > diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h > > index e3c95e8e61c5..050891169b51 100644 > > --- a/arch/x86/include/asm/syscall.h > > +++ b/arch/x86/include/asm/syscall.h > > x86 part is: > > Reviewed-by: Andy Lutomirski > > Although I wonder why this takes a task argument. Thanks, although kbuild bot discovered a slight mistake: } else { # endif *args++ = regs->di; Should be: } else # endif { *args++ = regs->di; I'll update, and also look at making it a struct. -- Steve