From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:47278 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932699AbeGIPek (ORCPT ); Mon, 9 Jul 2018 11:34:40 -0400 Date: Mon, 9 Jul 2018 17:34:27 +0200 From: Peter Zijlstra Subject: Re: [PATCH v3] devres: Explicitly align datai[] to 64-bit Message-ID: <20180709153427.GY2476@hirez.programming.kicks-ass.net> References: <20180709134550.29541-1-abrodkin@synopsys.com> <20180709140717.GR2476@hirez.programming.kicks-ass.net> <20180709141056.GR2512@hirez.programming.kicks-ass.net> <44727d3cebda7bee5b68fb388bd2fecfc6dc7b89.camel@synopsys.com> <20180709144925.GU2476@hirez.programming.kicks-ass.net> <20180709152958.565weccfaktqauef@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180709152958.565weccfaktqauef@lakrids.cambridge.arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Mark Rutland Cc: Alexey Brodkin , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "linux-snps-arc@lists.infradead.org" , "stable@vger.kernel.org" , "greg@kroah.com" , "will.deacon@arm.com" , "gregkh@linuxfoundation.org" , "David.Laight@ACULAB.COM" , "linux-arch@vger.kernel.org" , "geert@linux-m68k.org" Message-ID: <20180709153427.F1dUtM-h-32TI64s6vouZveYGMY4zIbSVxt4ESpX3Lk@z> On Mon, Jul 09, 2018 at 04:29:58PM +0100, Mark Rutland wrote: > Shouldn't that be 8? AFAICT, __alignof__(unsigned long long) is 8 on > x86_32: Curious, I wonder why we put that align in atomic64_32 then.