From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [RFC PATCH 2/2] mm: mmu_notifier fix for tlb_end_vma (build failures) Date: Fri, 24 Aug 2018 11:22:59 -0700 Message-ID: <20180824182259.GA18477@roeck-us.net> References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-3-npiggin@gmail.com> <20180824130722.GA31409@roeck-us.net> <20180824131026.GB11868@brain-police> <20180824132419.GA9983@roeck-us.net> <20180824133427.GC11868@brain-police> <20180824135048.GF11868@brain-police> <7d0111f4-c369-43a8-72c6-1a7390cdebdd@roeck-us.net> <20180824142532.GG11868@brain-police> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180824142532.GG11868@brain-police> Sender: linux-kernel-owner@vger.kernel.org To: Will Deacon Cc: Nicholas Piggin , Peter Zijlstra , torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, riel@surriel.com, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org List-Id: linux-arch.vger.kernel.org On Fri, Aug 24, 2018 at 03:25:33PM +0100, Will Deacon wrote: > On Fri, Aug 24, 2018 at 07:06:51AM -0700, Guenter Roeck wrote: > > On 08/24/2018 06:50 AM, Will Deacon wrote: > > > > >>-#include > > >>+struct mmu_gather; > > >> static inline void tlb_flush(struct mmu_gather *tlb) > > >> { > > >> flush_tlb_mm(tlb->mm); > > > > > >Bah, didn't spot the dereference so this won't work either. You basically > > >just need to copy what I did for arm64 in d475fac95779. > > > > > > > Yes, this seems to work. It doesn't really need "struct mmu_gather;" - > > I assume that is included from elsewhere - but I added it to be safe. > > struct mmu_gather comes in via asm-generic/tlb.h. > >From linux/mm.h, really, which happens to be included before asm/tlb.h is included (see arch/riscv/include/asm/pgalloc.h). I kept it to be future-proof. > > Can you send a full patch, or do you want me to do it ? > > I'm evidently incapable of writing code today, so please go ahead :) > Done. We'll see if I am any better. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:43088 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726850AbeHXV6q (ORCPT ); Fri, 24 Aug 2018 17:58:46 -0400 Date: Fri, 24 Aug 2018 11:22:59 -0700 From: Guenter Roeck Subject: Re: [RFC PATCH 2/2] mm: mmu_notifier fix for tlb_end_vma (build failures) Message-ID: <20180824182259.GA18477@roeck-us.net> References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-3-npiggin@gmail.com> <20180824130722.GA31409@roeck-us.net> <20180824131026.GB11868@brain-police> <20180824132419.GA9983@roeck-us.net> <20180824133427.GC11868@brain-police> <20180824135048.GF11868@brain-police> <7d0111f4-c369-43a8-72c6-1a7390cdebdd@roeck-us.net> <20180824142532.GG11868@brain-police> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180824142532.GG11868@brain-police> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: Nicholas Piggin , Peter Zijlstra , torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, riel@surriel.com, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org Message-ID: <20180824182259.NZEJjYuLD_3-n7wGGw4N4K5crewQBFkijr5GS6pDEg0@z> On Fri, Aug 24, 2018 at 03:25:33PM +0100, Will Deacon wrote: > On Fri, Aug 24, 2018 at 07:06:51AM -0700, Guenter Roeck wrote: > > On 08/24/2018 06:50 AM, Will Deacon wrote: > > > > >>-#include > > >>+struct mmu_gather; > > >> static inline void tlb_flush(struct mmu_gather *tlb) > > >> { > > >> flush_tlb_mm(tlb->mm); > > > > > >Bah, didn't spot the dereference so this won't work either. You basically > > >just need to copy what I did for arm64 in d475fac95779. > > > > > > > Yes, this seems to work. It doesn't really need "struct mmu_gather;" - > > I assume that is included from elsewhere - but I added it to be safe. > > struct mmu_gather comes in via asm-generic/tlb.h. >