From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guo Ren Subject: Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc Date: Sat, 8 Sep 2018 10:05:46 +0800 Message-ID: <20180908020545.GA29088@guoren-Inspiron-7460> References: <62dae1828ade759584bbf1507fe4a9e69d247a50.1536138304.git.ren_guo@c-sky.com> <20180906021254.GC29405@guoren-Inspiron-7460> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Arnd Bergmann , "open list:GENERIC INCLUDE/ASM HEADER FILES" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Thomas Petazzoni , wbx@uclibc-ng.org, Greentime Hu List-Id: linux-arch.vger.kernel.org On Fri, Sep 07, 2018 at 10:13:13AM -0500, Rob Herring wrote: > On Thu, Sep 6, 2018 at 8:05 AM Arnd Bergmann wrote: > > > > On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote: > > > > > > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote: > > > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote: > > > > > > > > > > Signed-off-by: Guo Ren > > > > > + > > > > > + intc: interrupt-controller { > > > > > > > > Needs a unit-address. > > > Ok, change it to: > > > intc: interrupt-controller@0x00500000 { > > > > The unit address has no leading 0x or leading zeroes, so > > interrupt-controller@500000 > > Please build your dts files with W=12 and it will tell you this and > other errors. And then update any examples based on that. Got it, thx for the tip. Guo Ren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:41894 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbeIHGuE (ORCPT ); Sat, 8 Sep 2018 02:50:04 -0400 Date: Sat, 8 Sep 2018 10:05:46 +0800 From: Guo Ren Subject: Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc Message-ID: <20180908020545.GA29088@guoren-Inspiron-7460> References: <62dae1828ade759584bbf1507fe4a9e69d247a50.1536138304.git.ren_guo@c-sky.com> <20180906021254.GC29405@guoren-Inspiron-7460> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rob Herring Cc: Arnd Bergmann , "open list:GENERIC INCLUDE/ASM HEADER FILES" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Thomas Petazzoni , wbx@uclibc-ng.org, Greentime Hu Message-ID: <20180908020546.ZJXeGJNBE6FER8n50dg9_LwrH7GVkCWwq1wmqha0Fxw@z> On Fri, Sep 07, 2018 at 10:13:13AM -0500, Rob Herring wrote: > On Thu, Sep 6, 2018 at 8:05 AM Arnd Bergmann wrote: > > > > On Thu, Sep 6, 2018 at 4:13 AM Guo Ren wrote: > > > > > > On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote: > > > > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote: > > > > > > > > > > Signed-off-by: Guo Ren > > > > > + > > > > > + intc: interrupt-controller { > > > > > > > > Needs a unit-address. > > > Ok, change it to: > > > intc: interrupt-controller@0x00500000 { > > > > The unit address has no leading 0x or leading zeroes, so > > interrupt-controller@500000 > > Please build your dts files with W=12 and it will tell you this and > other errors. And then update any examples based on that. Got it, thx for the tip. Guo Ren