From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: [PATCH RFC LKMM 2/7] doc: Replace smp_cond_acquire() with smp_cond_load_acquire() Date: Fri, 14 Sep 2018 11:20:09 -0700 Message-ID: <20180914182009.GB652@linux.ibm.com> References: <20180829211018.GA19646@linux.vnet.ibm.com> <20180829211053.20531-2-paulmck@linux.vnet.ibm.com> <20180914165907.GK6236@arm.com> Reply-To: paulmck@linux.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180914165907.GK6236@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Will Deacon Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, stern@rowland.harvard.edu, parri.andrea@gmail.com, peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr, akiyks@gmail.com, Andrea Parri , Daniel Lustig , Jonathan Corbet List-Id: linux-arch.vger.kernel.org On Fri, Sep 14, 2018 at 05:59:07PM +0100, Will Deacon wrote: > On Wed, Aug 29, 2018 at 02:10:48PM -0700, Paul E. McKenney wrote: > > From: Andrea Parri > > > > Amend commit 1f03e8d2919270 ("locking/barriers: Replace smp_cond_acquire() > > with smp_cond_load_acquire()") by updating the documentation accordingly. > > Also remove some obsolete information related to the implementation. > > > > Signed-off-by: Andrea Parri > > Cc: Alan Stern > > Cc: Will Deacon > > Cc: Peter Zijlstra > > Cc: Boqun Feng > > Cc: Nicholas Piggin > > Cc: David Howells > > Cc: Jade Alglave > > Cc: Luc Maranget > > Cc: "Paul E. McKenney" > > Cc: Akira Yokosawa > > Cc: Daniel Lustig > > Cc: Jonathan Corbet > > Signed-off-by: Paul E. McKenney > > --- > > Documentation/memory-barriers.txt | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt > > index 0d8d7ef131e9..c1d913944ad8 100644 > > --- a/Documentation/memory-barriers.txt > > +++ b/Documentation/memory-barriers.txt > > @@ -471,8 +471,7 @@ And a couple of implicit varieties: > > operations after the ACQUIRE operation will appear to happen after the > > ACQUIRE operation with respect to the other components of the system. > > ACQUIRE operations include LOCK operations and both smp_load_acquire() > > - and smp_cond_acquire() operations. The later builds the necessary ACQUIRE > > - semantics from relying on a control dependency and smp_rmb(). > > + and smp_cond_load_acquire() operations. > > Thanks for fixing the doc: > > Acked-by: Will Deacon Applied, thank you Will! Thanx, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59032 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727128AbeINXf5 (ORCPT ); Fri, 14 Sep 2018 19:35:57 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8EI9bfL025066 for ; Fri, 14 Sep 2018 14:20:17 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mggmpuhw8-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 14 Sep 2018 14:20:16 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Sep 2018 14:20:15 -0400 Date: Fri, 14 Sep 2018 11:20:09 -0700 From: "Paul E. McKenney" Subject: Re: [PATCH RFC LKMM 2/7] doc: Replace smp_cond_acquire() with smp_cond_load_acquire() Reply-To: paulmck@linux.ibm.com References: <20180829211018.GA19646@linux.vnet.ibm.com> <20180829211053.20531-2-paulmck@linux.vnet.ibm.com> <20180914165907.GK6236@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180914165907.GK6236@arm.com> Message-ID: <20180914182009.GB652@linux.ibm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, stern@rowland.harvard.edu, parri.andrea@gmail.com, peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr, akiyks@gmail.com, Andrea Parri , Daniel Lustig , Jonathan Corbet Message-ID: <20180914182009.9BDNuojiJ3MyR5Jz27i2C9HjgFXbtUhg9C8T_vLNM5g@z> On Fri, Sep 14, 2018 at 05:59:07PM +0100, Will Deacon wrote: > On Wed, Aug 29, 2018 at 02:10:48PM -0700, Paul E. McKenney wrote: > > From: Andrea Parri > > > > Amend commit 1f03e8d2919270 ("locking/barriers: Replace smp_cond_acquire() > > with smp_cond_load_acquire()") by updating the documentation accordingly. > > Also remove some obsolete information related to the implementation. > > > > Signed-off-by: Andrea Parri > > Cc: Alan Stern > > Cc: Will Deacon > > Cc: Peter Zijlstra > > Cc: Boqun Feng > > Cc: Nicholas Piggin > > Cc: David Howells > > Cc: Jade Alglave > > Cc: Luc Maranget > > Cc: "Paul E. McKenney" > > Cc: Akira Yokosawa > > Cc: Daniel Lustig > > Cc: Jonathan Corbet > > Signed-off-by: Paul E. McKenney > > --- > > Documentation/memory-barriers.txt | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt > > index 0d8d7ef131e9..c1d913944ad8 100644 > > --- a/Documentation/memory-barriers.txt > > +++ b/Documentation/memory-barriers.txt > > @@ -471,8 +471,7 @@ And a couple of implicit varieties: > > operations after the ACQUIRE operation will appear to happen after the > > ACQUIRE operation with respect to the other components of the system. > > ACQUIRE operations include LOCK operations and both smp_load_acquire() > > - and smp_cond_acquire() operations. The later builds the necessary ACQUIRE > > - semantics from relying on a control dependency and smp_rmb(). > > + and smp_cond_load_acquire() operations. > > Thanks for fixing the doc: > > Acked-by: Will Deacon Applied, thank you Will! Thanx, Paul