From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f65.google.com ([209.85.166.65]:35762 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731580AbeITSoK (ORCPT ); Thu, 20 Sep 2018 14:44:10 -0400 Received: by mail-io1-f65.google.com with SMTP id w11-v6so7317626iob.2 for ; Thu, 20 Sep 2018 06:00:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180827090651.25062-1-brgl@bgdev.pl> References: <20180827090651.25062-1-brgl@bgdev.pl> From: Bartosz Golaszewski Date: Thu, 20 Sep 2018 15:00:45 +0200 Message-ID: Subject: Re: [RESEND PATCH v3 0/3] sh: make early_platform code SuperH-specific Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Sekhar Nori , Kevin Hilman , David Lechner , Michael Turquette , Stephen Boyd , Arnd Bergmann , Greg Kroah-Hartman , Mark Rutland , Yoshinori Sato , Rich Felker , Andy Shevchenko , Marc Zyngier , "Rafael J . Wysocki" , Peter Rosin , Jiri Slaby , Thomas Gleixner , Daniel Lezcano , Geert Uytterhoeven , Magnus Damm , Johan Hovold , Rob Herring , Frank Rowand , Philippe Ombredanne Cc: Linux ARM , Linux Kernel Mailing List , devicetree , "open list:GENERIC INCLUDE/ASM HEADER FILES" , Bartosz Golaszewski Message-ID: <20180920130045.QMGafS-OcLlAL8wcWLbN7uxtpqb94yq7nElRk8M31BA@z> 2018-08-27 11:06 GMT+02:00 Bartosz Golaszewski : > I recently started a discussion about the need for a proper early device > probing mechanism[1]. One that would be based on real platform drivers > and support both platform data and device tree. > > While we're far from reaching any consensus on the implementation, Arnd > suggested that I start off by moving the SuperH-specific early platform > drivers implementation to arch/sh[2]. > > This series is the first attempt at making way for a new, less hacky > implementation. > > The first patch removes the last instance of a non-sh driver using the > early_platform API. It can be removed since ARM no longer probes early > drivers. > > The second patch moves all the early_platform code to arch/sh. > > The last patch prefixes all early_platform symbols with 'sh_'. > > [1] https://lkml.org/lkml/2018/4/26/657 > [2] https://lkml.org/lkml/2018/4/27/239 > > v1 -> v2: > - certain drivers are compiled for arm/mach-shmobile too - we need to > add ifdefs for CONFIG_SUPERH around early_platform calls > > v2 -> v3: > - added a stub for is_early_platform_device() which always returns false > on non-SuperH architectures > > RESEND: rebased on top of v4.18-rc1 and verified that there are no build > failures. > > RESEND AGAIN: rebased on top of v4.19-rc1 and verified builds again. > > Bartosz Golaszewski (3): > clocksource: timer-ti-dm: remove the early platform driver > registration > platform: move the early platform device support to arch/sh > sh: add the sh_ prefix to early platform symbols > > arch/sh/drivers/Makefile | 2 +- > arch/sh/drivers/platform_early.c | 347 +++++++++++++++++++++++++ > arch/sh/include/asm/platform_early.h | 61 +++++ > arch/sh/kernel/cpu/sh2/setup-sh7619.c | 3 +- > arch/sh/kernel/cpu/sh2a/setup-mxg.c | 3 +- > arch/sh/kernel/cpu/sh2a/setup-sh7201.c | 3 +- > arch/sh/kernel/cpu/sh2a/setup-sh7203.c | 3 +- > arch/sh/kernel/cpu/sh2a/setup-sh7206.c | 3 +- > arch/sh/kernel/cpu/sh2a/setup-sh7264.c | 3 +- > arch/sh/kernel/cpu/sh2a/setup-sh7269.c | 3 +- > arch/sh/kernel/cpu/sh3/setup-sh3.c | 1 + > arch/sh/kernel/cpu/sh3/setup-sh7705.c | 3 +- > arch/sh/kernel/cpu/sh3/setup-sh770x.c | 3 +- > arch/sh/kernel/cpu/sh3/setup-sh7710.c | 3 +- > arch/sh/kernel/cpu/sh3/setup-sh7720.c | 3 +- > arch/sh/kernel/cpu/sh4/setup-sh4-202.c | 3 +- > arch/sh/kernel/cpu/sh4/setup-sh7750.c | 9 +- > arch/sh/kernel/cpu/sh4/setup-sh7760.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7343.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7366.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7722.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7723.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7724.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7734.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7757.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7763.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7770.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7780.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7785.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-sh7786.c | 3 +- > arch/sh/kernel/cpu/sh4a/setup-shx3.c | 3 +- > arch/sh/kernel/cpu/sh5/setup-sh5.c | 3 +- > arch/sh/kernel/setup.c | 3 +- > arch/sh/kernel/time.c | 5 +- > drivers/base/platform.c | 288 -------------------- > drivers/clocksource/sh_cmt.c | 13 +- > drivers/clocksource/sh_mtu2.c | 13 +- > drivers/clocksource/sh_tmu.c | 14 +- > drivers/clocksource/timer-ti-dm.c | 1 - > drivers/tty/serial/sh-sci.c | 11 +- > include/linux/platform_device.h | 64 +---- > 41 files changed, 525 insertions(+), 388 deletions(-) > create mode 100644 arch/sh/drivers/platform_early.c > create mode 100644 arch/sh/include/asm/platform_early.h > > -- > 2.18.0 > Ping for 4.20. This is the third release cycle I'm trying to get this merged and there never were any objections. Bart