From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-arch-owner@vger.kernel.org>
Received: from mail-yw1-f65.google.com ([209.85.161.65]:34724 "EHLO
        mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726269AbeIXN4Q (ORCPT
        <rfc822;linux-arch@vger.kernel.org>); Mon, 24 Sep 2018 09:56:16 -0400
Received: by mail-yw1-f65.google.com with SMTP id m129-v6so1756770ywc.1
        for <linux-arch@vger.kernel.org>; Mon, 24 Sep 2018 00:55:27 -0700 (PDT)
MIME-Version: 1.0
References: <1537455973-12468-1-git-send-email-firoz.khan@linaro.org>
 <1537455973-12468-5-git-send-email-firoz.khan@linaro.org> <CAMuHMdWZv7eKt+2CSXQ3kgPXc-Vvm7o7zED9afXxnG8dh6+nFA@mail.gmail.com>
In-Reply-To: <CAMuHMdWZv7eKt+2CSXQ3kgPXc-Vvm7o7zED9afXxnG8dh6+nFA@mail.gmail.com>
From: Firoz Khan <firoz.khan@linaro.org>
Date: Mon, 24 Sep 2018 13:25:15 +0530
Message-ID: <CALxhOng7vodqyOAceTbv_LxLhe2KfuEgHSx+=8Dj57McQX1qCQ@mail.gmail.com>
Subject: Re: [PATCH v2 4/5] m68k: uapi header and system call table file generation
Content-Type: text/plain; charset="UTF-8"
Sender: linux-arch-owner@vger.kernel.org
List-ID: <linux-arch.vger.kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k <linux-m68k@lists.linux-m68k.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Philippe Ombredanne <pombredanne@nexb.com>, Thomas Gleixner <tglx@linutronix.de>, Kate Stewart <kstewart@linuxfoundation.org>, y2038 Mailman List <y2038@lists.linaro.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux-Arch <linux-arch@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, Deepa Dinamani <deepa.kernel@gmail.com>, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Message-ID: <20180924075515.nT6TdZnlY5DG1Y1bFDmpZclUsek2EHqMoE-r2OHIobw@z>

On Mon, 24 Sep 2018 at 12:35, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Firoz,
>
> On Thu, Sep 20, 2018 at 5:07 PM Firoz Khan <firoz.khan@linaro.org> wrote:
> > System call table generation script must be run to generate
> > unistd_32.h and syscall_table.h files. This patch will have
> > changes which will invokes the script.
> >
> > This patch will generate unistd_32.h and syscall_table.h
> > files by the syscall table generation script invoked by
> > arch/m68k/Makefile and the generated files against the
> > removed files will be identical.
> >
> > The generated uapi header file will be included in
> > uapi/asm/unistd.h and generated system call table support
> > file will be included by arch/m68k/kernel/syscall_table.S
> > file.
> >
> > Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
>
> Thanks for your patch!
>
> > --- a/arch/m68k/include/asm/Kbuild
> > +++ b/arch/m68k/include/asm/Kbuild
> > @@ -24,3 +24,4 @@ generic-y += topology.h
> >  generic-y += trace_clock.h
> >  generic-y += word-at-a-time.h
> >  generic-y += xor.h
> > +generic-y += syscall_table.h
> > \ No newline at end of file
>
> Please add the missing newline.

Sure. Will do. Thanks!

>
> > diff --git a/arch/m68k/include/uapi/asm/Kbuild b/arch/m68k/include/uapi/asm/Kbuild
> > index c2e26a4..6d600e9 100644
> > --- a/arch/m68k/include/uapi/asm/Kbuild
> > +++ b/arch/m68k/include/uapi/asm/Kbuild
> > @@ -21,3 +21,4 @@ generic-y += statfs.h
> >  generic-y += termbits.h
> >  generic-y += termios.h
> >  generic-y += types.h
> > +generic-y += unistd_32.h
> > \ No newline at end of file
>
> Likewise.
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds