linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
	linus.walleij@linaro.org, akpm@linux-foundation.org,
	linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [RESEND PATCH v4 1/8] bitops: Introduce the for_each_set_clump macro
Date: Wed, 3 Oct 2018 14:48:04 +0300	[thread overview]
Message-ID: <20181003114804.GE15943@smile.fi.intel.com> (raw)
Message-ID: <20181003114804.L4T-Y2eMJ6d4K0T6UolzymHqUiQtKUKBrnaFB5N5hpE@z> (raw)
In-Reply-To: <20181002082142.GC15943@smile.fi.intel.com>

On Tue, Oct 02, 2018 at 11:21:42AM +0300, Andy Shevchenko wrote:

> I would rather go with two prototypes to get()/set() a clump in the bitmap
> in a way when it's aligned and BITS_PER_LONG % clump_size == 0.

To make things much easier, restrict clump_size to the one
from the following set:

1, 2, 4, 8, 16, 32 even on 64-bit platforms.

If it would be simpler solution to add 64 here (implying 32-bit platform),
I would vote for that.

For the generic case we might need something like:

unsigned long bitmap_get_bits(unsigned long *src, unsigned int start, unsigned int nbits)
{
	assert(nbits > BITS_PER_LONG);

	/* Something like Rasmus proposed earlier */
}

And similar to setter.


-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2018-10-03 18:36 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02  1:12 [RESEND PATCH v4 0/8] Introduce the for_each_set_clump macro William Breathitt Gray
2018-10-02  1:12 ` William Breathitt Gray
2018-10-02  1:13 ` [RESEND PATCH v4 1/8] bitops: " William Breathitt Gray
2018-10-02  1:13   ` William Breathitt Gray
2018-10-02  7:42   ` Rasmus Villemoes
2018-10-02  7:42     ` Rasmus Villemoes
2018-10-02  8:21     ` Andy Shevchenko
2018-10-02  8:21       ` Andy Shevchenko
2018-10-03 11:48       ` Andy Shevchenko [this message]
2018-10-03 11:48         ` Andy Shevchenko
2018-10-04 10:36         ` William Breathitt Gray
2018-10-04 10:36           ` William Breathitt Gray
2018-10-04 12:10           ` Andy Shevchenko
2018-10-04 12:10             ` Andy Shevchenko
2018-10-04 10:30       ` William Breathitt Gray
2018-10-04 10:30         ` William Breathitt Gray
2018-10-04 10:03     ` William Breathitt Gray
2018-10-04 10:03       ` William Breathitt Gray
2018-10-02  1:14 ` [RESEND PATCH v4 2/8] lib/test_bitmap.c: Add for_each_set_clump test cases William Breathitt Gray
2018-10-02  1:14   ` William Breathitt Gray
2018-10-02  1:14 ` [RESEND PATCH v4 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump macro William Breathitt Gray
2018-10-02  1:14   ` William Breathitt Gray
2018-10-02  7:00   ` Rasmus Villemoes
2018-10-02  7:00     ` Rasmus Villemoes
2018-10-14  4:19     ` William Breathitt Gray
2018-10-14  4:19       ` William Breathitt Gray
2018-10-15 11:59       ` Rasmus Villemoes
2018-10-15 11:59         ` Rasmus Villemoes
2018-10-17  1:54         ` William Breathitt Gray
2018-10-17  1:54           ` William Breathitt Gray
2018-10-02  1:15 ` [RESEND PATCH v4 4/8] gpio: 104-idi-48: " William Breathitt Gray
2018-10-02  1:15   ` William Breathitt Gray
2018-10-02  1:15 ` [RESEND PATCH v4 5/8] gpio: gpio-mm: " William Breathitt Gray
2018-10-02  1:15   ` William Breathitt Gray
2018-10-02  1:15 ` [RESEND PATCH v4 6/8] gpio: ws16c48: " William Breathitt Gray
2018-10-02  1:15   ` William Breathitt Gray
2018-10-02  1:16 ` [RESEND PATCH v4 7/8] gpio: pci-idio-16: " William Breathitt Gray
2018-10-02  1:16   ` William Breathitt Gray
2018-10-02  1:16 ` [RESEND PATCH v4 8/8] gpio: pcie-idio-24: " William Breathitt Gray
2018-10-02  1:16   ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181003114804.GE15943@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).