From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net ([212.227.17.20]:33327 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbeJJDcL (ORCPT ); Tue, 9 Oct 2018 23:32:11 -0400 Date: Tue, 9 Oct 2018 22:13:21 +0200 From: Helge Deller Subject: Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation Message-ID: <20181009201321.GA28911@ls3530.fritz.box> References: <1538975801-13735-1-git-send-email-firoz.khan@linaro.org> <1538975801-13735-5-git-send-email-firoz.khan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1538975801-13735-5-git-send-email-firoz.khan@linaro.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Firoz Khan Cc: linux-parisc@vger.kernel.org, "James E . J . Bottomley" , Helge Deller , Thomas Gleixner , Greg Kroah-Hartman , Philippe Ombredanne , Kate Stewart , y2038@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org Message-ID: <20181009201321.ttQ6mm5M-Tq_hJ1pA0xlebtS8ux3a-xsu_U8hSi_mws@z> * Firoz Khan : > System call table generation script must be run to generate > unistd_32/64.h and syscall_table_32/64/c32.h files. This patch > will have changes which will invokes the script. > > This patch will generate unistd_32/64.h and syscall_table_ > 32/64/c32.h files by the syscall table generation script > invoked by arch/parisc/Makefile and the generated files against > the removed files will be identical. > > The generated uapi header file will be included in uapi/asm/ > unistd_32/64.h and generated system call table support file will > be included by arch/sparc/kernel/syscall_table_32/64.S file. > > Signed-off-by: Firoz Khan > --- > arch/parisc/Makefile | 4 + > arch/parisc/include/asm/Kbuild | 3 + > arch/parisc/include/uapi/asm/Kbuild | 2 + > arch/parisc/include/uapi/asm/unistd.h | 373 +-------------------------- > arch/parisc/kernel/syscall.S | 12 +- > arch/parisc/kernel/syscall_table.S | 459 ---------------------------------- Can we please get rid of those two new files: > arch/parisc/kernel/syscall_table_32.S | 13 + > arch/parisc/kernel/syscall_table_64.S | 20 ++ Both are not needed (at least on parisc) if you apply the following patch on top of your patch series. This patch finally fixes the 64-bit kernel on parisc (tested on real hardware). Helge diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S index 2523b83b88d8..45cddeeb968f 100644 --- a/arch/parisc/kernel/syscall.S +++ b/arch/parisc/kernel/syscall.S @@ -923,10 +923,20 @@ ENTRY(lws_table) END(lws_table) /* End of lws table */ -#include "syscall_table_32.S" +#define __SYSCALL(nr, entry, nargs) ASM_ULONG_INSN entry + +ENTRY(sys_call_table) +#if defined(CONFIG_64BIT) +#include /* compat syscalls */ +#else +#include /* 32-bit native syscalls */ +#endif +END(sys_call_table) + #ifdef CONFIG_64BIT -#define SYSCALL_TABLE_64BIT -#include "syscall_table_64.S" +ENTRY(sys_call_table64) +#include /* 64-bit native syscalls */ +END(sys_call_table64) #endif /*