From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f196.google.com ([209.85.219.196]:38703 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbeJKP5L (ORCPT ); Thu, 11 Oct 2018 11:57:11 -0400 Received: by mail-yb1-f196.google.com with SMTP id e190-v6so3293115ybb.5 for ; Thu, 11 Oct 2018 01:30:57 -0700 (PDT) MIME-Version: 1.0 References: <1538975801-13735-1-git-send-email-firoz.khan@linaro.org> <1538975801-13735-5-git-send-email-firoz.khan@linaro.org> <20181009201321.GA28911@ls3530.fritz.box> In-Reply-To: From: Firoz Khan Date: Thu, 11 Oct 2018 14:00:45 +0530 Message-ID: Subject: Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Helge Deller , linux-parisc@vger.kernel.org, "James E . J . Bottomley" , Thomas Gleixner , Greg Kroah-Hartman , Philippe Ombredanne , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , Linux-Arch , Deepa Dinamani , Marcin Juszkiewicz Message-ID: <20181011083045.L64eiFIFE2qRfjRchRxkUQ5H-oEnqx8FR6ImRMo3_Xw@z> Hi Arnd, On Thu, 11 Oct 2018 at 12:37, Arnd Bergmann wrote: > > On Thu, Oct 11, 2018 at 8:10 AM Firoz Khan wrote: > > On Wed, 10 Oct 2018 at 01:48, Helge Deller wrote: > > > > > > * Firoz Khan : > > > > System call table generation script must be run to generate > > > > unistd_32/64.h and syscall_table_32/64/c32.h files. This patch > > > > will have changes which will invokes the script. > > > > > > > > This patch will generate unistd_32/64.h and syscall_table_ > > > > 32/64/c32.h files by the syscall table generation script > > > > invoked by arch/parisc/Makefile and the generated files against > > > > the removed files will be identical. > > > > > > > > The generated uapi header file will be included in uapi/asm/ > > > > unistd_32/64.h and generated system call table support file will > > > > be included by arch/sparc/kernel/syscall_table_32/64.S file. > > > > > > > > Signed-off-by: Firoz Khan > > > > --- > > > > arch/parisc/Makefile | 4 + > > > > arch/parisc/include/asm/Kbuild | 3 + > > > > arch/parisc/include/uapi/asm/Kbuild | 2 + > > > > arch/parisc/include/uapi/asm/unistd.h | 373 +-------------------------- > > > > arch/parisc/kernel/syscall.S | 12 +- > > > > arch/parisc/kernel/syscall_table.S | 459 ---------------------------------- > > > > > > > > > Can we please get rid of those two new files: > > > > Yes, we don't need those files some of the architecture and other > > architecture does have same/similar files. That's why I added below > > files, so every architecture implementation looks same. > > > > I feel it is better to remove these files. > > Arnd, Do u have any comment on this? > > I agree with Helge. This was a big different in a previous version where > you generated the syscall_table.S file from syscalls.tbl, but now that > you generade the syscall_table.h file instead, we no longer need to > keep the .S file synchronized across architectures. > > Having a separate .S file would make it easier to replace that with > a .c file later, but it's also easier to split it out after your series than > as part of it. Sure. Thanks for your comments. Firoz > > Arnd