From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v5 06/27] x86/cet: Control protection exception handler Date: Wed, 14 Nov 2018 21:28:02 +0100 Message-ID: <20181114202802.GN13926@zn.tnic> References: <20181011151523.27101-1-yu-cheng.yu@intel.com> <20181011151523.27101-7-yu-cheng.yu@intel.com> <20181114184436.GK13926@zn.tnic> <307b6162b0270871e664ca88a96b4ea0d1b3f65b.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <307b6162b0270871e664ca88a96b4ea0d1b3f65b.camel@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pa List-Id: linux-arch.vger.kernel.org On Wed, Nov 14, 2018 at 12:19:42PM -0800, Yu-cheng Yu wrote: > Yes, I was not sure if the addition should follow the existing style (which does > not have identifier names). What do you think is right? Yeah, we've converted them all now to named params: https://git.kernel.org/tip/8e1599fcac2efda8b7d433ef69d2492f0b351e3f It probably would be easier if you redo your patchset ontop of current tip/master. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([5.9.137.197]:47752 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725756AbeKOGcv (ORCPT ); Thu, 15 Nov 2018 01:32:51 -0500 Date: Wed, 14 Nov 2018 21:28:02 +0100 From: Borislav Petkov Subject: Re: [PATCH v5 06/27] x86/cet: Control protection exception handler Message-ID: <20181114202802.GN13926@zn.tnic> References: <20181011151523.27101-1-yu-cheng.yu@intel.com> <20181011151523.27101-7-yu-cheng.yu@intel.com> <20181114184436.GK13926@zn.tnic> <307b6162b0270871e664ca88a96b4ea0d1b3f65b.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <307b6162b0270871e664ca88a96b4ea0d1b3f65b.camel@intel.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue Message-ID: <20181114202802.4y5FDeNB_-E30aNAjzNwvZ0UpxZzfkDBCbxhtARX6-Y@z> On Wed, Nov 14, 2018 at 12:19:42PM -0800, Yu-cheng Yu wrote: > Yes, I was not sure if the addition should follow the existing style (which does > not have identifier names). What do you think is right? Yeah, we've converted them all now to named params: https://git.kernel.org/tip/8e1599fcac2efda8b7d433ef69d2492f0b351e3f It probably would be easier if you redo your patchset ontop of current tip/master. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.