From: Guo Ren <guoren@kernel.org> To: Mike Rapoport <rppt@linux.ibm.com> Cc: Michal Hocko <mhocko@suse.com>, Catalin Marinas <catalin.marinas@arm.com>, Palmer Dabbelt <palmer@sifive.com>, linux-mips@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, Richard Weinberger <richard@nod.at>, Helge Deller <deller@gmx.de>, x86@kernel.org, Russell King <linux@armlinux.org.uk>, Matthew Wilcox <willy@infradead.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Matt Turner <mattst88@gmail.com>, Sam Creasey <sammy@sammy.net>, Arnd Bergmann <arnd@arndb.de>, linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, Greentime Hu <green.hu@gmail.com>, nios2-dev@lists.rocketboards.org, Guan Xuetao <gxt@pku.edu.cn>, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Kuo <rkuo@codeaurora.org>, Paul Burton <paul.burton@mips.com>, linux-alpha@vger.kernel Subject: Re: [PATCH 05/15] csky: switch to generic version of pte allocation Date: Sat, 4 May 2019 00:03:48 +0800 [thread overview] Message-ID: <20190503160348.GA9526@guoren-Inspiron-7460> (raw) In-Reply-To: <1556810922-20248-6-git-send-email-rppt@linux.ibm.com> Hi Mike, Acked-by: Guo Ren <ren_guo@c-sky.com> On Thu, May 02, 2019 at 06:28:32PM +0300, Mike Rapoport wrote: > The csky implementation pte_alloc_one(), pte_free_kernel() and pte_free() > is identical to the generic except of lack of __GFP_ACCOUNT for the user > PTEs allocation. > > Switch csky to use generic version of these functions. Ok. > > The csky implementation of pte_alloc_one_kernel() is not replaced because > it does not clear the allocated page but rather sets each PTE in it to a > non-zero value. Yes, we must set each PTE to _PAGE_GLOBAL because hardware refill the MMU TLB entry with two PTEs and it use the result of pte0.global | pte1.global. If pte0 is valid and pte1 is invalid, we must set _PAGE_GLOBAL in invalid pte entry. Fortunately, there is no performance issue. > > The pte_free_kernel() and pte_free() versions on csky are identical to the > generic ones and can be simply dropped. Ok. Best Regards Guo Ren > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > --- > arch/csky/include/asm/pgalloc.h | 30 +++--------------------------- > 1 file changed, 3 insertions(+), 27 deletions(-) > > diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h > index d213bb4..98c571670 100644 > --- a/arch/csky/include/asm/pgalloc.h > +++ b/arch/csky/include/asm/pgalloc.h > @@ -8,6 +8,9 @@ > #include <linux/mm.h> > #include <linux/sched.h> > > +#define __HAVE_ARCH_PTE_ALLOC_ONE_KERNEL > +#include <asm-generic/pgalloc.h> /* for pte_{alloc,free}_one */ > + > static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, > pte_t *pte) > { > @@ -39,33 +42,6 @@ static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > return pte; > } > > -static inline struct page *pte_alloc_one(struct mm_struct *mm) > -{ > - struct page *pte; > - > - pte = alloc_pages(GFP_KERNEL | __GFP_ZERO, 0); > - if (!pte) > - return NULL; > - > - if (!pgtable_page_ctor(pte)) { > - __free_page(pte); > - return NULL; > - } > - > - return pte; > -} > - > -static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) > -{ > - free_pages((unsigned long)pte, PTE_ORDER); > -} > - > -static inline void pte_free(struct mm_struct *mm, pgtable_t pte) > -{ > - pgtable_page_dtor(pte); > - __free_pages(pte, PTE_ORDER); > -} > - > static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) > { > free_pages((unsigned long)pgd, PGD_ORDER); > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org> To: Mike Rapoport <rppt@linux.ibm.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Arnd Bergmann <arnd@arndb.de>, Catalin Marinas <catalin.marinas@arm.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Greentime Hu <green.hu@gmail.com>, Guan Xuetao <gxt@pku.edu.cn>, Helge Deller <deller@gmx.de>, Ley Foon Tan <lftan@altera.com>, Matthew Wilcox <willy@infradead.org>, Matt Turner <mattst88@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>, Michal Hocko <mhocko@suse.com>, Palmer Dabbelt <palmer@sifive.com>, Paul Burton <paul.burton@mips.com>, Richard Kuo <rkuo@codeaurora.org>, Richard Weinberger <richard@nod.at>, Russell King <linux@armlinux.org.uk>, Sam Creasey <sammy@sammy.net>, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-um@lists.infradead.org, nios2-dev@lists.rocketboards.org Subject: Re: [PATCH 05/15] csky: switch to generic version of pte allocation Date: Sat, 4 May 2019 00:03:48 +0800 [thread overview] Message-ID: <20190503160348.GA9526@guoren-Inspiron-7460> (raw) Message-ID: <20190503160348.ZIMqp-sc3mAcYC4AD6NuxbGk2SHcPEUMhB4nvv7JskI@z> (raw) In-Reply-To: <1556810922-20248-6-git-send-email-rppt@linux.ibm.com> Hi Mike, Acked-by: Guo Ren <ren_guo@c-sky.com> On Thu, May 02, 2019 at 06:28:32PM +0300, Mike Rapoport wrote: > The csky implementation pte_alloc_one(), pte_free_kernel() and pte_free() > is identical to the generic except of lack of __GFP_ACCOUNT for the user > PTEs allocation. > > Switch csky to use generic version of these functions. Ok. > > The csky implementation of pte_alloc_one_kernel() is not replaced because > it does not clear the allocated page but rather sets each PTE in it to a > non-zero value. Yes, we must set each PTE to _PAGE_GLOBAL because hardware refill the MMU TLB entry with two PTEs and it use the result of pte0.global | pte1.global. If pte0 is valid and pte1 is invalid, we must set _PAGE_GLOBAL in invalid pte entry. Fortunately, there is no performance issue. > > The pte_free_kernel() and pte_free() versions on csky are identical to the > generic ones and can be simply dropped. Ok. Best Regards Guo Ren > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > --- > arch/csky/include/asm/pgalloc.h | 30 +++--------------------------- > 1 file changed, 3 insertions(+), 27 deletions(-) > > diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h > index d213bb4..98c571670 100644 > --- a/arch/csky/include/asm/pgalloc.h > +++ b/arch/csky/include/asm/pgalloc.h > @@ -8,6 +8,9 @@ > #include <linux/mm.h> > #include <linux/sched.h> > > +#define __HAVE_ARCH_PTE_ALLOC_ONE_KERNEL > +#include <asm-generic/pgalloc.h> /* for pte_{alloc,free}_one */ > + > static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, > pte_t *pte) > { > @@ -39,33 +42,6 @@ static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > return pte; > } > > -static inline struct page *pte_alloc_one(struct mm_struct *mm) > -{ > - struct page *pte; > - > - pte = alloc_pages(GFP_KERNEL | __GFP_ZERO, 0); > - if (!pte) > - return NULL; > - > - if (!pgtable_page_ctor(pte)) { > - __free_page(pte); > - return NULL; > - } > - > - return pte; > -} > - > -static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) > -{ > - free_pages((unsigned long)pte, PTE_ORDER); > -} > - > -static inline void pte_free(struct mm_struct *mm, pgtable_t pte) > -{ > - pgtable_page_dtor(pte); > - __free_pages(pte, PTE_ORDER); > -} > - > static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) > { > free_pages((unsigned long)pgd, PGD_ORDER); > -- > 2.7.4 >
next prev parent reply other threads:[~2019-05-03 16:03 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-02 15:28 [PATCH 00/15] introduce generic pte_{alloc,free}_one[_kernel] Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 01/15] asm-generic, x86: introduce generic pte_{alloc, free}_one[_kernel] Mike Rapoport 2019-05-02 15:28 ` [PATCH 01/15] asm-generic, x86: introduce generic pte_{alloc,free}_one[_kernel] Mike Rapoport 2019-05-02 19:03 ` Paul Burton 2019-05-02 19:03 ` Paul Burton 2019-05-05 6:15 ` Mike Rapoport 2019-05-05 6:15 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 02/15] alpha: switch to generic version of pte allocation Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 03/15] arm: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 04/15] arm64: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-03 10:05 ` Mark Rutland 2019-05-03 10:05 ` Mark Rutland 2019-05-05 6:19 ` Mike Rapoport 2019-05-05 6:19 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 05/15] csky: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-03 16:03 ` Guo Ren [this message] 2019-05-03 16:03 ` Guo Ren 2019-05-03 16:18 ` Guo Ren 2019-05-03 16:18 ` Guo Ren 2019-05-02 15:28 ` [PATCH 06/15] hexagon: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 07/15] m68k: sun3: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 08/15] mips: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 19:09 ` Paul Burton 2019-05-02 19:09 ` Paul Burton 2019-05-05 6:17 ` Mike Rapoport 2019-05-05 6:17 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 09/15] nds32: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-07 6:49 ` Greentime Hu 2019-05-07 6:49 ` Greentime Hu 2019-05-02 15:28 ` [PATCH 10/15] nios2: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 11/15] parisc: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 12/15] powerpc/nohash/64: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-02 16:56 ` Christophe Leroy 2019-05-02 16:56 ` Christophe Leroy 2019-05-05 6:23 ` Mike Rapoport 2019-05-05 6:23 ` Mike Rapoport 2019-05-02 15:28 ` [PATCH 13/15] riscv: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-06 18:25 ` Palmer Dabbelt 2019-05-06 18:25 ` Palmer Dabbelt 2019-05-02 15:28 ` [PATCH 14/15] um: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport 2019-05-03 13:28 ` Anton Ivanov 2019-05-03 13:28 ` Anton Ivanov 2019-05-02 15:28 ` [PATCH 15/15] unicore32: " Mike Rapoport 2019-05-02 15:28 ` Mike Rapoport
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190503160348.GA9526@guoren-Inspiron-7460 \ --to=guoren@kernel.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=deller@gmx.de \ --cc=geert@linux-m68k.org \ --cc=green.hu@gmail.com \ --cc=gxt@pku.edu.cn \ --cc=linux-alpha@vger.kernel \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hexagon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-m68k@lists.linux-m68k.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-parisc@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-um@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=mattst88@gmail.com \ --cc=mhocko@suse.com \ --cc=nios2-dev@lists.rocketboards.org \ --cc=palmer@sifive.com \ --cc=paul.burton@mips.com \ --cc=richard@nod.at \ --cc=rkuo@codeaurora.org \ --cc=rppt@linux.ibm.com \ --cc=sammy@sammy.net \ --cc=willy@infradead.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).