From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RFC PATCH 1/2] Explicitly include linux/major.h where it is needed Date: Wed, 17 Jun 2020 07:58:43 +0200 Message-ID: <20200617055843.GB25631@kroah.com> References: <20200617092614.7897ccb2@canb.auug.org.au> <20200617092747.0cadb2de@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.29.99]:40264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725929AbgFQF6q (ORCPT ); Wed, 17 Jun 2020 01:58:46 -0400 Content-Disposition: inline In-Reply-To: <20200617092747.0cadb2de@canb.auug.org.au> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Linux-kernel Mailing List , linux-arch@vger.kernel.org, Arnd Bergmann On Wed, Jun 17, 2020 at 09:27:47AM +1000, Stephen Rothwell wrote: > This is in preparation for removing the include of major.h where it is > not needed. > > These files were found using > > grep -E -L '[<"](uapi/)?linux/major\.h' $(git grep -l -w -f /tmp/xx) > > where /tmp/xx contains all the symbols defined in major.h. There were > a couple of files in that list that did not need the include since the > references are in comments. > > Signed-off-by: Stephen Rothwell Any reason this had an RFC, but patch 2/2 did not? They look good to me, I will be glad to take these, but do you still want reviews from others for this? It seems simple enough to me... thanks, greg k-h