From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file Date: Wed, 17 Jun 2020 18:12:26 -0700 Message-ID: <20200617181226.ab213ea1531b5dd6eca1b0b6@linux-foundation.org> References: <20200609120533.25867-1-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200609120533.25867-1-joro@8bytes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane-mx.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Joerg Roedel Cc: linux-arch@vger.kernel.org, Stephen Rothwell , jroedel@suse.de, linux-mm@kvack.org, peterz@infradead.org, Linus Torvalds , linuxppc-dev@lists.ozlabs.org, Steven Rostedt , Mike Rapoport , Abdul Haleem , linux-next@vger.kernel.org, Satheesh Rajendran , Andy Lutomirski , manvanth@linux.vnet.ibm.com, hch@lst.de, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Tue, 9 Jun 2020 14:05:33 +0200 Joerg Roedel wrote: > From: Joerg Roedel > > The functions are only used in two source files, so there is no need > for them to be in the global header. Move them to the new > header and include it only where needed. > > ... > > new file mode 100644 > index 000000000000..1dcc865029a2 > --- /dev/null > +++ b/include/linux/pgalloc-track.h > @@ -0,0 +1,51 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_PGALLLC_TRACK_H > +#define _LINUX_PGALLLC_TRACK_H hm, no #includes. I guess this is OK, given the limited use. But it does make one wonder whether ioremap.c should be moved from lib/ to mm/ and this file should be moved from include/linux/ to mm/. Oh well. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 17 Jun 2020 18:12:26 -0700 From: Andrew Morton Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file Message-ID: <20200617181226.ab213ea1531b5dd6eca1b0b6@linux-foundation.org> In-Reply-To: <20200609120533.25867-1-joro@8bytes.org> References: <20200609120533.25867-1-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Joerg Roedel Cc: peterz@infradead.org, jroedel@suse.de, Andy Lutomirski , Abdul Haleem , Satheesh Rajendran , Stephen Rothwell , manvanth@linux.vnet.ibm.com, linux-next@vger.kernel.org, Steven Rostedt , Mike Rapoport , Linus Torvalds , linuxppc-dev@lists.ozlabs.org, hch@lst.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: Message-ID: <20200618011226.S6BBTHmjR3Aj-z6AnwK28EFIbrUz94i7UYu15HEEYHU@z> On Tue, 9 Jun 2020 14:05:33 +0200 Joerg Roedel wrote: > From: Joerg Roedel > > The functions are only used in two source files, so there is no need > for them to be in the global header. Move them to the new > header and include it only where needed. > > ... > > new file mode 100644 > index 000000000000..1dcc865029a2 > --- /dev/null > +++ b/include/linux/pgalloc-track.h > @@ -0,0 +1,51 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_PGALLLC_TRACK_H > +#define _LINUX_PGALLLC_TRACK_H hm, no #includes. I guess this is OK, given the limited use. But it does make one wonder whether ioremap.c should be moved from lib/ to mm/ and this file should be moved from include/linux/ to mm/. Oh well.