From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A24C433E2 for ; Sat, 29 Aug 2020 09:25:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E31E206C0 for ; Sat, 29 Aug 2020 09:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726876AbgH2JZf (ORCPT ); Sat, 29 Aug 2020 05:25:35 -0400 Received: from verein.lst.de ([213.95.11.211]:44199 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbgH2JZe (ORCPT ); Sat, 29 Aug 2020 05:25:34 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 217DA68C4E; Sat, 29 Aug 2020 11:25:32 +0200 (CEST) Date: Sat, 29 Aug 2020 11:25:31 +0200 From: Christoph Hellwig To: Linus Torvalds Cc: Christoph Hellwig , Al Viro , Michael Ellerman , the arch/x86 maintainers , Kees Cook , Linux Kernel Mailing List , linux-fsdevel , linux-arch , linuxppc-dev Subject: Re: [PATCH 08/10] x86: remove address space overrides using set_fs() Message-ID: <20200829092531.GC8833@lst.de> References: <20200827150030.282762-1-hch@lst.de> <20200827150030.282762-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-arch-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Thu, Aug 27, 2020 at 11:15:12AM -0700, Linus Torvalds wrote: > > SYM_FUNC_START(__put_user_2) > > - ENTER > > - mov TASK_addr_limit(%_ASM_BX),%_ASM_BX > > + LOAD_TASK_SIZE_MAX > > sub $1,%_ASM_BX > > It's even more obvious here. We load a constant and then immediately > do a "sub $1" on that value. > > It's not a huge deal, you don't have to respin the series for this, I > just wanted to point it out so that people are aware of it and if I > forget somebody else will hopefully remember that "we should fix that > too". The changes seem easy enough and I need to respin at least for the lkdtm changes, and probaby also for a pending fix in the low-level x86 code that will hopefully be picked up for 5.9. But the more important questions is: how do we want to pick the series up? Especially due to the splice changes I really want it to be in linux-next as long as possible.