From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B92C433E2 for ; Sat, 29 Aug 2020 09:15:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BBC12071B for ; Sat, 29 Aug 2020 09:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598692527; bh=iRDTespXVTvx6CS5lM7zVBWg9/uBKo9ho+raX1YWhk8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=rBQvF5XcyKNAK0qoMvoy2p6PsTWzvTK8K1beYui9FBAxSOI4+KGhPaVk3XSck1pEn oBSC5OusyAfMNMflw4ygWkR3p/xflFi2TYRSDaCpaXe0Hi1iHlq00fI4x2fph1vuPC QiI/KL42Jge7Yy4jTT0rDCrxHxJ0na8K8MMASQus= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgH2JP1 (ORCPT ); Sat, 29 Aug 2020 05:15:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:56726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbgH2JP0 (ORCPT ); Sat, 29 Aug 2020 05:15:26 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 059DE20776; Sat, 29 Aug 2020 09:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598692526; bh=iRDTespXVTvx6CS5lM7zVBWg9/uBKo9ho+raX1YWhk8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kLv9i3FE1KJO726SXimmRTd74h3DFZ+WHr/YOdiQVRxi6akRkbZlT2Q1sE3quZQc2 mfyrjZ8GybJbykf+AMM2xXloYwjG0VYaMOxL0H0rc64Dj2cpjsWrdmjCmpeBSQpgxo 2IUi676N4NIE3cu+b1ue+pu2Lz/zXplk2Y9BGb84= Date: Sat, 29 Aug 2020 18:15:20 +0900 From: Masami Hiramatsu To: Cameron Cc: Peter Zijlstra , Masami Hiramatsu , linux-kernel@vger.kernel.org, Eddy_Wu@trendmicro.com, x86@kernel.org, davem@davemloft.net, rostedt@goodmis.org, naveen.n.rao@linux.ibm.com, anil.s.keshavamurthy@intel.com, linux-arch@vger.kernel.org, oleg@redhat.com, will@kernel.org, paulmck@kernel.org Subject: Re: [RFC][PATCH 7/7] kprobes: Replace rp->free_instance with freelist Message-Id: <20200829181520.ec52c425fc0a9d220559230a@kernel.org> In-Reply-To: References: <20200827161237.889877377@infradead.org> <20200827161754.594247581@infradead.org> <20200828084851.GQ1362448@hirez.programming.kicks-ass.net> <20200828181341.c1da066360c6085d48850e22@kernel.org> <20200828091813.GU1362448@hirez.programming.kicks-ass.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, 28 Aug 2020 22:31:17 -0400 Cameron wrote: > On Fri, Aug 28, 2020 at 10:29 PM Cameron wrote: > > I thought about this some more, and actually, it should be safe. > > Although I should note that it's important that the flags/refcount are > not overwritten > even after the node is taken off the freelist. Thanks for the check, but I personally would like to keep it separated because the memory layouts of those in-kernel list-like data structures can be changed by debug config option... Thank you, -- Masami Hiramatsu