From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8ED2C4363A for ; Wed, 21 Oct 2020 20:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F48E24178 for ; Wed, 21 Oct 2020 20:04:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gd9gv83u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439341AbgJUUEj (ORCPT ); Wed, 21 Oct 2020 16:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393042AbgJUUEj (ORCPT ); Wed, 21 Oct 2020 16:04:39 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F132C0613CE for ; Wed, 21 Oct 2020 13:04:38 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id s22so2135919pga.9 for ; Wed, 21 Oct 2020 13:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MyV1gJcxFAQQ3ezKzLWjL48pP/r6NIsOLeLTCnNX+6g=; b=gd9gv83uo3riBYpEs8PF3ugJNfzSNB4r5uzG6neNC4ucEYQ70ZAQ7SkiViN2BDIWTa 5FHnXZOzUUXdLzYnMhbsr4d8rz7li3H7J2bDv1CYRYR7wKMufb2lQRs+5RTT7gbMjECa QVv/pSQcNG3DxcpZ6JCFwhdlQlG2CHDdUMhOo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MyV1gJcxFAQQ3ezKzLWjL48pP/r6NIsOLeLTCnNX+6g=; b=lVjES+JdaQ+bwYjUBzZKdjr8QKlFGQAdsrBWxiiYDjg2leibtcuvqb76GaEzE3Tg5o n52JZ+0y+Cp11WmxOMMFztHEXmJhqp7HJ6aS0lcWa4qbJER9HnejWrkp4vhNmEdqvQWR AxeUcocZFD2ylQ+xmJoNcvCRM/WRWIMihD/eY0WvyyerZPSicoUjkM6fNq8CoWT4yAE2 CfvMGd/HWTO9+I910eZkMxG53ADDZz4DHYM9ifKwEG81C02DQIhXDp+5XIrnybqPZBJZ gDEE0HosbeBnlKYBtqOs8kV0Yj9PA3R7xDoJ1Q1I6r0ZfdJzF8oxyhOWqPB3NtKHvZ+l rNTA== X-Gm-Message-State: AOAM533R4RYrZ5uDODb3P7uJgvfO7nfduepDQ3GJ2fZZtsad7c4SCBQl NBCDvGXFsXetHWCGLIdq/Ie5Hw== X-Google-Smtp-Source: ABdhPJzQMDT4NjgzXCNMb4qxA0JuGTDiQqwPA10cT3Kb6VfbouwfalZpaZSnZbTuOeHKzIiS/h2y5Q== X-Received: by 2002:a65:664a:: with SMTP id z10mr4742041pgv.171.1603310677590; Wed, 21 Oct 2020 13:04:37 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n18sm3102678pff.129.2020.10.21.13.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 13:04:36 -0700 (PDT) Date: Wed, 21 Oct 2020 13:04:35 -0700 From: Kees Cook To: Ingo Molnar , x86@kernel.org Cc: Stephen Rothwell , Nick Desaulniers , Arnd Bergmann , clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] vmlinux.lds.h: Keep .ctors.* with .ctors Message-ID: <202010211303.4F8386F2@keescook> References: <20201005025720.2599682-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201005025720.2599682-1-keescook@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org [thread ping: x86 maintainers, can someone please take this?] On Sun, Oct 04, 2020 at 07:57:20PM -0700, Kees Cook wrote: > Under some circumstances, the compiler generates .ctors.* sections. This > is seen doing a cross compile of x86_64 from a powerpc64el host: > > x86_64-linux-gnu-ld: warning: orphan section `.ctors.65435' from `kernel/trace/trace_clock.o' being > placed in section `.ctors.65435' > x86_64-linux-gnu-ld: warning: orphan section `.ctors.65435' from `kernel/trace/ftrace.o' being > placed in section `.ctors.65435' > x86_64-linux-gnu-ld: warning: orphan section `.ctors.65435' from `kernel/trace/ring_buffer.o' being > placed in section `.ctors.65435' > > Include these orphans along with the regular .ctors section. > > Reported-by: Stephen Rothwell > Tested-by: Stephen Rothwell > Fixes: 83109d5d5fba ("x86/build: Warn on orphan section placement") > Signed-off-by: Kees Cook > --- > v2: brown paper bag version: fix whitespace for proper backslash alignment > --- > include/asm-generic/vmlinux.lds.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index 5430febd34be..b83c00c63997 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -684,6 +684,7 @@ > #ifdef CONFIG_CONSTRUCTORS > #define KERNEL_CTORS() . = ALIGN(8); \ > __ctors_start = .; \ > + KEEP(*(SORT(.ctors.*))) \ > KEEP(*(.ctors)) \ > KEEP(*(SORT(.init_array.*))) \ > KEEP(*(.init_array)) \ > -- > 2.25.1 > -- Kees Cook