From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BCAC56202 for ; Mon, 23 Nov 2020 10:22:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E0D02074B for ; Mon, 23 Nov 2020 10:22:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TDVt/xqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728182AbgKWKVy (ORCPT ); Mon, 23 Nov 2020 05:21:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727895AbgKWKVx (ORCPT ); Mon, 23 Nov 2020 05:21:53 -0500 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65EE6C0613CF for ; Mon, 23 Nov 2020 02:21:53 -0800 (PST) Received: by mail-ej1-x642.google.com with SMTP id a16so22531657ejj.5 for ; Mon, 23 Nov 2020 02:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KicNkypOIaNLZNofAMT0/dbRVfdiQb0EG7yDuWE5ulA=; b=TDVt/xqwo7FGjOiB50CURiRd4zX8Glpc/xzed4IR3D50NS0EqlijbKWHNsEmT9A92f opeYzaDlby6Pgpezpy0Z6eYOPQW6ipaIAyEAtip0SZR01YDtd+SICLsxoZ+9krn8s+et lULt1gHvEOthv2285g8UdKxZGn8PuitA3T+FAGLQ/qKxFihLT0OrTedRRYXRz8VblfZD a1sXohEAJiNhEPF+raDuSX6Ta4nQGnI6siEeVnxshXZXFTiwE+mIarl4EbBFaSYp4ZqT zvmMqJJexFfo+5+oFHJeofxyxcmA2hqWZAvCeahk9touSv1o0xYBPyhqFNpgNP0LgZcR CU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KicNkypOIaNLZNofAMT0/dbRVfdiQb0EG7yDuWE5ulA=; b=qwfugIMw0G7sFBLxRtMoeItE1aiegmOYP3rz3BOglWVsO3C/4RmtCMTK2JBsZ+dz3a RtUXVlUfqTcc5ksTT7lDeaggj/hBUfUc5pS1S4Sa+o1JMClJAPl3Y3Qay+iX0j2ksA0u bUD99aerLzTtJIEirq7+R8DWqUwQ5G23XBnYBH3bWwiiu+o5Ft6Rdha8ysgX3yHGSDTu PbbWgRTUQD+BZ+c75ffzcZypTQJiW52dItPsUPPBzVjl+CRdfSI1MMGQ+iI2ZD1Uwbrj qukZzY4Gu8w0kTUFirOg9xkUMtWCjYKOOyLFTOJ5L3ooOHpYpRv1XmZdLeReSDGF7T+g LIvg== X-Gm-Message-State: AOAM531nYFgFJg31d1DHQkBmVU1uTO7NBlQUCb7TIrVLpFbcil5vwGu8 lq28aoBAJdsU59DsU1lm4+Y5eA== X-Google-Smtp-Source: ABdhPJxFSYMYi0puK0drxRNruUpOKNZHKEgE3EPEQ608H69x9iUkj+1IRAw3SWeiVlPLVEVUtEhq+A== X-Received: by 2002:a17:906:8058:: with SMTP id x24mr44772875ejw.272.1606126911958; Mon, 23 Nov 2020 02:21:51 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:acac:b2ef:c7d:fd8a]) by smtp.gmail.com with ESMTPSA id k3sm4725861ejd.36.2020.11.23.02.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 02:21:51 -0800 (PST) Date: Mon, 23 Nov 2020 10:21:49 +0000 From: David Brazdil To: Sami Tolvanen Cc: Masahiro Yamada , Steven Rostedt , Will Deacon , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory Message-ID: <20201123102149.ogl642tw234qod62@google.com> References: <20201118220731.925424-1-samitolvanen@google.com> <20201118220731.925424-16-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118220731.925424-16-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org Hey Sami, On Wed, Nov 18, 2020 at 02:07:29PM -0800, Sami Tolvanen wrote: > We use objcopy to manipulate ELF binaries for the nVHE code, > which fails with LTO as the compiler produces LLVM bitcode > instead. Disable LTO for this code to allow objcopy to be used. We now partially link the nVHE code (generating machine code) before objcopy, so I think you should be able to drop this patch now. Tried building your branch without it, ran a couple of unit tests and all seems fine. David