From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D6F0C64E90 for ; Tue, 1 Dec 2020 14:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA12320757 for ; Tue, 1 Dec 2020 14:27:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="Gyy0HPN8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729417AbgLAO1z (ORCPT ); Tue, 1 Dec 2020 09:27:55 -0500 Received: from mail.skyhub.de ([5.9.137.197]:50392 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726402AbgLAO1z (ORCPT ); Tue, 1 Dec 2020 09:27:55 -0500 Received: from zn.tnic (p200300ec2f0e6a00797954e951a06088.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:6a00:7979:54e9:51a0:6088]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AF1341EC04D1; Tue, 1 Dec 2020 15:27:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1606832833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=jASWDk32Z/IY+a6hoVkThz3R94OZ3u3xXFaDDRkTrYA=; b=Gyy0HPN8jECjtuzlUA22ZxsV5AmeNWjr8UMM+adaeqLz05oD4BihgPa1XlOgFbrzh+Tm3/ SfKjbVKzlymFpJ78SqudF2NQRpGI9slZPLzsJzV23LUDpYymLBRgJD4MlDJiIQkoTsGI09 3POnmdUfVbIncIpm8JULF5pdXsAxnjw= Date: Tue, 1 Dec 2020 15:27:09 +0100 From: Borislav Petkov To: "Bae, Chang Seok" Cc: Thomas Gleixner , Ingo Molnar , Andy Lutomirski , "x86@kernel.org" , "Brown, Len" , "Hansen, Dave" , "hjl.tools@gmail.com" , "Dave.Martin@arm.com" , "mpe@ellerman.id.au" , "Luck, Tony" , "Shankar, Ravi V" , "libc-alpha@sourceware.org" , "linux-arch@vger.kernel.org" , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/4] x86/signal: Introduce helpers to get the maximum signal frame size Message-ID: <20201201142709.GB22927@zn.tnic> References: <20201119190237.626-1-chang.seok.bae@intel.com> <20201119190237.626-2-chang.seok.bae@intel.com> <20201125111630.GA10378@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, Nov 30, 2020 at 08:40:32PM +0000, Bae, Chang Seok wrote: > In general, putting #ifdef in a C file is advised to avoid. Well, in this case it is arguably better to have the ifdeffery there, where it is being used. > I wonder whether it is okay to include #ifdef in the C file in this > case. Yes, it's not like this will be the only place where you have #ifdef in a .c file: [ ~/kernel/linux> git grep "#ifdef" *.c | wc -l 29401 -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette