From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9406C7619A for ; Fri, 17 Mar 2023 15:30:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230092AbjCQPaH (ORCPT ); Fri, 17 Mar 2023 11:30:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbjCQPaG (ORCPT ); Fri, 17 Mar 2023 11:30:06 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 938BB9E04F; Fri, 17 Mar 2023 08:29:41 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1pdC1O-0004S1-00; Fri, 17 Mar 2023 16:29:34 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 203E8C1B05; Fri, 17 Mar 2023 16:29:20 +0100 (CET) Date: Fri, 17 Mar 2023 16:29:20 +0100 From: Thomas Bogendoerfer To: Matthew Wilcox Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v4 16/36] mips: Implement the new page table range API Message-ID: <20230317152920.GA11653@alpha.franken.de> References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-17-willy@infradead.org> <20230315105022.GA9850@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, Mar 15, 2023 at 08:33:21PM +0000, Matthew Wilcox wrote: > On Wed, Mar 15, 2023 at 11:50:22AM +0100, Thomas Bogendoerfer wrote: > > On Wed, Mar 15, 2023 at 05:14:24AM +0000, Matthew Wilcox (Oracle) wrote: > > > Rename _PFN_SHIFT to PFN_PTE_SHIFT. Convert a few places > > > to call set_pte() instead of set_pte_at(). Add set_ptes(), > > > update_mmu_cache_range(), flush_icache_pages() and flush_dcache_folio(). > > > > /local/tbogendoerfer/korg/linux/mm/memory.c: In function ‘set_pte_range’: > > /local/tbogendoerfer/korg/linux/mm/memory.c:4290:2: error: implicit declaration of function ‘update_mmu_cache_range’ [-Werror=implicit-function-declaration] > > update_mmu_cache_range(vma, addr, vmf->pte, nr); > > > > update_mmu_cache_range() is missing in this patch. > > Oops. And mips was one of the arches I did a test build for! > > Looks like we could try to gain some efficiency by passing 'nr' to > __update_tlb(), but as far as I can tell, that's only called for r3k and > r4k, so maybe it's not worth optimising at this point? hmm, not sure if that would help. R4k style TLB has two PTEs mapped per TLB entry. So by advancing per page __update_tlb() is called more often than needed. > Anyway, this add-on makes the mips build compile for me and I'll fold > it into v5. tested your v4 with the add-on on QEMU Malta and real hardware without problems so far. I'll give v5 another spin. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]