From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2DDC761AF for ; Mon, 27 Mar 2023 04:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229606AbjC0Erj (ORCPT ); Mon, 27 Mar 2023 00:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjC0Eri (ORCPT ); Mon, 27 Mar 2023 00:47:38 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BB2B34C3A; Sun, 26 Mar 2023 21:47:37 -0700 (PDT) Received: by linux.microsoft.com (Postfix, from userid 1127) id 2E9CB20FD0D3; Sun, 26 Mar 2023 21:47:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2E9CB20FD0D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1679892457; bh=NIilwokkVveAW1/qoyF+G5KzDatqErPlzzHGZDvChIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IA1L8cUT6IpC78sM9ct3eZR1fTaqg1TOJzmdnWntQD8qMPBc4sDsl878GyhoIYl9B 33HHNFeMOeVxYZj2zvAkVIzlxS0OICsDwNAy9QCuebMGg3Kycd4qVv4QvcUlrW5HFk lPdS2Tyq0pgprfQZDe7fMXftYVXOjiYLJQ+pvVKM= Date: Sun, 26 Mar 2023 21:47:37 -0700 From: Saurabh Singh Sengar To: "Michael Kelley (LINUX)" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , KY Srinivasan , Haiyang Zhang , "wei.liu@kernel.org" , Dexuan Cui , "arnd@arndb.de" , Tianyu Lan , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-arch@vger.kernel.org" Subject: Re: [PATCH v3 1/5] x86/init: Make get/set_rtc_noop() public Message-ID: <20230327044737.GA6852@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1679306618-31484-1-git-send-email-ssengar@linux.microsoft.com> <1679306618-31484-2-git-send-email-ssengar@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Sun, Mar 26, 2023 at 03:03:17PM +0000, Michael Kelley (LINUX) wrote: > From: Saurabh Sengar Sent: Monday, March 20, 2023 3:04 AM > > > > Make get/set_rtc_noop() to be public so that they can be used > > in other modules as well. > > > > Co-developed-by: Tianyu Lan > > Signed-off-by: Tianyu Lan > > Signed-off-by: Saurabh Sengar > > Reviewed-by: Wei Liu > > --- > > arch/x86/include/asm/x86_init.h | 2 ++ > > arch/x86/kernel/x86_init.c | 4 ++-- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h > > index c1c8c581759d..d8fb3a1639e9 100644 > > --- a/arch/x86/include/asm/x86_init.h > > +++ b/arch/x86/include/asm/x86_init.h > > @@ -326,5 +326,7 @@ extern void x86_init_uint_noop(unsigned int unused); > > extern bool bool_x86_init_noop(void); > > extern void x86_op_int_noop(int cpu); > > extern bool x86_pnpbios_disabled(void); > > +extern int set_rtc_noop(const struct timespec64 *now); > > +extern void get_rtc_noop(struct timespec64 *now); > > > > #endif > > diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c > > index ef80d361b463..d93aeffec19b 100644 > > --- a/arch/x86/kernel/x86_init.c > > +++ b/arch/x86/kernel/x86_init.c > > @@ -33,8 +33,8 @@ static int __init iommu_init_noop(void) { return 0; } > > static void iommu_shutdown_noop(void) { } > > bool __init bool_x86_init_noop(void) { return false; } > > void x86_op_int_noop(int cpu) { } > > -static __init int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } > > -static __init void get_rtc_noop(struct timespec64 *now) { } > > +int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } > > +void get_rtc_noop(struct timespec64 *now) { } > > > > static __initconst const struct of_device_id of_cmos_match[] = { > > { .compatible = "motorola,mc146818" }, > > -- > > 2.34.1 > > Reviewed-by: Michael Kelley Hi x86 maintainers, If there is no concern, can you please ack this patch. Regards, Saurabh