From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 279DCC433EF for ; Sat, 21 May 2022 09:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347243AbiEUJoH (ORCPT ); Sat, 21 May 2022 05:44:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346489AbiEUJoD (ORCPT ); Sat, 21 May 2022 05:44:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 898735C678 for ; Sat, 21 May 2022 02:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653126238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dQakkrlXQRKntd0RRpdtvvmaPsTow/BNKvunF/X2S4o=; b=Drs+euNcA9RhCcViZLBlKNLhg0oRcZm6yLx8wth9kUO2xZZZJVQ2s5D5NlFL5RbnCB8R9g Pc0bVmM2w93QDd3fFZv8DtuJOmtMphvCsoadbdh/IVxXBXZllX/vTa5wLo7asfZojP6nBY 0nibLRg9yXGS8y/mJSBSCNsAt6fv7VI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-LkL9ShD1MbmDYbK75-oCIw-1; Sat, 21 May 2022 05:43:51 -0400 X-MC-Unique: LkL9ShD1MbmDYbK75-oCIw-1 Received: by mail-wm1-f70.google.com with SMTP id e9-20020a05600c4e4900b00394779649b1so7466360wmq.3 for ; Sat, 21 May 2022 02:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dQakkrlXQRKntd0RRpdtvvmaPsTow/BNKvunF/X2S4o=; b=hcOGPHxD0LifzLeF2N0pAMhX9S2BSOw1zsPlgIDHONdfHl3s/h8KlI6oUHNvrJemaA d4Yxlp7QIt0fkHIZ9q0h5XaVV4CWBoJYpRDBlpIr/Ghzz4MZygNucI3+SOkOTJ9MyQlx mqgv9s1PtinVmiheUHW7DS6HxJQViWdbDcsrp2AWH9ZDyJNvywEn2t/FLhV9ui17qhcQ 1DRl8lsk9fZmimJviP9D0rLcMAo+vf6v7swaXxdQhF32zPna/QhkxY4608cgpnb3bx7L svLCY4+XgSZaLHHObNiZafNCjH28flbwuWSgcgw92763pXzfv/YQq5lo+xCVlL+Vb104 HYxA== X-Gm-Message-State: AOAM533301IVrQ6wTm6xv/ADHtPN/JS7cQe9ySP4/cEk1fN128GAZuE4 Knuj0qmTnlf3dZo3JafDFC9V2V763XMfVeTQq1klWFAcbQf0pYKjgRA47COwNeH8OucXNgPTYfG RyC2/5nCO8BpnY8GhOFJivw== X-Received: by 2002:a05:6000:144e:b0:20e:6719:c376 with SMTP id v14-20020a056000144e00b0020e6719c376mr11371530wrx.715.1653126230201; Sat, 21 May 2022 02:43:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNY4l0J3NU0fU5ldjpTVsJKjUF0HOYrRkkJ7veXmwkg/db0qArtoiGUueey/Ksa0YlGIw9oQ== X-Received: by 2002:a05:6000:144e:b0:20e:6719:c376 with SMTP id v14-20020a056000144e00b0020e6719c376mr11371508wrx.715.1653126229992; Sat, 21 May 2022 02:43:49 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id d21-20020adf9b95000000b0020d06e7c16fsm4529325wrc.84.2022.05.21.02.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 02:43:49 -0700 (PDT) Message-ID: <20bde9a2-592d-30a8-8cdc-03bdf1bf3e93@redhat.com> Date: Sat, 21 May 2022 11:43:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V11 09/22] LoongArch: Add boot and setup routines Content-Language: en-US To: Huacai Chen Cc: Ard Biesheuvel , Huacai Chen , Arnd Bergmann , Andy Lutomirski , Thomas Gleixner , Peter Zijlstra , Andrew Morton , David Airlie , Jonathan Corbet , Linus Torvalds , linux-arch , Linux Doc Mailing List , Linux Kernel Mailing List , Xuefeng Li , Yanteng Si , Guo Ren , Xuerui Wang , Jiaxun Yang , Stephen Rothwell , linux-efi References: <20220518092619.1269111-1-chenhuacai@loongson.cn> <20220518092619.1269111-10-chenhuacai@loongson.cn> <0bae0df1-48ae-d02f-bce4-d1f69acf269e@redhat.com> <256e0b82-5d0f-cf40-87c6-c2505d2a6d3b@redhat.com> <859d5489-9361-3db0-1da4-1417ed2fad6c@redhat.com> <7caec251-20e7-4a8c-93ee-b28558ec580f@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org Hello Huacai, On 5/21/22 11:13, Huacai Chen wrote: > Hi, Javier, > > On Sat, May 21, 2022 at 5:06 PM Javier Martinez Canillas > wrote: >> >> Hello Huacai, >> >> On 5/21/22 09:37, Huacai Chen wrote: >> >> [snip] >> >>>> >>>> A problem with moving to subsys_initcall_sync() is that this will delay >>>> more when a display is available in the system, and just to cope up with >>>> a corner case (as mentioned the common case is native drivers as module). >>> OK, your method seems better, but I think moving to >>> subsys_initcall_sync() can make the screen display as early as >>> possible. >>> >> >> But it doesn't cover all cases. For example, you will get the same error >> if for example your native driver is built-in and efifb built as module. >> >> So my opinion is that instead of playing with the init call levels, is >> just better for you to build your native driver as a module instead of >> making it built-in. > I mean moving to subsys_initcall_sync() on top of your patchset, not > replacing them (Just for display earlier). > Ah, I see what you mean. Yes, that makes sense indeed. Feel free to post a patch proposing that. If you do, please also include Thomas Zimmermann to the Cc list. Thanks! -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat