linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: linux-parisc@vger.kernel.org,
	"James E . J . Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	y2038 Mailman List <y2038@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Deepa Dinamani <deepa.kernel@gmail.com>,
	Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
	linux-parisc-owner@vger.kernel.org
Subject: Re: [PATCH v4 3/6] parisc: add system call table generation support
Date: Mon, 15 Oct 2018 07:16:59 +0200	[thread overview]
Message-ID: <4517632.a0TFakfgol@daneel.sf-tec.de> (raw)
In-Reply-To: <CALxhOngwHfFzCGXknF4_CHjD=4LeM8BnrZ+s-p6ZRcJ3G8i_RA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

Firoz Khan wrote:
> Hi Rolf,
> 
> On Fri, 12 Oct 2018 at 17:37, Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
> > Firoz Khan wrote:

> > > +prefix="$4"
> > > +offset="$5"
> > > +
> > > +fileguard=_UAPI_ASM_PARISC_`basename "$out" | sed \
> > > +    -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/' \
> > > +    -e 's/[^A-Z0-9_]/_/g' -e 's/__/_/g'`
> > > +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> > > +    echo "#ifndef ${fileguard}"
> > > +    echo "#define ${fileguard}"
> > > +    echo ""
> > > +
> > > +    nxt=0
> > > +    while read nr abi name entry compat ; do
> > > +     if [ -z "$offset" ]; then
> > > +         echo -e "#define __NR_${prefix}${name}\t$nr"
> > 
> > This mixed indentation with both tabs and spaces is a bit messy.
> 
> Is this what you suggested?
> -           echo -e "#define __NR_${prefix}${name}\t$nr"
> +           echo "#define __NR_${prefix}${name} $nr"

No, this was actually only about the script itself. Looks like your editor has 
tab-width 8 and indentation 4 or so.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  parent reply	other threads:[~2018-10-15  5:16 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12  9:43 [PATCH v4 0/6] parisc: system call table generation support Firoz Khan
2018-10-12  9:43 ` Firoz Khan
2018-10-12  9:43 ` [PATCH v4 1/6] parisc: move __IGNORE* entries to non uapi header Firoz Khan
2018-10-12  9:43   ` Firoz Khan
2018-10-12  9:43 ` [PATCH v4 2/6] parisc: add __NR_Linux_syscalls along with __NR_syscalls Firoz Khan
2018-10-12  9:43   ` Firoz Khan
2018-10-12  9:43 ` [PATCH v4 3/6] parisc: add system call table generation support Firoz Khan
2018-10-12  9:43   ` Firoz Khan
2018-10-12 10:18   ` Firoz Khan
2018-10-12 10:18     ` Firoz Khan
2018-10-12 11:51   ` Arnd Bergmann
2018-10-12 11:51     ` Arnd Bergmann
2018-10-13 15:34     ` Firoz Khan
2018-10-13 15:34       ` Firoz Khan
2018-10-12 12:07   ` Rolf Eike Beer
2018-10-12 12:07     ` Rolf Eike Beer
2018-10-12 13:57     ` Firoz Khan
2018-10-12 13:57       ` Firoz Khan
2018-10-12 14:03       ` Rolf Eike Beer
2018-10-12 14:03         ` Rolf Eike Beer
2018-10-15  4:48     ` Firoz Khan
2018-10-15  4:48       ` Firoz Khan
2018-10-15  5:16       ` Rolf Eike Beer [this message]
2018-10-15  5:16         ` Rolf Eike Beer
2018-10-15  5:45         ` Firoz Khan
2018-10-15  5:45           ` Firoz Khan
2018-10-14  1:06   ` Eugene Syromiatnikov
2018-10-14  1:06     ` Eugene Syromiatnikov
2018-10-15  5:12     ` Firoz Khan
2018-10-15  5:12       ` Firoz Khan
2018-10-12  9:44 ` [PATCH v4 4/6] parisc: uapi header and system call table file generation Firoz Khan
2018-10-12  9:44   ` Firoz Khan
2018-10-12  9:44 ` [PATCH v4 5/6] parisc: wire up rseq system call Firoz Khan
2018-10-12  9:44   ` Firoz Khan
2018-10-12  9:56   ` Arnd Bergmann
2018-10-12  9:56     ` Arnd Bergmann
2018-10-12 10:16     ` Firoz Khan
2018-10-12 10:16       ` Firoz Khan
2018-10-12 11:52       ` Arnd Bergmann
2018-10-12 11:52         ` Arnd Bergmann
2018-10-12 20:23         ` Helge Deller
2018-10-12 20:23           ` Helge Deller
2018-10-13  5:42           ` Firoz Khan
2018-10-13  5:42             ` Firoz Khan
2018-10-12  9:44 ` [PATCH v4 6/6] parisc: syscalls: Ignore nfsservctl for other architectures Firoz Khan
2018-10-12  9:44   ` Firoz Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4517632.a0TFakfgol@daneel.sf-tec.de \
    --to=eike-kernel@sf-tec.de \
    --cc=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=deller@gmx.de \
    --cc=firoz.khan@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jejb@parisc-linux.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc-owner@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).