From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 13/13] memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones Date: Thu, 14 Jul 2011 13:23:28 -0700 Message-ID: <4E1F5040.50004@zytor.com> References: <1310462166-31469-1-git-send-email-tj@kernel.org> <1310462166-31469-14-git-send-email-tj@kernel.org> <4E1F4D2C.3000507@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:55227 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753722Ab1GNUXr (ORCPT ); Thu, 14 Jul 2011 16:23:47 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Tejun Heo Cc: mingo@redhat.com, tglx@linutronix.de, benh@kernel.crashing.org, yinghai@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org On 07/14/2011 01:20 PM, Tejun Heo wrote: > > Hmm... looking at the boot log, not really. [ ) ranges are more > common. memblock code is one of notable exceptions and I actually was > thinking about converting it. [ ) ranges are easier to recognize and > most of code we have can't deal with the full range (and it shouldn't > need to - chopping off one top and bottom is much saner approach > anyway). > Sorry I don't follow. We display resources as [...] ranges, and in particular when there are those kinds of brackets they tend to be inclusive ranges. For the internal representation, of course, [ ) ranges or (base, length) are the only sensible options. -hpa