From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 13/13] memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones Date: Thu, 14 Jul 2011 13:38:49 -0700 Message-ID: <4E1F53D9.2000606@zytor.com> References: <1310462166-31469-1-git-send-email-tj@kernel.org> <1310462166-31469-14-git-send-email-tj@kernel.org> <4E1F4D2C.3000507@zytor.com> <4E1F5040.50004@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Tejun Heo Cc: mingo@redhat.com, tglx@linutronix.de, benh@kernel.crashing.org, yinghai@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org List-Id: linux-arch.vger.kernel.org On 07/14/2011 01:32 PM, Tejun Heo wrote: > Hello, > > On Thu, Jul 14, 2011 at 10:23 PM, H. Peter Anvin wrote: >> On 07/14/2011 01:20 PM, Tejun Heo wrote: >> Sorry I don't follow. We display resources as [...] ranges, and in >> particular when there are those kinds of brackets they tend to be >> inclusive ranges. >> >> For the internal representation, of course, [ ) ranges or (base, length) >> are the only sensible options. > > [ ) ranges: e820, init_memory_mapping, NUMA nodes, Zone PFN ranges, PM > nosave memory > > [ ] ranges: MTRR, NODE_DATA, early_node_map, [mm]io ranges > > Hmm... I was only looking at the early boot messages which didn't > include the io ranges. It ultimately is a cosmetic issue so my > opinions aren't very strong but I think we can leave [mm]io ranges > alone and converge the rest into [ ) ranges sans the brackets? > Agreed it's a cosmetic issue... this discussion has already been had, though, and the consensus is to move the kernel to the standardized resource format. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.10]:37742 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932225Ab1GNUjA (ORCPT ); Thu, 14 Jul 2011 16:39:00 -0400 Message-ID: <4E1F53D9.2000606@zytor.com> Date: Thu, 14 Jul 2011 13:38:49 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH 13/13] memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones References: <1310462166-31469-1-git-send-email-tj@kernel.org> <1310462166-31469-14-git-send-email-tj@kernel.org> <4E1F4D2C.3000507@zytor.com> <4E1F5040.50004@zytor.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Tejun Heo Cc: mingo@redhat.com, tglx@linutronix.de, benh@kernel.crashing.org, yinghai@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org Message-ID: <20110714203849.8dvDSTSIra-3dvreE2CRF48neFUbM4kiwrcCmTRZYGc@z> On 07/14/2011 01:32 PM, Tejun Heo wrote: > Hello, > > On Thu, Jul 14, 2011 at 10:23 PM, H. Peter Anvin wrote: >> On 07/14/2011 01:20 PM, Tejun Heo wrote: >> Sorry I don't follow. We display resources as [...] ranges, and in >> particular when there are those kinds of brackets they tend to be >> inclusive ranges. >> >> For the internal representation, of course, [ ) ranges or (base, length) >> are the only sensible options. > > [ ) ranges: e820, init_memory_mapping, NUMA nodes, Zone PFN ranges, PM > nosave memory > > [ ] ranges: MTRR, NODE_DATA, early_node_map, [mm]io ranges > > Hmm... I was only looking at the early boot messages which didn't > include the io ranges. It ultimately is a cosmetic issue so my > opinions aren't very strong but I think we can leave [mm]io ranges > alone and converge the rest into [ ) ranges sans the brackets? > Agreed it's a cosmetic issue... this discussion has already been had, though, and the consensus is to move the kernel to the standardized resource format. -hpa