From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlastimil Babka Subject: Re: [PATCH 03/18] mm: make vm_munmap killable Date: Fri, 11 Mar 2016 11:06:41 +0100 Message-ID: <56E298B1.6010802@suse.cz> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-4-git-send-email-mhocko@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456752417-9626-4-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org To: Michal Hocko , LKML Cc: Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr List-Id: linux-arch.vger.kernel.org On 02/29/2016 02:26 PM, Michal Hocko wrote: > From: Michal Hocko > > Almost all current users of vm_munmap are ignoring the return value > and so they do not handle potential error. This means that some VMAs 1 7834 arch/x86/kvm/x86.c <<__x86_set_memory_region>> r = vm_munmap(old.userspace_addr, old.npages * PAGE_SIZE); WARN_ON(r < 0); This warning will potentially add noise to OOM output? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:60280 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbcCKKGq (ORCPT ); Fri, 11 Mar 2016 05:06:46 -0500 Subject: Re: [PATCH 03/18] mm: make vm_munmap killable References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-4-git-send-email-mhocko@kernel.org> From: Vlastimil Babka Message-ID: <56E298B1.6010802@suse.cz> Date: Fri, 11 Mar 2016 11:06:41 +0100 MIME-Version: 1.0 In-Reply-To: <1456752417-9626-4-git-send-email-mhocko@kernel.org> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michal Hocko , LKML Cc: Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr Cermak , Thomas Gleixner , Michal Hocko , Alexander Viro Message-ID: <20160311100641.cx2HjOrq1hCMALYXMlyJtR81yWwfSrMUuKSunlzBG50@z> On 02/29/2016 02:26 PM, Michal Hocko wrote: > From: Michal Hocko > > Almost all current users of vm_munmap are ignoring the return value > and so they do not handle potential error. This means that some VMAs 1 7834 arch/x86/kvm/x86.c <<__x86_set_memory_region>> r = vm_munmap(old.userspace_addr, old.npages * PAGE_SIZE); WARN_ON(r < 0); This warning will potentially add noise to OOM output?