From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Kristina Martsenko <kristina.martsenko@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: Adam Wallis <awallis@codeaurora.org>,
Amit Kachhap <Amit.Kachhap@arm.com>,
Andrew Jones <drjones@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Christoffer Dall <christoffer.dall@arm.com>,
Dave P Martin <Dave.Martin@arm.com>,
Jacob Bramley <jacob.bramley@arm.com>,
Kees Cook <keescook@chromium.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Will Deacon <will.deacon@arm.com>,
kvmarm@lists.cs.columbia.edu, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 07/17] arm64: add basic pointer authentication support
Date: Thu, 11 Oct 2018 17:00:04 +0100 [thread overview]
Message-ID: <56fbbada-902d-f802-0448-4692a56c7e72@arm.com> (raw)
In-Reply-To: <20181005084754.20950-8-kristina.martsenko@arm.com>
Hi Kristina,
On 05/10/18 09:47, Kristina Martsenko wrote:
> From: Mark Rutland <mark.rutland@arm.com>
>
> This patch adds basic support for pointer authentication, allowing
> userspace to make use of APIAKey. The kernel maintains an APIAKey value
> for each process (shared by all threads within), which is initialised to
> a random value at exec() time.
>
> To describe that address authentication instructions are available, the
> ID_AA64ISAR0.{APA,API} fields are exposed to userspace. A new hwcap,
> APIA, is added to describe that the kernel manages APIAKey.
>
> Instructions using other keys (APIBKey, APDAKey, APDBKey) are disabled,
> and will behave as NOPs. These may be made use of in future patches.
>
> No support is added for the generic key (APGAKey), though this cannot be
> trapped or made to behave as a NOP. Its presence is not advertised with
> a hwcap.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> [kristina: init keys in arch_bprm_mm_init; add AA64ISAR1.API HWCAP_CAP; use sysreg_clear_set]
> Signed-off-by: Kristina Martsenko <kristina.martsenko@arm.com>
> Tested-by: Adam Wallis <awallis@codeaurora.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index 0dd171c7d71e..3157685aa56a 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -1040,6 +1040,11 @@ static void cpu_has_fwb(const struct arm64_cpu_capabilities *__unused)
> }
>
> #ifdef CONFIG_ARM64_PTR_AUTH
> +static void cpu_enable_address_auth(struct arm64_cpu_capabilities const *cap)
> +{
> + sysreg_clear_set(sctlr_el1, 0, SCTLR_ELx_ENIA);
> +}
> +
> static bool has_address_auth(const struct arm64_cpu_capabilities *entry,
> int __unused)
> {
> @@ -1267,6 +1272,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
> .capability = ARM64_HAS_ADDRESS_AUTH,
> .type = ARM64_CPUCAP_SYSTEM_FEATURE,
> .matches = has_address_auth,
> + .cpu_enable = cpu_enable_address_auth,
> },
> #endif /* CONFIG_ARM64_PTR_AUTH */
> {},
> @@ -1314,6 +1320,10 @@ static const struct arm64_cpu_capabilities arm64_elf_hwcaps[] = {
> #ifdef CONFIG_ARM64_SVE
> HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_SVE_SHIFT, FTR_UNSIGNED, ID_AA64PFR0_SVE, CAP_HWCAP, HWCAP_SVE),
> #endif
> +#ifdef CONFIG_ARM64_PTR_AUTH
> + HWCAP_CAP(SYS_ID_AA64ISAR1_EL1, ID_AA64ISAR1_APA_SHIFT, FTR_UNSIGNED, 1, CAP_HWCAP, HWCAP_APIA),
> + HWCAP_CAP(SYS_ID_AA64ISAR1_EL1, ID_AA64ISAR1_API_SHIFT, FTR_UNSIGNED, 1, CAP_HWCAP, HWCAP_APIA),
This is a bit problematic. If all the CPUs have just the IMPDEF
algorithm available, we could fail to match the first entry (APA) for a
late secondary CPU and thus thus fail the CPU from booting. I guess we
need a custom entry which reuses the has_address_auth() as the matches().
Rest looks fine to me.
Suzuki
next prev parent reply other threads:[~2018-10-11 16:00 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 8:47 [PATCH 00/17] ARMv8.3 pointer authentication support Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 01/17] arm64: add pointer authentication register bits Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-11 16:28 ` Will Deacon
2018-10-11 16:28 ` Will Deacon
2018-10-12 8:53 ` Mark Rutland
2018-10-12 8:53 ` Mark Rutland
2018-10-12 8:56 ` Will Deacon
2018-10-12 8:56 ` Will Deacon
2018-10-12 9:50 ` Mark Rutland
2018-10-12 9:50 ` Mark Rutland
2018-10-05 8:47 ` [PATCH v5 02/17] arm64/kvm: consistently handle host HCR_EL2 flags Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 03/17] arm64/kvm: hide ptrauth from guests Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 04/17] arm64: Don't trap host pointer auth use to EL2 Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 05/17] arm64/cpufeature: detect pointer authentication Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 06/17] asm-generic: mm_hooks: allow hooks to be overridden individually Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 07/17] arm64: add basic pointer authentication support Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-11 16:00 ` Suzuki K Poulose [this message]
2018-10-11 16:00 ` Suzuki K Poulose
2018-10-19 11:15 ` Catalin Marinas
2018-10-19 11:15 ` Catalin Marinas
2018-10-19 11:24 ` Will Deacon
2018-10-19 11:24 ` Will Deacon
2018-10-19 15:36 ` Kees Cook
2018-10-19 15:36 ` Kees Cook
2018-10-19 15:49 ` Will Deacon
2018-10-19 15:49 ` Will Deacon
2018-10-19 16:05 ` Kees Cook
2018-10-19 16:05 ` Kees Cook
2018-10-19 16:16 ` Will Deacon
2018-10-19 16:16 ` Will Deacon
2018-10-19 15:54 ` Mark Rutland
2018-10-19 15:54 ` Mark Rutland
2018-10-19 16:49 ` Cyrill Gorcunov
2018-10-19 16:49 ` Cyrill Gorcunov
2018-11-14 18:11 ` Will Deacon
2018-11-14 18:11 ` Will Deacon
2018-11-15 10:25 ` Dave Martin
2018-11-15 10:25 ` Dave Martin
2018-10-23 8:36 ` Ramana Radhakrishnan
2018-10-23 8:36 ` Ramana Radhakrishnan
2018-10-23 10:20 ` Will Deacon
2018-10-23 10:20 ` Will Deacon
2018-10-05 8:47 ` [PATCH v5 08/17] arm64: expose user PAC bit positions via ptrace Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 09/17] arm64: perf: strip PAC when unwinding userspace Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 10/17] arm64: enable pointer authentication Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [PATCH v5 11/17] arm64: docs: document " Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 9:04 ` Ramana Radhakrishnan
2018-10-05 9:04 ` Ramana Radhakrishnan
2018-10-16 16:14 ` Kristina Martsenko
2018-10-16 16:14 ` Kristina Martsenko
2018-10-19 11:35 ` Catalin Marinas
2018-10-19 11:35 ` Catalin Marinas
2018-10-19 11:47 ` Marc Zyngier
2018-10-19 11:47 ` Marc Zyngier
2018-10-19 12:22 ` Will Deacon
2018-10-19 12:22 ` Will Deacon
2018-10-19 14:42 ` Kristina Martsenko
2018-10-19 14:42 ` Kristina Martsenko
2018-10-19 15:10 ` Catalin Marinas
2018-10-19 15:10 ` Catalin Marinas
2018-10-19 17:45 ` Will Deacon
2018-10-19 17:45 ` Will Deacon
2018-11-02 6:02 ` Jon Masters
2018-11-02 6:02 ` Jon Masters
2018-10-24 10:56 ` Ramana Radhakrishnan
2018-10-24 10:56 ` Ramana Radhakrishnan
2018-10-15 22:35 ` Kees Cook
2018-10-15 22:35 ` Kees Cook
2018-11-02 9:46 ` Ramana Radhakrishnan
2018-11-02 9:46 ` Ramana Radhakrishnan
2018-10-05 8:47 ` [RFC 12/17] arm64: move ptrauth keys to thread_info Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-19 11:38 ` Catalin Marinas
2018-10-19 11:38 ` Catalin Marinas
2018-10-05 8:47 ` [RFC 13/17] arm64: install user ptrauth keys at kernel exit time Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [RFC 14/17] arm64: unwind: strip PAC from kernel addresses Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 8:47 ` [RFC 15/17] arm64: enable ptrauth earlier Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-06 12:51 ` Amit Kachhap
2018-10-06 12:51 ` Amit Kachhap
2018-10-05 8:47 ` [RFC 16/17] arm64: initialize and switch ptrauth kernel keys Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-06 12:56 ` Amit Kachhap
2018-10-06 12:56 ` Amit Kachhap
2018-10-05 8:47 ` [RFC 17/17] arm64: compile the kernel with ptrauth -msign-return-address Kristina Martsenko
2018-10-05 8:47 ` Kristina Martsenko
2018-10-05 9:01 ` Ramana Radhakrishnan
2018-10-05 9:01 ` Ramana Radhakrishnan
2018-10-11 14:00 ` Kristina Martsenko
2018-10-11 14:00 ` Kristina Martsenko
2018-10-11 14:23 ` Vladimir Murzin
2018-10-11 14:23 ` Vladimir Murzin
2018-10-15 22:38 ` Kees Cook
2018-10-15 22:38 ` Kees Cook
2018-10-15 22:42 ` [PATCH 00/17] ARMv8.3 pointer authentication support Kees Cook
2018-10-15 22:42 ` Kees Cook
2018-11-13 16:17 ` Kristina Martsenko
2018-11-13 16:17 ` Kristina Martsenko
2018-11-13 23:09 ` Kees Cook
2018-11-13 23:09 ` Kees Cook
2018-11-14 15:54 ` Kristina Martsenko
2018-11-14 15:54 ` Kristina Martsenko
2018-11-14 21:47 ` Mark Rutland
2018-11-14 21:47 ` Mark Rutland
2018-11-14 22:48 ` Kees Cook
2018-11-14 22:48 ` Kees Cook
2018-10-19 12:36 ` Will Deacon
2018-10-19 12:36 ` Will Deacon
2018-10-23 8:39 ` Ramana Radhakrishnan
2018-10-23 8:39 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56fbbada-902d-f802-0448-4692a56c7e72@arm.com \
--to=suzuki.poulose@arm.com \
--cc=Amit.Kachhap@arm.com \
--cc=Dave.Martin@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=awallis@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=drjones@redhat.com \
--cc=jacob.bramley@arm.com \
--cc=keescook@chromium.org \
--cc=kristina.martsenko@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).