From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [RESEND PATCH v3 3/3] sh: add the sh_ prefix to early platform symbols Date: Tue, 23 Oct 2018 12:10:46 +0100 Message-ID: <8636swude1.wl-marc.zyngier@arm.com> References: <20180827090651.25062-1-brgl@bgdev.pl> <20180827090651.25062-4-brgl@bgdev.pl> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180827090651.25062-4-brgl@bgdev.pl> Sender: linux-kernel-owner@vger.kernel.org To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , David Lechner , Michael Turquette , Stephen Boyd , Arnd Bergmann , Greg Kroah-Hartman , Mark Rutland , Yoshinori Sato , Rich Felker , Andy Shevchenko , "Rafael J . Wysocki" , Peter Rosin , Jiri Slaby , Thomas Gleixner , Daniel Lezcano , Geert Uytterhoeven , Magnus Damm , Johan Hovold , Rob Herring List-Id: linux-arch.vger.kernel.org Hi Bartosz, On Mon, 27 Aug 2018 10:06:51 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Old early platform device support is now sh-specific. Before moving on > to implementing new early platform framework based on real platform > devices, prefix all early platform symbols with 'sh_'. > > Signed-off-by: Bartosz Golaszewski > --- > arch/sh/drivers/platform_early.c | 66 +++++++++++++------------- > arch/sh/include/asm/platform_early.h | 30 ++++++------ > arch/sh/kernel/cpu/sh2/setup-sh7619.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-mxg.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7201.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7203.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7206.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7264.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7269.c | 2 +- > arch/sh/kernel/cpu/sh3/setup-sh7705.c | 2 +- > arch/sh/kernel/cpu/sh3/setup-sh770x.c | 2 +- > arch/sh/kernel/cpu/sh3/setup-sh7710.c | 2 +- > arch/sh/kernel/cpu/sh3/setup-sh7720.c | 2 +- > arch/sh/kernel/cpu/sh4/setup-sh4-202.c | 2 +- > arch/sh/kernel/cpu/sh4/setup-sh7750.c | 8 ++-- > arch/sh/kernel/cpu/sh4/setup-sh7760.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7343.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7366.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7722.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7723.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7724.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7734.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7757.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7763.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7770.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7780.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7785.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7786.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-shx3.c | 2 +- > arch/sh/kernel/cpu/sh5/setup-sh5.c | 2 +- > arch/sh/kernel/setup.c | 2 +- > arch/sh/kernel/time.c | 4 +- > drivers/clocksource/sh_cmt.c | 6 +-- > drivers/clocksource/sh_mtu2.c | 6 +-- > drivers/clocksource/sh_tmu.c | 6 +-- > drivers/tty/serial/sh-sci.c | 4 +- > include/linux/platform_device.h | 2 +- > 37 files changed, 94 insertions(+), 94 deletions(-) > > diff --git a/arch/sh/drivers/platform_early.c b/arch/sh/drivers/platform_early.c > index 3dfe9f3541bb..f6d148451dfc 100644 > --- a/arch/sh/drivers/platform_early.c > +++ b/arch/sh/drivers/platform_early.c > @@ -4,8 +4,8 @@ > #include > #include > > -static __initdata LIST_HEAD(early_platform_driver_list); > -static __initdata LIST_HEAD(early_platform_device_list); > +static __initdata LIST_HEAD(sh_early_platform_driver_list); > +static __initdata LIST_HEAD(sh_early_platform_device_list); As discussed offline at ELC, I don't think this patch is useful at this stage, and in the context of this particular series. I believe it should be dropped and only the first two patches should be merged. If the SH maintainer is not responsive, then maybe Greg could take them as they remove cruft from core code. As for the whole "early device" debate, my take is that we'd be much better off making the device model available early, rather than trying to architect something that is simply papering over the issue. Thanks, M. -- Jazz is not dead, it just smell funny. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:57304 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbeJWTeG (ORCPT ); Tue, 23 Oct 2018 15:34:06 -0400 Date: Tue, 23 Oct 2018 12:10:46 +0100 Message-ID: <8636swude1.wl-marc.zyngier@arm.com> From: Marc Zyngier Subject: Re: [RESEND PATCH v3 3/3] sh: add the sh_ prefix to early platform symbols In-Reply-To: <20180827090651.25062-4-brgl@bgdev.pl> References: <20180827090651.25062-1-brgl@bgdev.pl> <20180827090651.25062-4-brgl@bgdev.pl> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-arch-owner@vger.kernel.org List-ID: To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , David Lechner , Michael Turquette , Stephen Boyd , Arnd Bergmann , Greg Kroah-Hartman , Mark Rutland , Yoshinori Sato , Rich Felker , Andy Shevchenko , "Rafael J . Wysocki" , Peter Rosin , Jiri Slaby , Thomas Gleixner , Daniel Lezcano , Geert Uytterhoeven , Magnus Damm , Johan Hovold , Rob Herring , Frank Rowand , Philippe Ombredanne , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, Bartosz Golaszewski Message-ID: <20181023111046.VAr2M2-5ld2I0O6RM1mZ_SwlZD1u4DWlK7pQSwGLQ68@z> Hi Bartosz, On Mon, 27 Aug 2018 10:06:51 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Old early platform device support is now sh-specific. Before moving on > to implementing new early platform framework based on real platform > devices, prefix all early platform symbols with 'sh_'. > > Signed-off-by: Bartosz Golaszewski > --- > arch/sh/drivers/platform_early.c | 66 +++++++++++++------------- > arch/sh/include/asm/platform_early.h | 30 ++++++------ > arch/sh/kernel/cpu/sh2/setup-sh7619.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-mxg.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7201.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7203.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7206.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7264.c | 2 +- > arch/sh/kernel/cpu/sh2a/setup-sh7269.c | 2 +- > arch/sh/kernel/cpu/sh3/setup-sh7705.c | 2 +- > arch/sh/kernel/cpu/sh3/setup-sh770x.c | 2 +- > arch/sh/kernel/cpu/sh3/setup-sh7710.c | 2 +- > arch/sh/kernel/cpu/sh3/setup-sh7720.c | 2 +- > arch/sh/kernel/cpu/sh4/setup-sh4-202.c | 2 +- > arch/sh/kernel/cpu/sh4/setup-sh7750.c | 8 ++-- > arch/sh/kernel/cpu/sh4/setup-sh7760.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7343.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7366.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7722.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7723.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7724.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7734.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7757.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7763.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7770.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7780.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7785.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-sh7786.c | 2 +- > arch/sh/kernel/cpu/sh4a/setup-shx3.c | 2 +- > arch/sh/kernel/cpu/sh5/setup-sh5.c | 2 +- > arch/sh/kernel/setup.c | 2 +- > arch/sh/kernel/time.c | 4 +- > drivers/clocksource/sh_cmt.c | 6 +-- > drivers/clocksource/sh_mtu2.c | 6 +-- > drivers/clocksource/sh_tmu.c | 6 +-- > drivers/tty/serial/sh-sci.c | 4 +- > include/linux/platform_device.h | 2 +- > 37 files changed, 94 insertions(+), 94 deletions(-) > > diff --git a/arch/sh/drivers/platform_early.c b/arch/sh/drivers/platform_early.c > index 3dfe9f3541bb..f6d148451dfc 100644 > --- a/arch/sh/drivers/platform_early.c > +++ b/arch/sh/drivers/platform_early.c > @@ -4,8 +4,8 @@ > #include > #include > > -static __initdata LIST_HEAD(early_platform_driver_list); > -static __initdata LIST_HEAD(early_platform_device_list); > +static __initdata LIST_HEAD(sh_early_platform_driver_list); > +static __initdata LIST_HEAD(sh_early_platform_device_list); As discussed offline at ELC, I don't think this patch is useful at this stage, and in the context of this particular series. I believe it should be dropped and only the first two patches should be merged. If the SH maintainer is not responsive, then maybe Greg could take them as they remove cruft from core code. As for the whole "early device" debate, my take is that we'd be much better off making the device model available early, rather than trying to architect something that is simply papering over the issue. Thanks, M. -- Jazz is not dead, it just smell funny.