From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B485C433DB for ; Tue, 16 Mar 2021 21:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A6C764F91 for ; Tue, 16 Mar 2021 21:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbhCPVbO (ORCPT ); Tue, 16 Mar 2021 17:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhCPVbK (ORCPT ); Tue, 16 Mar 2021 17:31:10 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 754E5C06174A for ; Tue, 16 Mar 2021 14:31:10 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lMHHM-00H5x6-6x; Tue, 16 Mar 2021 22:31:04 +0100 Message-ID: <87933c0d6c07745b20f6724721e3bf2da8f67f72.camel@sipsolutions.net> Subject: Re: [RFC v8 08/20] um: lkl: memory handling From: Johannes Berg To: Hajime Tazaki Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com Date: Tue, 16 Mar 2021 22:31:03 +0100 In-Reply-To: (sfid-20210316_021825_898828_61B64BB2) References: <19d4990f2ef77ad595248183071da5e43149931c.1611103406.git.thehajime@gmail.com> <03c74a353c87994b61450ba8086f1ccda40b2ea8.camel@sipsolutions.net> (sfid-20210316_021825_898828_61B64BB2) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Tue, 2021-03-16 at 10:18 +0900, Hajime Tazaki wrote: > > > > +void *uml_kmalloc(int size, int flags) > > > +{ > > > + return kmalloc(size, flags); > > > +} > > > > That could probably still be shared? > > This function is a stub of arch/um/kernel/mem.c, which LKL doesn't > use for the build. Thus we defined here. > > Or are you suggesting to not stubbing this function, but extracting > the function from mem.c ? Yes, that's kind of what I was thinking. OTOH, I guess it's in os-Linux today? johannes