From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Johansen Subject: Re: [PATCH security-next v3 01/29] LSM: Correctly announce start of LSM initialization Date: Mon, 1 Oct 2018 14:05:32 -0700 Message-ID: <9c0f5719-1028-bb8b-972e-dd38f4358f84@canonical.com> References: <20180925001832.18322-1-keescook@chromium.org> <20180925001832.18322-2-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180925001832.18322-2-keescook@chromium.org> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook , James Morris Cc: Casey Schaufler , Tetsuo Handa , Paul Moore , Stephen Smalley , "Schaufler, Casey" , LSM , Jonathan Corbet , linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org On 09/24/2018 05:18 PM, Kees Cook wrote: > For a while now, the LSM core has said it was "initializED", rather than > "initializING". This adjust the report to be more accurate (i.e. before > this was reported before any LSMs had been initialized.) > > Signed-off-by: Kees Cook > Reviewed-by: Casey Schaufler Reviewed-by: John Johansen > --- > security/security.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/security/security.c b/security/security.c > index 736e78da1ab9..4cbcf244a965 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -72,10 +72,11 @@ int __init security_init(void) > int i; > struct hlist_head *list = (struct hlist_head *) &security_hook_heads; > > + pr_info("Security Framework initializing\n"); > + > for (i = 0; i < sizeof(security_hook_heads) / sizeof(struct hlist_head); > i++) > INIT_HLIST_HEAD(&list[i]); > - pr_info("Security Framework initialized\n"); > > /* > * Load minor LSMs, with the capability module always first. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:50948 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbeJBDpX (ORCPT ); Mon, 1 Oct 2018 23:45:23 -0400 Subject: Re: [PATCH security-next v3 01/29] LSM: Correctly announce start of LSM initialization References: <20180925001832.18322-1-keescook@chromium.org> <20180925001832.18322-2-keescook@chromium.org> From: John Johansen Message-ID: <9c0f5719-1028-bb8b-972e-dd38f4358f84@canonical.com> Date: Mon, 1 Oct 2018 14:05:32 -0700 MIME-Version: 1.0 In-Reply-To: <20180925001832.18322-2-keescook@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook , James Morris Cc: Casey Schaufler , Tetsuo Handa , Paul Moore , Stephen Smalley , "Schaufler, Casey" , LSM , Jonathan Corbet , linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20181001210532.NmESgZJoHEdpmdxm-Q6S84l4DdAKUTXSzBUfzcg4UKw@z> On 09/24/2018 05:18 PM, Kees Cook wrote: > For a while now, the LSM core has said it was "initializED", rather than > "initializING". This adjust the report to be more accurate (i.e. before > this was reported before any LSMs had been initialized.) > > Signed-off-by: Kees Cook > Reviewed-by: Casey Schaufler Reviewed-by: John Johansen > --- > security/security.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/security/security.c b/security/security.c > index 736e78da1ab9..4cbcf244a965 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -72,10 +72,11 @@ int __init security_init(void) > int i; > struct hlist_head *list = (struct hlist_head *) &security_hook_heads; > > + pr_info("Security Framework initializing\n"); > + > for (i = 0; i < sizeof(security_hook_heads) / sizeof(struct hlist_head); > i++) > INIT_HLIST_HEAD(&list[i]); > - pr_info("Security Framework initialized\n"); > > /* > * Load minor LSMs, with the capability module always first. >