From: Huacai Chen <chenhuacai@gmail.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Huacai Chen <chenhuacai@loongson.cn>,
Arnd Bergmann <arnd@arndb.de>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Airlie <airlied@linux.ie>, Jonathan Corbet <corbet@lwn.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xuefeng Li <lixuefeng@loongson.cn>,
Yanteng Si <siyanteng@loongson.cn>, Guo Ren <guoren@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH V11 09/22] LoongArch: Add boot and setup routines
Date: Fri, 20 May 2022 23:19:54 +0800 [thread overview]
Message-ID: <CAAhV-H7yKVWaiU_VKnc2YnCSeZPOwedRWMY8ZTS-VWwk+vE0AA@mail.gmail.com> (raw)
In-Reply-To: <cdbb002a-9f0a-caa9-445e-4ba20328171a@redhat.com>
Hi, Javier,
On Fri, May 20, 2022 at 10:23 PM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Hello Huacai,
>
> On 5/20/22 16:09, Huacai Chen wrote:
>
> [snip]
>
> >>
> >> In summary, just enable the following to use the firmware framebuffer:
> >>
> >> CONFIG_DRM_SIMPLEDRM=y
> >> CONFIG_DRM_FBDEV_EMULATION=y
> >> CONFIG_SYSFB=y
> >> CONFIG_SYSFB_SIMPLEFB=y
> > Thank you very much, since 5.15 sysfb_init() do all things of
> > register_gop_device(), so register_gop_device() here can be removed.
>
> Correct.
>
> > But there is another small problem: if simpledrm or efifb driver is
> > built-in, there is no display. The reason is both sysfb_init() and
> > display driver are in the same initcall level (device_initcall()).
> > From the comments I know that sysfb_init() should after PCI
> > enumeration which is in subsys_initcall(), so, could we make
> > sysfb_init() to be a subsys_initcall_sync()?
> >
>
> I don't understand why we would need that... it shouldn't matter the order
> in which the driver's init and sysfb_init() are done. If the driver's init
> is executed first, then the driver will be registered and later when the
> sysfb_init() registers the device, it will match the driver and probe.
>
> Conversely, if the sysfb_init() is executed first then the platform device
> will be registered and latter when the driver's init register the driver
> this will match the already registered device.
Yes, you are right, my consideration is too complex. The only real
problem is a harmless error "efifb: a framebuffer is already
registered" when both efifb and the native display driver are
built-in.
Huacai
>
> In other words, it will be handled by the Linux device model and we should
> not attempt to hand pick the initcall level for each. That's quite fragile.
>
> Or am I missing something here ?
>
> --
> Best regards,
>
> Javier Martinez Canillas
> Linux Engineering
> Red Hat
>
next prev parent reply other threads:[~2022-05-20 15:20 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 9:25 [PATCH V11 00/22] arch: Add basic LoongArch support Huacai Chen
2022-05-18 9:25 ` [PATCH V11 01/22] Documentation: LoongArch: Add basic documentations Huacai Chen
2022-05-18 15:34 ` WANG Xuerui
2022-05-18 9:25 ` [PATCH V11 02/22] Documentation/zh_CN: Add basic LoongArch documentations Huacai Chen
2022-05-18 15:32 ` WANG Xuerui
2022-05-20 7:37 ` Guo Ren
2022-05-20 7:43 ` WANG Xuerui
2022-05-18 9:26 ` [PATCH V11 03/22] LoongArch: Add ELF-related definitions Huacai Chen
2022-05-18 9:26 ` [PATCH V11 04/22] LoongArch: Add writecombine support for drm Huacai Chen
2022-05-18 9:26 ` [PATCH V11 05/22] LoongArch: Add build infrastructure Huacai Chen
2022-05-18 15:22 ` WANG Xuerui
2022-05-20 7:25 ` Guo Ren
2022-05-18 9:26 ` [PATCH V11 06/22] LoongArch: Add CPU definition headers Huacai Chen
2022-05-18 15:45 ` WANG Xuerui
2022-05-18 16:12 ` Huacai Chen
2022-05-18 9:26 ` [PATCH V11 07/22] LoongArch: Add atomic/locking headers Huacai Chen
2022-05-18 15:54 ` WANG Xuerui
2022-05-20 7:54 ` Guo Ren
2022-05-20 9:50 ` Huacai Chen
2022-05-20 18:14 ` Guo Ren
2022-05-21 1:55 ` Huacai Chen
2022-05-18 9:26 ` [PATCH V11 08/22] LoongArch: Add other common headers Huacai Chen
2022-05-18 16:04 ` WANG Xuerui
2022-05-18 9:26 ` [PATCH V11 09/22] LoongArch: Add boot and setup routines Huacai Chen
2022-05-18 15:17 ` WANG Xuerui
2022-05-18 16:08 ` Huacai Chen
2022-05-20 9:17 ` Ard Biesheuvel
2022-05-20 9:41 ` Javier Martinez Canillas
2022-05-20 14:09 ` Huacai Chen
2022-05-20 14:23 ` Javier Martinez Canillas
2022-05-20 15:19 ` Huacai Chen [this message]
2022-05-20 16:32 ` Javier Martinez Canillas
2022-05-21 1:40 ` Huacai Chen
2022-05-21 7:06 ` Javier Martinez Canillas
2022-05-21 7:37 ` Huacai Chen
2022-05-21 9:06 ` Javier Martinez Canillas
2022-05-21 9:13 ` Huacai Chen
2022-05-21 9:43 ` Javier Martinez Canillas
2022-05-20 15:53 ` Huacai Chen
2022-05-24 8:27 ` Xi Ruoyao
2022-05-24 10:59 ` Huacai Chen
2022-05-24 12:48 ` 李超
2022-05-18 9:26 ` [PATCH V11 10/22] LoongArch: Add exception/interrupt handling Huacai Chen
2022-05-18 9:26 ` [PATCH V11 11/22] LoongArch: Add process management Huacai Chen
2022-05-18 9:26 ` [PATCH V11 12/22] LoongArch: Add memory management Huacai Chen
2022-05-18 9:26 ` [PATCH V11 13/22] LoongArch: Add system call support Huacai Chen
2022-05-18 9:26 ` [PATCH V11 14/22] LoongArch: Add signal handling support Huacai Chen
2022-05-18 16:13 ` WANG Xuerui
2022-05-18 16:39 ` Eric W. Biederman
2022-05-18 16:54 ` Huacai Chen
2022-05-18 17:17 ` WANG Xuerui
2022-05-18 9:26 ` [PATCH V11 15/22] LoongArch: Add ELF and module support Huacai Chen
2022-05-18 9:26 ` [PATCH V11 16/22] LoongArch: Add misc common routines Huacai Chen
2022-05-18 9:57 ` [PATCH V11 17/22] LoongArch: Add some library functions Huacai Chen
2022-05-18 9:57 ` [PATCH V11 18/22] LoongArch: Add PCI controller support Huacai Chen
2022-05-18 9:57 ` [PATCH V11 19/22] LoongArch: Add VDSO and VSYSCALL support Huacai Chen
2022-05-18 9:57 ` [PATCH V11 20/22] LoongArch: Add multi-processor (SMP) support Huacai Chen
2022-05-18 9:57 ` [PATCH V11 21/22] LoongArch: Add Non-Uniform Memory Access (NUMA) support Huacai Chen
2022-05-18 9:57 ` [PATCH V11 22/22] LoongArch: Add Loongson-3 default config file Huacai Chen
2022-05-18 13:42 ` [PATCH V11 00/22] arch: Add basic LoongArch support Arnd Bergmann
2022-05-18 17:18 ` Huacai Chen
2022-05-18 22:36 ` Stephen Rothwell
2022-05-22 4:18 ` WANG Xuerui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhV-H7yKVWaiU_VKnc2YnCSeZPOwedRWMY8ZTS-VWwk+vE0AA@mail.gmail.com \
--to=chenhuacai@gmail.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@loongson.cn \
--cc=corbet@lwn.net \
--cc=guoren@kernel.org \
--cc=javierm@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=siyanteng@loongson.cn \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).