From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Higgins Subject: Re: [PATCH v5 02/12] arch: arm64: add linker section for KUnit test suites Date: Fri, 26 Jun 2020 14:23:00 -0700 Message-ID: References: <20200626210917.358969-1-brendanhiggins@google.com> <20200626210917.358969-3-brendanhiggins@google.com> <202006261420.02E8E62@keescook> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <202006261420.02E8E62@keescook> Sender: linux-doc-owner@vger.kernel.org To: Kees Cook Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , Arnd Bergmann , Shuah Khan , Alan Maguire , Iurii Zaikin , David Gow , Andrew Morton , rppt@linux.ibm.com, Frank Rowand , catalin.marinas@arm.com, will@kernel.org, monstr@monstr.eu, Michael Ellerman , Benjamin Herrenschmidt , paulus@samba.org, chris@zankel.net, jcmvbkbc@gmail.com, Greg KH , Stephen Boyd , Logan Gunthorpe , Luis Chamberlain , linux-um List-Id: linux-arch.vger.kernel.org On Fri, Jun 26, 2020 at 2:20 PM Kees Cook wrote: > > On Fri, Jun 26, 2020 at 02:09:07PM -0700, Brendan Higgins wrote: > > Add a linker section to arm64 where KUnit can put references to its test > > suites. This patch is an early step in transitioning to dispatching all > > KUnit tests from a centralized executor rather than having each as its > > own separate late_initcall. > > > > Signed-off-by: Brendan Higgins > > --- > > arch/arm64/kernel/vmlinux.lds.S | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S > > index 6827da7f3aa54..a1cae9cc655d7 100644 > > --- a/arch/arm64/kernel/vmlinux.lds.S > > +++ b/arch/arm64/kernel/vmlinux.lds.S > > @@ -181,6 +181,9 @@ SECTIONS > > INIT_RAM_FS > > *(.init.rodata.* .init.bss) /* from the EFI stub */ > > } > > + .kunit_test_suites : { > > + KUNIT_TEST_SUITES > > + } > > See my reply to 01/12. Then this patch can be dropped. :) Sweet, presumably this one and others. > > .exit.data : { > > EXIT_DATA > > } > > -- > > 2.27.0.212.ge8ba1cc988-goog > > > > -- > Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725833AbgFZVXN (ORCPT ); Fri, 26 Jun 2020 17:23:13 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8948FC03E97B for ; Fri, 26 Jun 2020 14:23:12 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id x8so3817970plm.10 for ; Fri, 26 Jun 2020 14:23:12 -0700 (PDT) MIME-Version: 1.0 References: <20200626210917.358969-1-brendanhiggins@google.com> <20200626210917.358969-3-brendanhiggins@google.com> <202006261420.02E8E62@keescook> In-Reply-To: <202006261420.02E8E62@keescook> From: Brendan Higgins Date: Fri, 26 Jun 2020 14:23:00 -0700 Message-ID: Subject: Re: [PATCH v5 02/12] arch: arm64: add linker section for KUnit test suites Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , Arnd Bergmann , Shuah Khan , Alan Maguire , Iurii Zaikin , David Gow , Andrew Morton , rppt@linux.ibm.com, Frank Rowand , catalin.marinas@arm.com, will@kernel.org, monstr@monstr.eu, Michael Ellerman , Benjamin Herrenschmidt , paulus@samba.org, chris@zankel.net, jcmvbkbc@gmail.com, Greg KH , Stephen Boyd , Logan Gunthorpe , Luis Chamberlain , linux-um , linux-arch@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , "open list:DOCUMENTATION" , Linux ARM , linuxppc-dev@lists.ozlabs.org, linux-xtensa@linux-xtensa.org Message-ID: <20200626212300.E2FqOY7brlFAir4IhxP2UHF7zHebKQjBu5ob1gnzjsc@z> On Fri, Jun 26, 2020 at 2:20 PM Kees Cook wrote: > > On Fri, Jun 26, 2020 at 02:09:07PM -0700, Brendan Higgins wrote: > > Add a linker section to arm64 where KUnit can put references to its test > > suites. This patch is an early step in transitioning to dispatching all > > KUnit tests from a centralized executor rather than having each as its > > own separate late_initcall. > > > > Signed-off-by: Brendan Higgins > > --- > > arch/arm64/kernel/vmlinux.lds.S | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S > > index 6827da7f3aa54..a1cae9cc655d7 100644 > > --- a/arch/arm64/kernel/vmlinux.lds.S > > +++ b/arch/arm64/kernel/vmlinux.lds.S > > @@ -181,6 +181,9 @@ SECTIONS > > INIT_RAM_FS > > *(.init.rodata.* .init.bss) /* from the EFI stub */ > > } > > + .kunit_test_suites : { > > + KUNIT_TEST_SUITES > > + } > > See my reply to 01/12. Then this patch can be dropped. :) Sweet, presumably this one and others. > > .exit.data : { > > EXIT_DATA > > } > > -- > > 2.27.0.212.ge8ba1cc988-goog > > > > -- > Kees Cook