From: Linus Torvalds <torvalds@linux-foundation.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Helge Deller <deller@gmx.de>, Arnd Bergmann <arnd@arndb.de>,
Guenter Roeck <linux@roeck-us.net>,
Ulrich Teichert <krypton@ulrich-teichert.org>,
linux-arch <linux-arch@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
llvm@lists.linux.dev
Subject: Re: Odd pci_iounmap() declaration rules..
Date: Sun, 19 Sep 2021 15:27:51 -0700 [thread overview]
Message-ID: <CAHk-=wgNfaf03Dw78q1qLLZs6G=iJjfo5ZTcnyXgSk3w1tp0yg@mail.gmail.com> (raw)
In-Reply-To: <YUeriU9EIJ5hiFjL@archlinux-ax161>
On Sun, Sep 19, 2021 at 2:28 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> Commit 9caea0007601 ("parisc: Declare pci_iounmap() parisc version only
> when CONFIG_PCI enabled") causes the following build error on arm64 with
> Fedora's config, which CKI initially reported:
Ok, so I spent a lot of time trying to figure out what the heck is going on.
And while this is really *REALLY* confusing code, and nobody should
use it, I think the fix is this oneliner:
diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
index e93375c710b9..692e964e56b4 100644
--- a/include/asm-generic/io.h
+++ b/include/asm-generic/io.h
@@ -1047,7 +1047,7 @@ extern void ioport_unmap(void __iomem *p);
#endif /* CONFIG_GENERIC_IOMAP */
#endif /* CONFIG_HAS_IOPORT_MAP */
-#ifndef CONFIG_GENERIC_IOMAP
+#ifndef CONFIG_GENERIC_PCI_IOMAP
struct pci_dev;
extern void __iomem *pci_iomap(struct pci_dev *dev, int bar,
unsigned long max);
let me go test, I do have an arm64 build environment for this all, but
for that commit I had only done parisc, alpha and x86-64.
Linus
next prev parent reply other threads:[~2021-09-19 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 20:38 Odd pci_iounmap() declaration rules Linus Torvalds
2021-09-19 17:04 ` Helge Deller
2021-09-19 18:05 ` Linus Torvalds
2021-09-19 21:28 ` Nathan Chancellor
2021-09-19 22:27 ` Linus Torvalds [this message]
2021-09-19 22:44 ` Linus Torvalds
2021-09-20 0:44 ` Linus Torvalds
2021-09-20 14:30 ` Nathan Chancellor
2021-09-20 15:31 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgNfaf03Dw78q1qLLZs6G=iJjfo5ZTcnyXgSk3w1tp0yg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=krypton@ulrich-teichert.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).