From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,TVD_SUBJ_WIPE_DEBT,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75E3C43461 for ; Wed, 9 Sep 2020 21:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DC7621D82 for ; Wed, 9 Sep 2020 21:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599687251; bh=MyGCCFAgjPrJuTxv6ESslWXTkvxYvypITFIZbu9YrxQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ez76gPJqupI6h13geEyrjf+WMl77PMw+p5GNx+5NTHonBhxPtmnvFUaVf6AFGs4r2 xDkU3XELBMd36EX9N9y4lOWSFb0kx8huZFDxsbL0p2SBHJfOs1H0kmxrsi5x24WejU 8nHnuI6SfIFq3X6FQWbStkwwWB5V8jC7PPT+4Osg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729860AbgIIVd6 (ORCPT ); Wed, 9 Sep 2020 17:33:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728350AbgIIVd5 (ORCPT ); Wed, 9 Sep 2020 17:33:57 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3160DC061755 for ; Wed, 9 Sep 2020 14:33:56 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id z19so2408276lfr.4 for ; Wed, 09 Sep 2020 14:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B0+jz5nEBaWAhh7n7Hp1qz3wUrloORRxGTRRlKkQIgM=; b=ZC+O3RgWhIgNKsFzAoxkbel7tu0gOmF8ciyCULsTleltXACSMEUPzu0YhQCYyxG+n0 fRQ2KEHRUpo3+MHY+wuhqjq5jU82lgflP0z62nRjLA58w/Z1YR52q8f3ta82dR9XKkQK 4JeSuKlLlKaSmxiZJnS7lLTjpttmYgqxvU9OY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B0+jz5nEBaWAhh7n7Hp1qz3wUrloORRxGTRRlKkQIgM=; b=eFTOHHOqonaFQhX1Tc9FZ4EtHENRmspxQgLpY1ZOr/1Qay+guEuT4nFaCc9cehJ5/x vUn5bP8fKAfXLOsyPLftacUKUK41NXaUtX2UzCZvL5tVpOhq2izCyLXBV02YeOYK+qiY l2Eqe200aFKxYOSLBcTxpTtu2ajwokxRZJT/MsdU5CGsg978uVu+GW9qvptXdwM4hNPr dmj8ROnz6qbnebb9NJt08wdVJe0vfEKbNZ2maKVtXVph6e9a/MfaAkIhkGr20rCrvpQt hVUTMCff59qRKBjkRqjMmBLCzZpu1Xp1VjS5jyCPTJeFDzrcc2JMaSVavop7Obgi9gbY tFeA== X-Gm-Message-State: AOAM533xcylP/pVtvP7VkWb7QPtaiehdU516rWJf0ZNqjrlXrjHeyalU nccFiKjj+Qi7Xu7TRdShzCH0nCPZSzUoMA== X-Google-Smtp-Source: ABdhPJxzFPt0ckQB1+3FCnQHPNfnkIGtZp4DscXco37sreGnMSI5PFa+9eaQ3VA+q7uR87zj+WcYNg== X-Received: by 2002:a19:5e19:: with SMTP id s25mr2662735lfb.196.1599687233910; Wed, 09 Sep 2020 14:33:53 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id l15sm827962lfk.71.2020.09.09.14.33.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2020 14:33:52 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id n25so5481398ljj.4 for ; Wed, 09 Sep 2020 14:33:52 -0700 (PDT) X-Received: by 2002:a2e:84d6:: with SMTP id q22mr2679648ljh.70.1599687232145; Wed, 09 Sep 2020 14:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20200903142242.925828-1-hch@lst.de> <20200903142803.GM1236603@ZenIV.linux.org.uk> <20200909184001.GB28786@gate.crashing.org> In-Reply-To: <20200909184001.GB28786@gate.crashing.org> From: Linus Torvalds Date: Wed, 9 Sep 2020 14:33:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: remove the last set_fs() in common code, and remove it for x86 and powerpc v3 To: Segher Boessenkool Cc: Al Viro , Nick Desaulniers , linux-arch , Kees Cook , "the arch/x86 maintainers" , Linux Kernel Mailing List , Alexey Dobriyan , Luis Chamberlain , linux-fsdevel , linuxppc-dev , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, Sep 9, 2020 at 11:42 AM Segher Boessenkool wrote: > > It will not work like this in GCC, no. The LLVM people know about that. > I do not know why they insist on pushing this, being incompatible and > everything. Umm. Since they'd be the ones supporting this, *gcc* would be the incompatible one, not clang. Like it or not, clang is becoming a major kernel compiler. It's already basically used for all android uses afaik. So I'd phrase it differently. If gcc is planning on doing some different model for asm goto with outputs, that would be the incompatible case. I'm not sure how gcc could do it differently. The only possible difference I see is (a) not doing it at all (b) doing the "all goto targets have the outputs" case and honestly, (b) is actually inferior for the error cases, even if to a compiler person it might feel like the "RightThing(tm)" to do. Because when an exception happens, the outputs simply won't be initialized. Anyway, for either of those cases, the kernel won't care either way. We'll have to support the non-goto case for many years even if everybody were to magically implement it today, so it's not like this is a "you have to do it" thing. Linus