From: Guo Ren <guoren@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de,
peterz@infradead.org, luto@kernel.org,
conor.dooley@microchip.com, heiko@sntech.de, jszhang@kernel.org,
lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org,
apatel@ventanamicro.com, atishp@atishpatra.org,
palmer@dabbelt.com, paul.walmsley@sifive.com,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org,
Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH V4 7/8] riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK
Date: Sun, 18 Sep 2022 23:42:48 +0800 [thread overview]
Message-ID: <CAJF2gTSV9HQ+6A1kh48_MjWir7mtfE7+9P9--s-aqPpt9cb7sw@mail.gmail.com> (raw)
In-Reply-To: <YxoR5Fv6hOkzMSTg@linutronix.de>
On Fri, Sep 9, 2022 at 12:01 AM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> On 2022-09-07 22:25:05 [-0400], guoren@kernel.org wrote:
> > --- a/arch/riscv/kernel/irq.c
> > +++ b/arch/riscv/kernel/irq.c
> > @@ -11,6 +11,7 @@
> > #include <linux/seq_file.h>
> > #include <asm/smp.h>
> > #include <asm/vmap_stack.h>
> > +#include <asm/softirq_stack.h>
> >
> > #ifdef CONFIG_IRQ_STACKS
> > static DEFINE_PER_CPU(ulong *, irq_stack_ptr);
> > @@ -38,6 +39,21 @@ static void init_irq_stacks(void)
> > per_cpu(irq_stack_ptr, cpu) = per_cpu(irq_stack, cpu);
> > }
> > #endif /* CONFIG_VMAP_STACK */
> > +
> > +#ifndef CONFIG_PREEMPT_RT
>
> Could you please replace it with
> #ifdef CONFIG_SOFTIRQ_ON_OWN_STACK
Thx, I would.
>
> instead? See
> https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/commit/?id=8cbb2b50ee2dcb082675237eaaa48fe8479f8aa5
>
> > +static void do_riscv_softirq(struct pt_regs *regs)
> > +{
> > + __do_softirq();
> > +}
> > +
> > +void do_softirq_own_stack(void)
> > +{
> > + ulong *sp = per_cpu(irq_stack_ptr, smp_processor_id());
> > +
> > + call_on_stack(NULL, sp, do_riscv_softirq, 0);
> > +}
> > +#endif /* CONFIG_PREEMPT_RT */
> > +
> > #else
> > static void init_irq_stacks(void) {}
> > #endif /* CONFIG_IRQ_STACKS */
>
> Sebastian
--
Best Regards
Guo Ren
next prev parent reply other threads:[~2022-09-18 15:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 2:24 [PATCH V4 0/9] riscv: Add GENERIC_ENTRY, irq stack support guoren
2022-09-08 2:24 ` [PATCH V4 1/8] riscv: elf_kexec: Fixup compile warning guoren
2022-09-08 2:25 ` [PATCH V4 2/8] riscv: compat_syscall_table: " guoren
2022-09-08 2:25 ` [PATCH V4 3/8] riscv: ptrace: Remove duplicate operation guoren
2022-09-08 2:25 ` [PATCH V4 4/8] riscv: traps: Add noinstr to prevent instrumentation inserted guoren
2022-09-08 7:33 ` Peter Zijlstra
2022-09-10 9:17 ` Guo Ren
2022-09-10 12:46 ` Guo Ren
2022-09-11 15:09 ` Peter Zijlstra
2022-09-11 16:20 ` Guo Ren
2022-09-08 2:25 ` [PATCH V4 5/8] riscv: convert to generic entry guoren
2022-09-15 13:50 ` Yipeng Zou
2022-09-08 2:25 ` [PATCH V4 6/8] riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK guoren
2022-09-08 16:08 ` Sebastian Andrzej Siewior
2022-09-09 7:30 ` David Laight
2022-09-11 1:13 ` Guo Ren
2022-09-08 2:25 ` [PATCH V4 7/8] riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK guoren
2022-09-08 16:01 ` Sebastian Andrzej Siewior
2022-09-18 15:42 ` Guo Ren [this message]
2022-09-08 2:25 ` [PATCH V4 8/8] riscv: Add config of thread stack size guoren
2022-09-08 7:35 ` Arnd Bergmann
2022-09-10 12:52 ` Guo Ren
2022-09-10 16:06 ` Arnd Bergmann
2022-09-10 23:35 ` Guo Ren
2022-09-11 18:39 ` Arnd Bergmann
2022-09-12 4:14 ` Guo Ren
2022-09-12 8:23 ` Arnd Bergmann
2022-09-19 8:38 ` Guo Ren
2022-09-19 8:35 ` Guo Ren
2022-09-20 0:46 ` Guo Ren
2022-09-20 7:15 ` Arnd Bergmann
2022-09-21 6:11 ` Guo Ren
2022-09-20 7:17 ` Arnd Bergmann
2022-09-21 6:13 ` Guo Ren
2022-09-21 8:23 ` Guo Ren
2022-09-21 10:31 ` Guo Ren
2022-09-21 10:46 ` Guo Ren
2022-09-22 5:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTSV9HQ+6A1kh48_MjWir7mtfE7+9P9--s-aqPpt9cb7sw@mail.gmail.com \
--to=guoren@kernel.org \
--cc=apatel@ventanamicro.com \
--cc=arnd@arndb.de \
--cc=atishp@atishpatra.org \
--cc=bigeasy@linutronix.de \
--cc=chenhuacai@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=falcon@tinylab.org \
--cc=guoren@linux.alibaba.com \
--cc=heiko@sntech.de \
--cc=jszhang@kernel.org \
--cc=lazyparser@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@kernel.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).