From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF8DDC433E7 for ; Sat, 17 Oct 2020 05:34:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D9FF2076A for ; Sat, 17 Oct 2020 05:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602912859; bh=fpHhlwbctvfNxQYSpl4aWDgazqqRashCbvf/XH+/65o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=yS1haF6pzHBHc6MioeRYIccrE4f/jLSqMIfue04g1w7CrTdnWL/9hSsnfu/RwfhEA a3xvlzh10IbbVdX6dJ8Fr72e3bMjgCXjBlezfzwsbzo004PD6dJRl4QrOyMKEyV9Ll 9TorUxu/E3xg1kotb9jmZpl5AcZG3MgNsFv5yQd8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406783AbgJQFeT (ORCPT ); Sat, 17 Oct 2020 01:34:19 -0400 Received: from condef-07.nifty.com ([202.248.20.72]:29575 "EHLO condef-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392694AbgJQFeT (ORCPT ); Sat, 17 Oct 2020 01:34:19 -0400 X-Greylist: delayed 445 seconds by postgrey-1.27 at vger.kernel.org; Sat, 17 Oct 2020 01:34:17 EDT Received: from conssluserg-03.nifty.com ([10.126.8.82])by condef-07.nifty.com with ESMTP id 09H1l3wP011554; Sat, 17 Oct 2020 10:47:03 +0900 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (authenticated) by conssluserg-03.nifty.com with ESMTP id 09H1kmka028705; Sat, 17 Oct 2020 10:46:48 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 09H1kmka028705 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1602899209; bh=/0ovXshOhxLJmlzp2NpX2ArKIwhaV5c9daLvgg85jsg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=0stKPxzpCuJojIl84Bap+GcFlN95iCk5b1y2Ur4dn5CdBNku5y5qT9INLgCiIwZbR u659+Dn0zDhJhfB00RQrtwl+GiV+V3Fc0z2w1nJQCnnCFIr3kdOXTCHnjUUdbmQWVX MeVRXjDPKXXlLt5HQpZqGtPC4zi5Bc0I69hTqKExGEOKVHgflFjMSqgfS95N/yRwdw 3HSTGv73eD9p3poujLcVuwZTjCTUcUx/6XOHFj4eUTvk7kwCfYwPrPQ5RCZCsCKl8W ShFHdzRceMHi71f7Ynv4a6eTuTsHkRS66eSRjfdBS8bt/oD9kKSwq4sdlQLYtaEhMS sV4o2EHMMXyvQ== X-Nifty-SrcIP: [209.85.216.47] Received: by mail-pj1-f47.google.com with SMTP id j8so2445957pjy.5; Fri, 16 Oct 2020 18:46:48 -0700 (PDT) X-Gm-Message-State: AOAM53029u4e0L72SlQ7fFqcaf2+fYVaIh0XIsIEoWzXqjSYjbrKtj6v 5we8vt/HB83sSqh91N2BiOn+zn7EMNVU79MNwYc= X-Google-Smtp-Source: ABdhPJwnDvT6VOCCvby8Z+dRxKHlAcETSIANPUgxy4yeQxdCEUHUrDGlLwfVIqt5UgjHFKL6uGwJ8RIXqDyJ0U/afPU= X-Received: by 2002:a17:90a:aa91:: with SMTP id l17mr6700984pjq.198.1602899207791; Fri, 16 Oct 2020 18:46:47 -0700 (PDT) MIME-Version: 1.0 References: <20201013003203.4168817-1-samitolvanen@google.com> <20201013003203.4168817-8-samitolvanen@google.com> <202010141541.E689442E@keescook> In-Reply-To: <202010141541.E689442E@keescook> From: Masahiro Yamada Date: Sat, 17 Oct 2020 10:46:10 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 07/25] treewide: remove DISABLE_LTO To: Kees Cook Cc: Sami Tolvanen , Steven Rostedt , Will Deacon , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , linux-arm-kernel , Linux Kbuild mailing list , Linux Kernel Mailing List , linux-pci@vger.kernel.org, X86 ML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Thu, Oct 15, 2020 at 7:43 AM Kees Cook wrote: > > On Mon, Oct 12, 2020 at 05:31:45PM -0700, Sami Tolvanen wrote: > > This change removes all instances of DISABLE_LTO from > > Makefiles, as they are currently unused, and the preferred > > method of disabling LTO is to filter out the flags instead. > > > > Suggested-by: Kees Cook > > Signed-off-by: Sami Tolvanen > > Reviewed-by: Kees Cook > > Hi Masahiro, > > Since this is independent of anything else and could be seen as a > general cleanup, can this patch be taken into your tree, just to > separate it from the list of dependencies for this series? > > -Kees > > -- > Kees Cook Yes, this is stale code because GCC LTO was not pulled. Applied to linux-kbuild. I added the following historical background. Note added by Masahiro Yamada: DISABLE_LTO was added as preparation for GCC LTO, but GCC LTO was not pulled into the mainline. (https://lkml.org/lkml/2014/4/8/272) -- Best Regards Masahiro Yamada