From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Subject: Re: [PATCH v10 01/11] h8300: put bitsperlong.h in uapi Date: Mon, 27 Mar 2017 14:31:21 +0900 Message-ID: References: <1489496093-15315-1-git-send-email-nicolas.dichtel@6wind.com> <1489496093-15315-2-git-send-email-nicolas.dichtel@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1489496093-15315-2-git-send-email-nicolas.dichtel@6wind.com> Sender: linux-kbuild-owner@vger.kernel.org To: Nicolas Dichtel Cc: Arnd Bergmann , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , linux-arch@vger.kernel.org, David Airlie , "David S. Miller" , Russell King , bp@alien8.de, slash.tmp@free.fr, Daniel Vetter , rmk+kernel@armlinux.org.uk, msalter@redhat.com, jengelh@inai.de, hch@infradead.org, Tobias Klauser , mpe@ellerman.id.au, Ingo Molnar , Thomas Gleixner , "Dmitry V. Levin" , Herbert Xu , linux-rdma@vger.kernel.org List-Id: linux-arch.vger.kernel.org Hi Nicolas, 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel : > This header file is exported, thus move it to uapi. > > Signed-off-by: Nicolas Dichtel > -#endif /* __ASM_H8300_BITS_PER_LONG */ > diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h b/arch/h8300/include/uapi/asm/bitsperlong.h > new file mode 100644 > index 000000000000..e56cf72369b6 > --- /dev/null > +++ b/arch/h8300/include/uapi/asm/bitsperlong.h > @@ -0,0 +1,14 @@ > +#ifndef _UAPI_ASM_H8300_BITS_PER_LONG > +#define _UAPI_ASM_H8300_BITS_PER_LONG Just a minor comment. The include guard was originally __ASM_H8300_BITS_PER_LONG. This will change it into _ASM_H8300_BITS_PER_LONG (after _UAPI is stripped by headers_install.sh) I just thought _UAPI__ASM_H8300_BITS_PER_LONG might be even safer, but I know I am nit-picking. I can apply this as-is. I leave it to you. -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from condef-08.nifty.com ([202.248.20.73]:64788 "EHLO condef-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbdC0Ffc (ORCPT ); Mon, 27 Mar 2017 01:35:32 -0400 MIME-Version: 1.0 In-Reply-To: <1489496093-15315-2-git-send-email-nicolas.dichtel@6wind.com> References: <1489496093-15315-1-git-send-email-nicolas.dichtel@6wind.com> <1489496093-15315-2-git-send-email-nicolas.dichtel@6wind.com> From: Masahiro Yamada Date: Mon, 27 Mar 2017 14:31:21 +0900 Message-ID: Subject: Re: [PATCH v10 01/11] h8300: put bitsperlong.h in uapi Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Nicolas Dichtel Cc: Arnd Bergmann , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , linux-arch@vger.kernel.org, David Airlie , "David S. Miller" , Russell King , bp@alien8.de, slash.tmp@free.fr, Daniel Vetter , rmk+kernel@armlinux.org.uk, msalter@redhat.com, jengelh@inai.de, hch@infradead.org, Tobias Klauser , mpe@ellerman.id.au, Ingo Molnar , Thomas Gleixner , "Dmitry V. Levin" , Herbert Xu , linux-rdma@vger.kernel.org Message-ID: <20170327053121.yCnMcNzYLczdNj4rV6V0qz5ivxYjEOtHEaWU-1LQ9Zc@z> Hi Nicolas, 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel : > This header file is exported, thus move it to uapi. > > Signed-off-by: Nicolas Dichtel > -#endif /* __ASM_H8300_BITS_PER_LONG */ > diff --git a/arch/h8300/include/uapi/asm/bitsperlong.h b/arch/h8300/include/uapi/asm/bitsperlong.h > new file mode 100644 > index 000000000000..e56cf72369b6 > --- /dev/null > +++ b/arch/h8300/include/uapi/asm/bitsperlong.h > @@ -0,0 +1,14 @@ > +#ifndef _UAPI_ASM_H8300_BITS_PER_LONG > +#define _UAPI_ASM_H8300_BITS_PER_LONG Just a minor comment. The include guard was originally __ASM_H8300_BITS_PER_LONG. This will change it into _ASM_H8300_BITS_PER_LONG (after _UAPI is stripped by headers_install.sh) I just thought _UAPI__ASM_H8300_BITS_PER_LONG might be even safer, but I know I am nit-picking. I can apply this as-is. I leave it to you. -- Best Regards Masahiro Yamada