From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D83C433E1 for ; Mon, 24 Aug 2020 18:39:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1ED12074D for ; Mon, 24 Aug 2020 18:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbgHXSjG (ORCPT ); Mon, 24 Aug 2020 14:39:06 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:55335 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgHXSjF (ORCPT ); Mon, 24 Aug 2020 14:39:05 -0400 Received: from mail-qk1-f174.google.com ([209.85.222.174]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MLAAs-1jtIiT1mMs-00IAPf; Mon, 24 Aug 2020 20:39:03 +0200 Received: by mail-qk1-f174.google.com with SMTP id n129so8413650qkd.6; Mon, 24 Aug 2020 11:39:02 -0700 (PDT) X-Gm-Message-State: AOAM533GoAksagaHXOg4j38Zr377VXxK0VxSW/leHWXNxC6eqapnHM1z iG4S79KSG4/p6ImSRNgr5Yn6w61qnwbVzgcHoz4= X-Google-Smtp-Source: ABdhPJxJvbiLbhFh8vD057RbddB7UEJe4ClqG4b3m1sziovfYqvCJXHcrzaj91rVO8TT5jSK5crxBkQQA/dFlQR8EPo= X-Received: by 2002:ae9:f106:: with SMTP id k6mr5648402qkg.3.1598294342005; Mon, 24 Aug 2020 11:39:02 -0700 (PDT) MIME-Version: 1.0 References: <1598287583-71762-1-git-send-email-mikelley@microsoft.com> <1598287583-71762-3-git-send-email-mikelley@microsoft.com> In-Reply-To: <1598287583-71762-3-git-send-email-mikelley@microsoft.com> From: Arnd Bergmann Date: Mon, 24 Aug 2020 20:38:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 02/10] arm64: hyperv: Add core Hyper-V include files To: Michael Kelley Cc: Will Deacon , Ard Biesheuvel , Catalin Marinas , Mark Rutland , Marc Zyngier , Linux ARM , gregkh , "linux-kernel@vger.kernel.org" , linux-hyperv@vger.kernel.org, linux-efi , linux-arch , wei.liu@kernel.org, Vitaly Kuznetsov , "K. Y. Srinivasan" , Sunil Muthuswamy , Boqun Feng Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Lup994B9M/joDDHE/Mn9GCbY8qhexb9qrSZlYAxKE6BIofeZgWB AuCK0IbuyDRmWTwrhtMSEbsxr8qLCLryx4/dlzai8FKvB2tiFLSHX19ZKQZvT/LCyHhRS66 wKp4vFX5WIEX8i94nh+kVNJQFZnnoxH/h8ZKvUfQpN15zLoB6sswHSXLsa6M4MBihzQN4h6 JW4CWdv7IPsrQu/3FqZEg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wQqH2+rPVXY=:UsQCuOiBUDFWZBRrfbysfm 7skOXJpB1walSUF2fUxhtp5EUnP55ygZ7Vd/Sx2RKO7n7dZK/QuEG44rhSLId9tvuoISX5IWd V8QOW/I5OgI4RkO7tT1/uekPZ+GNifArPLTpo+CpDqhmco0wRvZGrJQmjOu4WB1EHv+CND/a2 q80zhScWPA0PAmvVpSeoqsDMnMXjzsZHHWD2ettfSq+rxEZ0n1jcCSGBmEIACevgelF/WexNR QVGTH484tcoww/JAR8C4qI6Mq8Bb3trKNMHiakeexBAC/crNk56KjrQftP4HDUgpX5PhbcPm+ MexxDHX6lwsZnEC1nMOR9RvhLl4omy+xafcvHeY6GHJlXfgh9e495UzbM8g5a0VT6bLIA44SN B1gL1vVIEc8VGQ8utMt8KeM6YnBgQ4JF16lGAZ/TIjoIfWhkIsRH3Pfr9DyTi4dqsRkzg5+81 n+X69inUsERA/G1rdfBFZmHHlJpSq4aOR1DyO9bWVadBDqaYX+2nCsLhL8jUNHfO88lS92q6x NlRgfO3jub1dnEZaiMVyuh1fTvuGcNGS2QQFfxvOL39uIpyX2NzLkyQr9wd67Kwl+q7EflvGz 7f8rUOCogjg+WHUNPpqtVX8RxWuPZAsGa4VZ/bAC+QktJnXRzisqsYS7jAVS46vVP/UyRIkQ3 Vqd6TxqDIUEh0XrAOWB9rcYSelnNpootlrxXSc6R0zILU7WF+4BNtW/gBmm/JZZY/B3TxHT54 EpT1Lf/glHNsigxH4o5VEO/b0lxgSymqKUKczMnYX7ksR5834F+aMkicrQfVWCFtvxZCzlhLw 2HxsoWxDUYBAkS2nHVD5fdhOodq8fKH09yV48Jru982XeLVJgQ9Vq5LXluWLpCH8kOLwLFeVF Z0zLXKs3KjtSSTu+BRvf0GsZXHufZRC+JJWLdVeoJdchFoWCLOpNP8MfjTzYACePoI824Vb0U FS7R/TBvsvIkSEJNwLi+3Z2w4j0/IXYM9Aa/ZFFc2lhspwlhYh8dT Sender: linux-arch-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, Aug 24, 2020 at 6:47 PM Michael Kelley wrote: > + > +#define hv_get_simp(val) (val = hv_get_vpreg(HV_REGISTER_SIPP)) > + > +#define hv_get_siefp(val) (val = hv_get_vpreg(HV_REGISTER_SIFP)) Macros that modify their arguments are generally a bad idea. Since each one of these only has a few callers, could you just redefine the x86 version to use function-style calling conventions and turn them into inline functions? Arnd