From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation Date: Thu, 11 Oct 2018 09:03:51 +0200 Message-ID: References: <1538975801-13735-1-git-send-email-firoz.khan@linaro.org> <1538975801-13735-5-git-send-email-firoz.khan@linaro.org> <20181009201321.GA28911@ls3530.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Firoz Khan Cc: Helge Deller , Parisc List , "James E.J. Bottomley" , Thomas Gleixner , gregkh , Philippe Ombredanne , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz List-Id: linux-arch.vger.kernel.org On Thu, Oct 11, 2018 at 8:48 AM Firoz Khan wrote: > On Thu, 11 Oct 2018 at 11:40, Firoz Khan wrote: > > On Wed, 10 Oct 2018 at 01:48, Helge Deller wrote: > > > + > > > +ENTRY(sys_call_table) > > > +#if defined(CONFIG_64BIT) > > > +#include /* compat syscalls */ > > > +#else > > > +#include /* 32-bit native syscalls */ > > > +#endif > > > +END(sys_call_table) > > > + > > > #ifdef CONFIG_64BIT > > > -#define SYSCALL_TABLE_64BIT > > > -#include "syscall_table_64.S" > > > +ENTRY(sys_call_table64) > > > +#include /* 64-bit native syscalls */ > > > +END(sys_call_table64) > > > #endif > > > > > > /* > > I could see a patch (commit 47514da3ac20150cdf764466fbc2010c0fca0163) > which will perform a compile-check when adding a new syscall. My patches > will remove this feature. Is that fine? I think it's ok: You are automating it so the bug can no longer happen, which is better than adding checks to prevent human errors. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f196.google.com ([209.85.222.196]:35864 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbeJKOaD (ORCPT ); Thu, 11 Oct 2018 10:30:03 -0400 MIME-Version: 1.0 References: <1538975801-13735-1-git-send-email-firoz.khan@linaro.org> <1538975801-13735-5-git-send-email-firoz.khan@linaro.org> <20181009201321.GA28911@ls3530.fritz.box> In-Reply-To: From: Arnd Bergmann Date: Thu, 11 Oct 2018 09:03:51 +0200 Message-ID: Subject: Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Firoz Khan Cc: Helge Deller , Parisc List , "James E.J. Bottomley" , Thomas Gleixner , gregkh , Philippe Ombredanne , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz Message-ID: <20181011070351.R6Xm4JgmLqD74hytqfwMKeCoSiiRxrRrFHOy7ac7_JU@z> On Thu, Oct 11, 2018 at 8:48 AM Firoz Khan wrote: > On Thu, 11 Oct 2018 at 11:40, Firoz Khan wrote: > > On Wed, 10 Oct 2018 at 01:48, Helge Deller wrote: > > > + > > > +ENTRY(sys_call_table) > > > +#if defined(CONFIG_64BIT) > > > +#include /* compat syscalls */ > > > +#else > > > +#include /* 32-bit native syscalls */ > > > +#endif > > > +END(sys_call_table) > > > + > > > #ifdef CONFIG_64BIT > > > -#define SYSCALL_TABLE_64BIT > > > -#include "syscall_table_64.S" > > > +ENTRY(sys_call_table64) > > > +#include /* 64-bit native syscalls */ > > > +END(sys_call_table64) > > > #endif > > > > > > /* > > I could see a patch (commit 47514da3ac20150cdf764466fbc2010c0fca0163) > which will perform a compile-check when adding a new syscall. My patches > will remove this feature. Is that fine? I think it's ok: You are automating it so the bug can no longer happen, which is better than adding checks to prevent human errors. Arnd