From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 2/3] mips: Add system call table generation support Date: Fri, 14 Sep 2018 11:58:09 +0200 Message-ID: References: <1536914314-5026-1-git-send-email-firoz.khan@linaro.org> <1536914314-5026-3-git-send-email-firoz.khan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1536914314-5026-3-git-send-email-firoz.khan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Firoz Khan Cc: Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:RALINK MIPS ARCHITECTURE" , Ralf Baechle , Paul Burton , James Hogan , gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz List-Id: linux-arch.vger.kernel.org On Fri, Sep 14, 2018 at 10:39 AM Firoz Khan wrote: > > The system call tables are in different format in all > architecture and it will be difficult to manually add or > modify the system calls in the respective files. To make > it easy by keeping a script and which'll generate the > header file and syscall table file so this change will > unify them across all architectures. > > The system call table generation script is added in > syscalls directory which contain the script to generate > both uapi header file system call table generation file > and syscall_32/64.tbl file which'll be the input for the > scripts. I think it would be best to name the files o32/n64/n32 instead of 32/64/n32 It would also be helpful to mention why the n32/n64 files cannot be combined into one nfile here. > +364 32 pkey_alloc sys_pkey_alloc > +365 32 pkey_free sys_pkey_free > +366 32 statx sys_statx You missed the additon of rseq and io_pgetevetns here. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f172.google.com ([209.85.216.172]:43297 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbeINPMM (ORCPT ); Fri, 14 Sep 2018 11:12:12 -0400 MIME-Version: 1.0 References: <1536914314-5026-1-git-send-email-firoz.khan@linaro.org> <1536914314-5026-3-git-send-email-firoz.khan@linaro.org> In-Reply-To: <1536914314-5026-3-git-send-email-firoz.khan@linaro.org> From: Arnd Bergmann Date: Fri, 14 Sep 2018 11:58:09 +0200 Message-ID: Subject: Re: [PATCH 2/3] mips: Add system call table generation support Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Firoz Khan Cc: Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:RALINK MIPS ARCHITECTURE" , Ralf Baechle , Paul Burton , James Hogan , gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz Message-ID: <20180914095809.sOJWIqjQ5FpaFSDhtzGQ4OboGkocEyBIvfF2Vjsp9Ww@z> On Fri, Sep 14, 2018 at 10:39 AM Firoz Khan wrote: > > The system call tables are in different format in all > architecture and it will be difficult to manually add or > modify the system calls in the respective files. To make > it easy by keeping a script and which'll generate the > header file and syscall table file so this change will > unify them across all architectures. > > The system call table generation script is added in > syscalls directory which contain the script to generate > both uapi header file system call table generation file > and syscall_32/64.tbl file which'll be the input for the > scripts. I think it would be best to name the files o32/n64/n32 instead of 32/64/n32 It would also be helpful to mention why the n32/n64 files cannot be combined into one nfile here. > +364 32 pkey_alloc sys_pkey_alloc > +365 32 pkey_free sys_pkey_free > +366 32 statx sys_statx You missed the additon of rseq and io_pgetevetns here. Arnd