From: Arnd Bergmann <arnd@arndb.de>
To: Tony Luck <tony.luck@intel.com>
Cc: Firoz Khan <firoz.khan@linaro.org>,
linux-ia64@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
gregkh <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v3 0/7] ia64: system call table generation support
Date: Fri, 12 Oct 2018 21:40:41 +0200 [thread overview]
Message-ID: <CAK8P3a2uMx8eAa+WAGtePA3O=U_LXXBP7XX62fAO9g1NfpXgNQ@mail.gmail.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7D410C05@ORSMSX107.amr.corp.intel.com>
On Fri, Oct 12, 2018 at 6:12 PM Luck, Tony <tony.luck@intel.com> wrote:
>
> > I suspect the offset logic in the system call generation script had a bug. That
> > I fixed it in this patch series.
> >
> > Arnd and Eugene had shared few comments on adding new system call entry in the
> > table and some other things. Appreciate if you can review this patch
> > series so I can
> > finalize system call table implementation for ia64 architecture.
>
> The net effect of these is just to make it easier to add new system calls. Just
> edit the table, instead of editing entry.S and unistd.h picking the next number
> (and remembering to increase the NR_syscalls). Right?
The driving factor here is the addition of the new y2038 syscalls for 32-bit
architectures that we want to add everywhere at the same time. ia64
and alpha are obviously not affected by this as they are 64-bit only,
but to do it right, we should do all architectures together.
Another point is overall maintainability: it is very time-consuming and
error-prone to find out which architectures in which kernel version support
a specific system call or don't support it. Having a consistent way to
work on the tables should make this is a simple 'git grep'.
> I'm currently baffled at which linker magic makes the unsupported system
> calls alias to sys_ni_syscall.
This is the same method that x86, arm, and s390 have been using
for a while, by sorting the numbers and filling in the missing ones
in the script.
> I'm also uncertain whether allocating system call numbers and creating
> entry points for all the unsupported syscalls is the right thing to do. Might
> that puzzle and frustrate folks whose applications build, but then fail at
> run-time with -ENOSYS.
Again, we want this to be handled consistently across architectures
more than anything. At the moment, we have some architectures that
simply assign a number for each syscall added to x86, while others
don't. Similarly, some architectures drop the entries from unistd.h
if a syscall gets removed from the kernel, and others keep them.
I care less about which way we decide to go here, but I want it to
be done the same way for all architectures.
Arnd
next prev parent reply other threads:[~2018-10-12 19:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 4:24 [PATCH v3 0/7] ia64: system call table generation support Firoz Khan
2018-10-11 4:24 ` Firoz Khan
2018-10-11 4:24 ` [PATCH v3 1/7] ia64: add __NR_old_getpagesize in uapi/asm/unistd.h Firoz Khan
2018-10-11 4:24 ` Firoz Khan
2018-10-11 4:24 ` [PATCH v3 2/7] ia64: replace NR_syscalls macro from asm/unistd.h Firoz Khan
2018-10-11 4:24 ` Firoz Khan
2018-10-11 4:24 ` [PATCH v3 3/7] ia64: add an offset for system call number Firoz Khan
2018-10-11 4:24 ` Firoz Khan
2018-10-11 4:24 ` [PATCH v3 4/7] ia64: replace the system call table entries from entry.S Firoz Khan
2018-10-11 4:24 ` Firoz Khan
2018-10-11 7:32 ` Arnd Bergmann
2018-10-11 7:32 ` Arnd Bergmann
2018-10-11 8:35 ` Firoz Khan
2018-10-11 8:35 ` Firoz Khan
2018-10-11 4:24 ` [PATCH v3 5/7] ia64: add system call table generation support Firoz Khan
2018-10-11 4:24 ` Firoz Khan
2018-10-11 4:24 ` [PATCH v3 6/7] ia64: uapi header and system call table file generation Firoz Khan
2018-10-11 4:24 ` Firoz Khan
2018-10-11 4:24 ` [PATCH v3 7/7] ia64: wire up system calls Firoz Khan
2018-10-11 4:24 ` Firoz Khan
2018-10-11 7:24 ` Arnd Bergmann
2018-10-11 7:24 ` Arnd Bergmann
2018-10-11 8:35 ` Firoz Khan
2018-10-11 8:35 ` Firoz Khan
2018-10-11 15:06 ` Eugene Syromiatnikov
2018-10-11 15:06 ` Eugene Syromiatnikov
2018-10-11 15:09 ` Arnd Bergmann
2018-10-11 15:09 ` Arnd Bergmann
2018-10-11 17:28 ` [PATCH v3 0/7] ia64: system call table generation support Luck, Tony
2018-10-11 17:28 ` Luck, Tony
2018-10-12 4:01 ` Firoz Khan
2018-10-12 4:01 ` Firoz Khan
2018-10-12 16:11 ` Luck, Tony
2018-10-12 16:11 ` Luck, Tony
2018-10-12 19:40 ` Arnd Bergmann [this message]
2018-10-12 19:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2uMx8eAa+WAGtePA3O=U_LXXBP7XX62fAO9g1NfpXgNQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=fenghua.yu@intel.com \
--cc=firoz.khan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).