From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V3 17/26] csky: Misc headers Date: Fri, 7 Sep 2018 10:01:03 +0200 Message-ID: References: <66335e5f59c186b291f8c3c98c9dadbd61d0cd3e.1536138304.git.ren_guo@c-sky.com> <20180907051747.GC13356@guoren-Inspiron-7460> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180907051747.GC13356@guoren-Inspiron-7460> Sender: linux-kernel-owner@vger.kernel.org To: Guo Ren Cc: linux-arch , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Thomas Petazzoni , wbx@uclibc-ng.org, Greentime Hu List-Id: linux-arch.vger.kernel.org On Fri, Sep 7, 2018 at 7:17 AM Guo Ren wrote: > > On Thu, Sep 06, 2018 at 04:16:30PM +0200, Arnd Bergmann wrote: > > On Wed, Sep 5, 2018 at 2:08 PM Guo Ren wrote: > > > > > diff --git a/arch/csky/boot/dts/qemu.dts b/arch/csky/boot/dts/qemu.dts > > > new file mode 100644 > > > index 0000000..d36e4cd > > > --- /dev/null > > > +++ b/arch/csky/boot/dts/qemu.dts > > > @@ -0,0 +1,77 @@ > > > +/dts-v1/; > > > +/ { > > > + compatible = "csky,qemu"; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + interrupt-parent = <&intc>; > > > > Ideally, qemu would supply a dtb file that matches the current configuration, > > as we do for instance on the ARM 'virt' machine. This allows you > > much more flexibility in running all kinds of options, as well as extending > > qemu later with new features. > So, I should remove qemu.dts in next version patch? It's up to you really. If you won't have a version of qemu that can do this by itself, it may make sense to keep it around for a while. You might want to include the version of your current qemu port is based on qemu-2.x but not upstream, you could include a qemu-2.x.dts file here, and have the future 3.x port provide its own. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f196.google.com ([209.85.216.196]:46659 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728176AbeIGMlF (ORCPT ); Fri, 7 Sep 2018 08:41:05 -0400 MIME-Version: 1.0 References: <66335e5f59c186b291f8c3c98c9dadbd61d0cd3e.1536138304.git.ren_guo@c-sky.com> <20180907051747.GC13356@guoren-Inspiron-7460> In-Reply-To: <20180907051747.GC13356@guoren-Inspiron-7460> From: Arnd Bergmann Date: Fri, 7 Sep 2018 10:01:03 +0200 Message-ID: Subject: Re: [PATCH V3 17/26] csky: Misc headers Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Guo Ren Cc: linux-arch , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Thomas Petazzoni , wbx@uclibc-ng.org, Greentime Hu Message-ID: <20180907080103.ROolSn2w0WJBmUdTl-_mtJL1hMmuXXYJkmkxY0FAg-s@z> On Fri, Sep 7, 2018 at 7:17 AM Guo Ren wrote: > > On Thu, Sep 06, 2018 at 04:16:30PM +0200, Arnd Bergmann wrote: > > On Wed, Sep 5, 2018 at 2:08 PM Guo Ren wrote: > > > > > diff --git a/arch/csky/boot/dts/qemu.dts b/arch/csky/boot/dts/qemu.dts > > > new file mode 100644 > > > index 0000000..d36e4cd > > > --- /dev/null > > > +++ b/arch/csky/boot/dts/qemu.dts > > > @@ -0,0 +1,77 @@ > > > +/dts-v1/; > > > +/ { > > > + compatible = "csky,qemu"; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + interrupt-parent = <&intc>; > > > > Ideally, qemu would supply a dtb file that matches the current configuration, > > as we do for instance on the ARM 'virt' machine. This allows you > > much more flexibility in running all kinds of options, as well as extending > > qemu later with new features. > So, I should remove qemu.dts in next version patch? It's up to you really. If you won't have a version of qemu that can do this by itself, it may make sense to keep it around for a while. You might want to include the version of your current qemu port is based on qemu-2.x but not upstream, you could include a qemu-2.x.dts file here, and have the future 3.x port provide its own. Arnd