From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6AA4C433DB for ; Fri, 26 Mar 2021 15:05:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A54D2619CB for ; Fri, 26 Mar 2021 15:05:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230051AbhCZPFB (ORCPT ); Fri, 26 Mar 2021 11:05:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:60412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbhCZPEo (ORCPT ); Fri, 26 Mar 2021 11:04:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C387061A28; Fri, 26 Mar 2021 15:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616771080; bh=CcDG1SYT+u5oJCFUbtBoRVBdku5chSBF/j8IcwTSwyA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FslLeGi3ttBCpMwtegrgb3z3Jo9maYQuWXpVaJsfbMi0cMLce4xQuBXm6iwbDyBJu Wqc+4pQAnP76sDiYBuKQKxkAJshruFOVUM4rted2/fN3Ef93XjjXL5dnmEqUFNAO9e hoyR+oYbvgzxSvB/aqrMzDUIZBLKXvK1JT5W2Kr/DA6ua8jhtsHnjx4e8WJTmGsIa2 e4Fnako4g0tZmhYLhifao8/XBPPKaTP5NVGYKGXCSpJx/WFDJdEHtdZzuqbjGKXZHs 5Mn2WuBXZZBRUS/K6Tlirn0e261TPnYR+Zqff0+P437/WKaaCfTmbL6HwTudxdrVdJ JCXHPuMsIVGrw== Received: by mail-ed1-f47.google.com with SMTP id e7so6642556edu.10; Fri, 26 Mar 2021 08:04:39 -0700 (PDT) X-Gm-Message-State: AOAM531560WAvyieJBqROiK+4HtTrlXBHpliTci6VsPh3Jx5h5n2eWnB ANeOj+IFhqEwn+tKyoDSCJcjJ0MZXuwip1w7Iw== X-Google-Smtp-Source: ABdhPJysfZUE7pyMmQBkvm0tvpbMLtvvqy297Z/V6TC8r3w35DV43BQKmWP/tZVYr7jDjbifL0QLm4IUfTacC1zCtZ0= X-Received: by 2002:a05:6402:2d0:: with SMTP id b16mr15924985edx.194.1616771078263; Fri, 26 Mar 2021 08:04:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Fri, 26 Mar 2021 09:04:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 00/17] Implement GENERIC_CMDLINE To: Christophe Leroy Cc: Will Deacon , Daniel Walker , Daniel Gimpelevich , "open list:GENERIC INCLUDE/ASM HEADER FILES" , devicetree@vger.kernel.org, linuxppc-dev , "linux-kernel@vger.kernel.org" , linux-arm-kernel , microblaze , "open list:MIPS" , nios2 , Openrisc , linux-hexagon@vger.kernel.org, linux-riscv , X86 ML , linux-xtensa@linux-xtensa.org, SH-Linux , sparclinux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy wrote: > > The purpose of this series is to improve and enhance the > handling of kernel boot arguments. > > It is first focussed on powerpc but also extends the capability > for other arches. > > This is based on suggestion from Daniel Walker > > Main changes in V3: > - Also accept destination equal to source in cmdline_build() by setting a tmp buffer in __initdata. Powerpc provides different source and destination and call __cmdline_build() directly. > - Taken comments received from Will and Rob > - Converted all architectures (Only tested on powerpc) > > Christophe Leroy (17): > cmdline: Add generic function to build command line. > drivers: of: use cmdline building function > cmdline: Gives architectures opportunity to use generically defined > boot cmdline manipulation > powerpc: Convert to GENERIC_CMDLINE > arm: Convert to GENERIC_CMDLINE > arm64: Convert to GENERIC_CMDLINE > hexagon: Convert to GENERIC_CMDLINE > microblaze: Convert to GENERIC_CMDLINE > nios2: Convert to GENERIC_CMDLINE > openrisc: Convert to GENERIC_CMDLINE > riscv: Convert to GENERIC_CMDLINE > sh: Convert to GENERIC_CMDLINE > sparc: Convert to GENERIC_CMDLINE > xtensa: Convert to GENERIC_CMDLINE > x86: Convert to GENERIC_CMDLINE > mips: Convert to GENERIC_CMDLINE > cmdline: Remove CONFIG_CMDLINE_EXTEND > > arch/arm/Kconfig | 38 +------------- > arch/arm/kernel/atags_parse.c | 15 ++---- > arch/arm64/Kconfig | 33 +----------- > arch/arm64/kernel/idreg-override.c | 9 ++-- > arch/hexagon/Kconfig | 11 +--- > arch/hexagon/kernel/setup.c | 10 +--- > arch/microblaze/Kconfig | 24 +-------- > arch/microblaze/configs/mmu_defconfig | 2 +- > arch/microblaze/kernel/head.S | 4 +- > arch/mips/Kconfig | 1 + > arch/mips/Kconfig.debug | 44 ---------------- > arch/mips/configs/ar7_defconfig | 1 - > arch/mips/configs/bcm47xx_defconfig | 1 - > arch/mips/configs/bcm63xx_defconfig | 1 - > arch/mips/configs/bmips_be_defconfig | 1 - > arch/mips/configs/bmips_stb_defconfig | 1 - > arch/mips/configs/capcella_defconfig | 1 - > arch/mips/configs/ci20_defconfig | 1 - > arch/mips/configs/cu1000-neo_defconfig | 1 - > arch/mips/configs/cu1830-neo_defconfig | 1 - > arch/mips/configs/e55_defconfig | 1 - > arch/mips/configs/generic_defconfig | 1 - > arch/mips/configs/gpr_defconfig | 1 - > arch/mips/configs/loongson3_defconfig | 1 - > arch/mips/configs/mpc30x_defconfig | 1 - > arch/mips/configs/rt305x_defconfig | 1 - > arch/mips/configs/tb0219_defconfig | 1 - > arch/mips/configs/tb0226_defconfig | 1 - > arch/mips/configs/tb0287_defconfig | 1 - > arch/mips/configs/workpad_defconfig | 1 - > arch/mips/configs/xway_defconfig | 1 - > arch/mips/kernel/relocate.c | 4 +- > arch/mips/kernel/setup.c | 40 +-------------- > arch/mips/pic32/pic32mzda/early_console.c | 2 +- > arch/mips/pic32/pic32mzda/init.c | 2 - > arch/nios2/Kconfig | 24 +-------- > arch/nios2/kernel/setup.c | 13 ++--- > arch/openrisc/Kconfig | 10 +--- > arch/powerpc/Kconfig | 37 +------------ > arch/powerpc/kernel/prom_init.c | 17 +++--- > arch/riscv/Kconfig | 44 +--------------- > arch/riscv/kernel/setup.c | 5 +- > arch/sh/Kconfig | 30 +---------- > arch/sh/configs/ap325rxa_defconfig | 2 +- > arch/sh/configs/dreamcast_defconfig | 2 +- > arch/sh/configs/ecovec24-romimage_defconfig | 2 +- > arch/sh/configs/ecovec24_defconfig | 2 +- > arch/sh/configs/edosk7760_defconfig | 2 +- > arch/sh/configs/espt_defconfig | 2 +- > arch/sh/configs/j2_defconfig | 2 +- > arch/sh/configs/kfr2r09-romimage_defconfig | 2 +- > arch/sh/configs/kfr2r09_defconfig | 2 +- > arch/sh/configs/lboxre2_defconfig | 2 +- > arch/sh/configs/microdev_defconfig | 2 +- > arch/sh/configs/migor_defconfig | 2 +- > arch/sh/configs/polaris_defconfig | 2 +- > arch/sh/configs/r7780mp_defconfig | 2 +- > arch/sh/configs/r7785rp_defconfig | 2 +- > arch/sh/configs/rsk7201_defconfig | 2 +- > arch/sh/configs/rsk7203_defconfig | 2 +- > arch/sh/configs/rts7751r2d1_defconfig | 2 +- > arch/sh/configs/rts7751r2dplus_defconfig | 2 +- > arch/sh/configs/sdk7780_defconfig | 2 +- > arch/sh/configs/sdk7786_defconfig | 2 +- > arch/sh/configs/se7206_defconfig | 2 +- > arch/sh/configs/se7343_defconfig | 2 +- > arch/sh/configs/se7712_defconfig | 2 +- > arch/sh/configs/se7721_defconfig | 2 +- > arch/sh/configs/se7724_defconfig | 2 +- > arch/sh/configs/se7751_defconfig | 2 +- > arch/sh/configs/se7780_defconfig | 2 +- > arch/sh/configs/sh03_defconfig | 2 +- > arch/sh/configs/sh2007_defconfig | 2 +- > arch/sh/configs/sh7757lcr_defconfig | 2 +- > arch/sh/configs/sh7763rdp_defconfig | 2 +- > arch/sh/configs/shmin_defconfig | 2 +- > arch/sh/configs/shx3_defconfig | 2 +- > arch/sh/configs/titan_defconfig | 2 +- > arch/sh/configs/ul2_defconfig | 2 +- > arch/sh/kernel/setup.c | 11 +--- > arch/sparc/Kconfig | 18 +------ > arch/sparc/prom/bootstr_64.c | 2 +- > arch/x86/Kconfig | 45 +--------------- > arch/x86/kernel/setup.c | 17 +----- > arch/xtensa/Kconfig | 15 +----- > arch/xtensa/configs/audio_kc705_defconfig | 1 - > arch/xtensa/configs/common_defconfig | 1 - > arch/xtensa/configs/generic_kc705_defconfig | 1 - > arch/xtensa/configs/iss_defconfig | 1 - > arch/xtensa/configs/nommu_kc705_defconfig | 1 - > arch/xtensa/configs/smp_lx200_defconfig | 1 - > arch/xtensa/configs/virt_defconfig | 1 - > arch/xtensa/configs/xip_kc705_defconfig | 1 - > arch/xtensa/kernel/setup.c | 10 +--- > drivers/firmware/efi/libstub/x86-stub.c | 26 +++++----- You missed efi-stub.c which has CMDLINE_EXTEND. > drivers/of/fdt.c | 23 ++------- > include/linux/cmdline.h | 57 +++++++++++++++++++++ > init/Kconfig | 46 +++++++++++++++++ > 98 files changed, 209 insertions(+), 580 deletions(-) > create mode 100644 include/linux/cmdline.h > > -- > 2.25.0 >