From mboxrd@z Thu Jan 1 00:00:00 1970 From: Firoz Khan Subject: Re: [PATCH v2 3/5] m68k: Added system call table generation support Date: Mon, 24 Sep 2018 13:23:31 +0530 Message-ID: References: <1537455973-12468-1-git-send-email-firoz.khan@linaro.org> <1537455973-12468-4-git-send-email-firoz.khan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Geert Uytterhoeven Cc: Kate Stewart , Linux-Arch , Arnd Bergmann , y2038 Mailman List , Greg Kroah-Hartman , Linux Kernel Mailing List , Marcin Juszkiewicz , linux-m68k , Deepa Dinamani , Philippe Ombredanne , Thomas Gleixner List-Id: linux-arch.vger.kernel.org SGkgR2VlcnQsCgpPbiBNb24sIDI0IFNlcCAyMDE4IGF0IDEyOjMzLCBHZWVydCBVeXR0ZXJob2V2 ZW4gPGdlZXJ0QGxpbnV4LW02OGsub3JnPiB3cm90ZToKPgo+IEhpIEZpcm96LAo+Cj4gT24gVGh1 LCBTZXAgMjAsIDIwMTggYXQgNTowNyBQTSBGaXJveiBLaGFuIDxmaXJvei5raGFuQGxpbmFyby5v cmc+IHdyb3RlOgo+ID4gVGhlIHN5c3RlbSBjYWxsIHRhYmxlcyBhcmUgaW4gZGlmZmVyZW50IGZv cm1hdCBpbiBhbGwKPiA+IGFyY2hpdGVjdHVyZSBhbmQgaXQgd2lsbCBiZSBkaWZmaWN1bHQgdG8g bWFudWFsbHkgYWRkIG9yCj4gPiBtb2RpZnkgdGhlIHN5c3RlbSBjYWxscyBpbiB0aGUgcmVzcGVj dGl2ZSBmaWxlcy4gVG8gbWFrZQo+ID4gaXQgZWFzeSBieSBrZWVwaW5nIGEgc2NyaXB0IGFuZCB3 aGljaCdsbCBnZW5lcmF0ZSB0aGUKPiA+IGhlYWRlciBmaWxlIGFuZCBzeXNjYWxsIHRhYmxlIGZp bGUgc28gdGhpcyBjaGFuZ2Ugd2lsbAo+ID4gdW5pZnkgdGhlbSBhY3Jvc3MgYWxsIGFyY2hpdGVj dHVyZXMuCj4gPgo+ID4gVGhlIHN5c3RlbSBjYWxsIHRhYmxlIGdlbmVyYXRpb24gc2NyaXB0IGlz IGFkZGVkIGluCj4gPiBzeXNjYWxscyBkaXJlY3Rvcnkgd2hpY2ggY29udGFpbiB0aGUgc2NyaXB0 IHRvIGdlbmVyYXRlCj4gPiBib3RoIHVhcGkgaGVhZGVyIGZpbGUgc3lzdGVtIGNhbGwgdGFibGUg Z2VuZXJhdGlvbiBmaWxlCj4gPiBhbmQgc3lzY2FsbC50YmwgZmlsZSB3aGljaCdsbCBiZSB0aGUg aW5wdXQgZm9yIHRoZSBzY3JpcHRzLgo+ID4KPiA+IHN5c2NhbGwudGJsIGNvbnRhaW5zIHRoZSBs aXN0IG9mIGF2YWlsYWJsZSBzeXN0ZW0gY2FsbHMKPiA+IGFsb25nIHdpdGggc3lzdGVtIGNhbGwg bnVtYmVyIGFuZCBjb3JyZXNwb25kaW5nIGVudHJ5IHBvaW50Lgo+ID4gQWRkIGEgbmV3IHN5c3Rl bSBjYWxsIGluIHRoaXMgYXJjaGl0ZWN0dXJlIHdpbGwgYmUgcG9zc2libGUKPiA+IGJ5IGFkZGlu ZyBuZXcgZW50cnkgaW4gdGhlIHN5c2NhbGwudGJsIGZpbGUuCj4gPgo+ID4gQWRkaW5nIGEgbmV3 IHRhYmxlIGVudHJ5IGNvbnNpc3Rpbmcgb2Y6Cj4gPiAgICAgICAgIC0gU3lzdGVtIGNhbGwgbnVt YmVyLgo+ID4gICAgICAgICAtIEFCSS4KPiA+ICAgICAgICAgLSBTeXN0ZW0gY2FsbCBuYW1lLgo+ ID4gICAgICAgICAtIEVudHJ5IHBvaW50IG5hbWUuCj4gPgo+ID4gc3lzY2FsbGhkci5zaCBhbmQg c3lzY2FsbHRibC5zaCB3aWxsIGdlbmVyYXRlIHVhcGkgaGVhZGVyLQo+ID4gdW5pc3RkLmggYW5k IHN5c2NhbGxfdGFibGUuaCBmaWxlcyByZXNwZWN0aXZlbHkuIEZpbGUKPiA+IHN5c2NhbGxfdGFi bGUuaCBpcyBpbmNsdWRlZCBieSBzeXNjYWxsX3RhYmxlLlMgLSB0aGUgcmVhbAo+ID4gc3lzdGVt IGNhbGwgdGFibGUuIEJvdGggLnNoIGZpbGVzIHdpbGwgcGFyc2UgdGhlIGNvbnRlbnQKPiA+IHN5 c2NhbGwudGJsIHRvIGdlbmVyYXRlIHRoZSBoZWFkZXIgYW5kIHRhYmxlIGZpbGVzLgo+ID4KPiA+ IEFSTSwgczM5MCBhbmQgeDg2IGFyY2hpdGVjdXR1cmUgZG9lcyBoYXZlIHRoZSBzaW1pbGFyIHN1 cHBvcnQuCj4gPiBJIGxldmVyYWdlIHRoZWlyIGltcGxlbWVudGF0aW9uIHRvIGNvbWUgdXAgd2l0 aCBhIGdlbmVyaWMKPiA+IHNvbHV0aW9uLiBBbmQgdGhpcyBpcyB0aGUgZ3JvdW5kIHdvcmsgZm9y IHkyMDM4IGlzc3VlLiBXZSBuZWVkCj4gPiB0byBjaGFuZ2UgdHdvIGRvem9ucyBvZiBzeXN0ZW0g Y2FsbCBpbXBsZW1lbnRhdGlvbiBhbmQgdGhpcwo+ID4gd29yayB3aWxsIHJlZHVjZSB0aGUgZWZm b3J0IGJ5IHNpbXBseSBtb2RpZnkgdHdvIGRvem9uIGVudHJpZXMKPiA+IGluIHN5c2NhbGwudGJs Lgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEZpcm96IEtoYW4gPGZpcm96LmtoYW5AbGluYXJvLm9y Zz4KPgo+IFRoYW5rcyBmb3IgeW91ciBwYXRjaCEKPgo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysr IGIvYXJjaC9tNjhrL2tlcm5lbC9zeXNjYWxscy9zeXNjYWxsLnRibAo+ID4gQEAgLTAsMCArMSwz NjkgQEAKPiA+ICsjCj4gPiArIyBMaW51eCBzeXN0ZW0gY2FsbCBudW1iZXJzIGFuZCBlbnRyeSB2 ZWN0b3JzCj4gPiArIwo+ID4gKyMgVGhlIGZvcm1hdCBpczoKPiA+ICsjIDxudW1iZXI+IDxhYmk+ IDxuYW1lPiA8ZW50cnkgcG9pbnQ+Cj4gPiArIwo+ID4gKyMgVGhlIGFiaSBpcyBhbHdheXMgY29t bW9uIGZvciB0aGlzIGZpbGUuCj4gPiArIwo+ID4gKzAgICAgICAgY29tbW9uICAgcmVzdGFydF9z eXNjYWxsICAgICAgICAgIHN5c19yZXN0YXJ0X3N5c2NhbGwKPgo+IFdoeSB0aGUgaW5kZW50YXRp b24gYnkgYW4gIm9kZCIgbnVtYmVyIG9mIHNwYWNlcywgaW5zdGVhZCBvZiBUQUJzPwoKSSdsbCBj aGVjayBhbmQgZml4IEFTQVAuIEhvcGVmdWxseSBJIGNhbiBwb3N0IGEgY2xlYW4gKGFsbW9zdCkg cGF0Y2ggc2VyaWVzCndpdGhpbiBjb3VwbGUgb2YgZGF5cyEKCi0gRmlyb3oKCj4KPiBHcntvZXRq ZSxlZXRpbmd9cywKPgo+ICAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0Cj4KPiAtLQo+IEdl ZXJ0IFV5dHRlcmhvZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0g Z2VlcnRAbGludXgtbTY4ay5vcmcKPgo+IEluIHBlcnNvbmFsIGNvbnZlcnNhdGlvbnMgd2l0aCB0 ZWNobmljYWwgcGVvcGxlLCBJIGNhbGwgbXlzZWxmIGEgaGFja2VyLiBCdXQKPiB3aGVuIEknbSB0 YWxraW5nIHRvIGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGlu ZyBsaWtlIHRoYXQuCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51cyBU b3J2YWxkcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpZ MjAzOCBtYWlsaW5nIGxpc3QKWTIwMzhAbGlzdHMubGluYXJvLm9yZwpodHRwczovL2xpc3RzLmxp bmFyby5vcmcvbWFpbG1hbi9saXN0aW5mby95MjAzOAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-f68.google.com ([209.85.161.68]:34875 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbeIXNyc (ORCPT ); Mon, 24 Sep 2018 09:54:32 -0400 Received: by mail-yw1-f68.google.com with SMTP id y76-v6so942147ywd.2 for ; Mon, 24 Sep 2018 00:53:43 -0700 (PDT) MIME-Version: 1.0 References: <1537455973-12468-1-git-send-email-firoz.khan@linaro.org> <1537455973-12468-4-git-send-email-firoz.khan@linaro.org> In-Reply-To: From: Firoz Khan Date: Mon, 24 Sep 2018 13:23:31 +0530 Message-ID: Subject: Re: [PATCH v2 3/5] m68k: Added system call table generation support Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: linux-m68k , Greg Kroah-Hartman , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , Linux-Arch , Arnd Bergmann , Deepa Dinamani , Marcin Juszkiewicz Message-ID: <20180924075331.Cx8FYGtp4z7tEHJOp1nD8XNE8QwirFKYNDoNduZgB1w@z> Hi Geert, On Mon, 24 Sep 2018 at 12:33, Geert Uytterhoeven wrote: > > Hi Firoz, > > On Thu, Sep 20, 2018 at 5:07 PM Firoz Khan wrote: > > The system call tables are in different format in all > > architecture and it will be difficult to manually add or > > modify the system calls in the respective files. To make > > it easy by keeping a script and which'll generate the > > header file and syscall table file so this change will > > unify them across all architectures. > > > > The system call table generation script is added in > > syscalls directory which contain the script to generate > > both uapi header file system call table generation file > > and syscall.tbl file which'll be the input for the scripts. > > > > syscall.tbl contains the list of available system calls > > along with system call number and corresponding entry point. > > Add a new system call in this architecture will be possible > > by adding new entry in the syscall.tbl file. > > > > Adding a new table entry consisting of: > > - System call number. > > - ABI. > > - System call name. > > - Entry point name. > > > > syscallhdr.sh and syscalltbl.sh will generate uapi header- > > unistd.h and syscall_table.h files respectively. File > > syscall_table.h is included by syscall_table.S - the real > > system call table. Both .sh files will parse the content > > syscall.tbl to generate the header and table files. > > > > ARM, s390 and x86 architecuture does have the similar support. > > I leverage their implementation to come up with a generic > > solution. And this is the ground work for y2038 issue. We need > > to change two dozons of system call implementation and this > > work will reduce the effort by simply modify two dozon entries > > in syscall.tbl. > > > > Signed-off-by: Firoz Khan > > Thanks for your patch! > > > --- /dev/null > > +++ b/arch/m68k/kernel/syscalls/syscall.tbl > > @@ -0,0 +1,369 @@ > > +# > > +# Linux system call numbers and entry vectors > > +# > > +# The format is: > > +# > > +# > > +# The abi is always common for this file. > > +# > > +0 common restart_syscall sys_restart_syscall > > Why the indentation by an "odd" number of spaces, instead of TABs? I'll check and fix ASAP. Hopefully I can post a clean (almost) patch series within couple of days! - Firoz > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds