From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294A8C41604 for ; Tue, 6 Oct 2020 15:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C11AC206F7 for ; Tue, 6 Oct 2020 15:34:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IT0Hogy+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbgJFPep (ORCPT ); Tue, 6 Oct 2020 11:34:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbgJFPep (ORCPT ); Tue, 6 Oct 2020 11:34:45 -0400 Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9394BC061755; Tue, 6 Oct 2020 08:34:43 -0700 (PDT) Received: by mail-oo1-xc42.google.com with SMTP id d16so2097701oos.4; Tue, 06 Oct 2020 08:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwj5kMx3TClI9eEP7bJdqjthI/+2nFgFTxLbSQsbVis=; b=IT0Hogy+oarlvcjB30WEQ5iXWMvoMnNO6n6iYI6FWn64XCM0pPPb+3eeGQVBPLzJje KwS8hcvQlTAo7FISPQyRLkv8g6fnVcAkl6vOtw/rT1lLgNK3/X/BXseGbpK4BC2+Lahc EgVDDU4niQcte1h/cx4/vUmYcw7ljUrDAcpu/DfHQgeMw44wFLXSOOHWZFkeCRm/2NDi e1FExgNmeaple0nvIK/raPwW1mMkfmGxVyfOhmY6Xokr2DE5Y46v0ZOgaiDDNXLc3mC3 3hz6o6U2skt7hb8acbxn8S1GBrbhwighOQW1/P8jGNtzCcEcVy92srt3VpcM+L289IP0 +LLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwj5kMx3TClI9eEP7bJdqjthI/+2nFgFTxLbSQsbVis=; b=uABw8MjlcQcsRfZaDxpj7yo2M3tCoAdiXoSV10nR9w8IQjSiWaB98PCiB7A6/7Lz8G Eomh6UOfxo2s2YJdmx+Jcmd6TGk8o2atLtBBJE/l0Gs+GuK6t1LN5mvitrgXjuwEfARB nGfBzbHFqsiGzwLAzDE64J/+Wkk/I5oxUSjhD3Q0Ki9eICUzEy7zuo2+YeZ9Fj/HTMv/ EGngLKj9RNL/bhsBy+66wqX0XiDMGNLUzvJrK0H8bDVEFmOOtJJ2Z/tEXDw/YlQXgiJm MwpDQFR0qfPd5NhH8Jj/fvhzX8fnueg33RMjJhBKpbrDbYEky6w6t25v7YlTByCHLcgw Rx3A== X-Gm-Message-State: AOAM533pqNA50GDo5mv+R5DAbLfT5WgfQryXlZEz+HCPCC2XbxtxVHsE RNNXmD0Rkf0XqTw55izd2lrf3kjAw8v/amZl6JA= X-Google-Smtp-Source: ABdhPJy2nn7c1xrdQgfV1roSH+9HDEghmuivvRuuYugW9gN1UMpeb1fkI6fD/lJfJmfKp+ID2bNdl9OcTRSCpc3sINA= X-Received: by 2002:a4a:be0f:: with SMTP id l15mr3553236oop.58.1601998482667; Tue, 06 Oct 2020 08:34:42 -0700 (PDT) MIME-Version: 1.0 References: <20200929205746.6763-1-chang.seok.bae@intel.com> <20201005134534.GT6642@arm.com> <20201006092532.GU6642@arm.com> <20201006152553.GY6642@arm.com> In-Reply-To: <20201006152553.GY6642@arm.com> From: "H.J. Lu" Date: Tue, 6 Oct 2020 08:34:06 -0700 Message-ID: Subject: Re: [RFC PATCH 0/4] x86: Improve Minimum Alternate Stack Size To: Dave Martin Cc: "Chang S. Bae" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "the arch/x86 maintainers" , Len Brown , Dave Hansen , Michael Ellerman , Tony Luck , "Ravi V. Shankar" , GNU C Library , linux-arch , Linux API , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Tue, Oct 6, 2020 at 8:25 AM Dave Martin wrote: > > On Tue, Oct 06, 2020 at 05:12:29AM -0700, H.J. Lu wrote: > > On Tue, Oct 6, 2020 at 2:25 AM Dave Martin wrote: > > > > > > On Mon, Oct 05, 2020 at 10:17:06PM +0100, H.J. Lu wrote: > > > > On Mon, Oct 5, 2020 at 6:45 AM Dave Martin wrote: > > > > > > > > > > On Tue, Sep 29, 2020 at 01:57:42PM -0700, Chang S. Bae wrote: > > > > > > During signal entry, the kernel pushes data onto the normal userspace > > > > > > stack. On x86, the data pushed onto the user stack includes XSAVE state, > > > > > > which has grown over time as new features and larger registers have been > > > > > > added to the architecture. > > > > > > > > > > > > MINSIGSTKSZ is a constant provided in the kernel signal.h headers and > > > > > > typically distributed in lib-dev(el) packages, e.g. [1]. Its value is > > > > > > compiled into programs and is part of the user/kernel ABI. The MINSIGSTKSZ > > > > > > constant indicates to userspace how much data the kernel expects to push on > > > > > > the user stack, [2][3]. > > > > > > > > > > > > However, this constant is much too small and does not reflect recent > > > > > > additions to the architecture. For instance, when AVX-512 states are in > > > > > > use, the signal frame size can be 3.5KB while MINSIGSTKSZ remains 2KB. > > > > > > > > > > > > The bug report [4] explains this as an ABI issue. The small MINSIGSTKSZ can > > > > > > cause user stack overflow when delivering a signal. > > > > > > > > > > > > In this series, we suggest a couple of things: > > > > > > 1. Provide a variable minimum stack size to userspace, as a similar > > > > > > approach to [5] > > > > > > 2. Avoid using a too-small alternate stack > > > > > > > > > > I can't comment on the x86 specifics, but the approach followed in this > > > > > series does seem consistent with the way arm64 populates > > > > > AT_MINSIGSTKSZ. > > > > > > > > > > I need to dig up my glibc hacks for providing a sysconf interface to > > > > > this... > > > > > > > > Here is my proposal for glibc: > > > > > > > > https://sourceware.org/pipermail/libc-alpha/2020-September/118098.html > > > > > > Thanks for the link. > > > > > > Are there patches yet? I already had some hacks in the works, but I can > > > drop them if there's something already out there. > > > > I am working on it. > > OK. I may post something for discussion, but I'm happy for it to be > superseded by someone (i.e., other than me) who actually knows what > they're doing... Please see my previous email for my glibc patch: https://gitlab.com/x86-glibc/glibc/-/commits/users/hjl/AT_MINSIGSTKSZ > > > > > > > 1. Define SIGSTKSZ and MINSIGSTKSZ to 64KB. > > > > > > Can we do this? IIUC, this is an ABI break and carries the risk of > > > buffer overruns. > > > > > > The reason for not simply increasing the kernel's MINSIGSTKSZ #define > > > (apart from the fact that it is rarely used, due to glibc's shadowing > > > definitions) was that userspace binaries will have baked in the old > > > value of the constant and may be making assumptions about it. > > > > > > For example, the type (char [MINSIGSTKSZ]) changes if this #define > > > changes. This could be a problem if an newly built library tries to > > > memcpy() or dump such an object defined by and old binary. > > > Bounds-checking and the stack sizes passed to things like sigaltstack() > > > and makecontext() could similarly go wrong. > > > > With my original proposal: > > > > https://sourceware.org/pipermail/libc-alpha/2020-September/118028.html > > > > char [MINSIGSTKSZ] won't compile. The feedback is to increase the > > constants: > > > > https://sourceware.org/pipermail/libc-alpha/2020-September/118092.html > > Ah, I see. But both still API and ABI breaks; moreover, declaraing an > array with size based on (MIN)SIGSTKSZ is not just reasonable, but the > obvious thing to do with this constant in many simple cases. Such usage > is widespread, see: > > * https://codesearch.debian.net/search?q=%5BSIGSTKSZ%5D&literal=1 > > > Your two approaches seem to trade off two different sources of buffer > overruns: undersized stacks versus ABI breaks across library boundaries. We can't get everything we want. > Since undersized stack is by far the more familiar problem and we at > least have guard regions to help detect overruns, I'd vote to keep > MINSIGSTKSZ and SIGSTKSZ as-is, at least for now. Agree. > Or are people reporting real stack overruns on x86 today? I hope so. > > For arm64, we made large vectors on SVE opt-in, so that oversized signal > frames are not seen by default. Would somethine similar be feasible on > x86? > > > > > > 2. Add _SC_RSVD_SIG_STACK_SIZE for signal stack size reserved by the kernel. > > > > > > How about "_SC_MINSIGSTKSZ"? This was my initial choice since only the > > > discovery method is changing. The meaning of the value is exactly the > > > same as before. > > > > > > If we are going to rename it though, it could make sense to go for > > > something more directly descriptive, say, "_SC_SIGNAL_FRAME_SIZE". > > > > > > The trouble with including "STKSZ" is that is sounds like a > > > recommendation for your stack size. While the signal frame size is > > > relevant to picking a stack size, it's not the only thing to > > > consider. > > > > The problem is that AT_MINSIGSTKSZ is the signal frame size used by > > kernel. The minimum stack size for a signal handler is more likely > > AT_MINSIGSTKSZ + 1.5KB unless AT_MINSIGSTKSZ returns the signal > > frame size used by kernel + 6KB for user application. > > Ack; to be correct, you also need to take into account which signals may > be unmasked while running on this stack, and the stack requirements of > all their handlers. Unfortunately, that's hard :( > > What's your view on my naming suggesions? I used _SC_MINSIGSTKSZ: https://gitlab.com/x86-glibc/glibc/-/commit/73ca53bfbc1c105bc579f55f15af011a07fcded9 > > > > Also, do we need a _SC_SIGSTKSZ constant, or should the entire concept > > > of a "recommended stack size" be abandoned? glibc can at least make a > > > slightly more informed guess about suitable stack sizes than the kernel > > > (and glibc already has to guess anyway, in order to determine the > > > default thread stack size). > > > > Glibc should try to deduct signal frame size if AT_MINSIGSTKSZ isn't > > available. > > In my code, I generate _SC_SIGSTKSZ as the equivalent of > > max(sysconf(_SC_MINSIGSTKSZ) * 4, SIGSTKSZ) > > which is >= the legacy value, and broadly reperesentative of the > relationship between MINSIGSTKSZ and SIGSTKSZ on most arches. > > > What do you think? sysconf(_SC_MINSIGSTKSZ) should be usable ASIS for most cases. > > > > > 3. Deprecate SIGSTKSZ and MINSIGSTKSZ if _SC_RSVD_SIG_STACK_SIZE > > > > is in use. > > > > > > Great if we can do it. I was concerned that this might be > > > controversial. > > > > > > Would this just be a recommendation, or can we enforce it somehow? > > > > It is just an idea. We need to move away from constant SIGSTKSZ and > > MINSIGSTKSZ. > > Totally agree with that. > With my glibc patch, -D_SC_MINSIGSTKSZ_SOURCE will fail to compile if the source assumes constant SIGSTKSZ or MINSIGSTKSZ. -- H.J.