From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3A7C4363D for ; Tue, 6 Oct 2020 12:13:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D6DB206BE for ; Tue, 6 Oct 2020 12:13:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j5h77Rg+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726566AbgJFMNG (ORCPT ); Tue, 6 Oct 2020 08:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbgJFMNF (ORCPT ); Tue, 6 Oct 2020 08:13:05 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE103C061755; Tue, 6 Oct 2020 05:13:05 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id a2so12024519otr.11; Tue, 06 Oct 2020 05:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NWRcIl4H7NR5wjNYHStWtcM865vMj76wc7Y4EJHzHWk=; b=j5h77Rg+bo8N17QG5m2Osa23XPWOy513mVqvsiAeGawdiKxyfR2h+pt1FC7xBOZfvB bBeH98WXUFpJPjfwjf1NS/+a402MQo15R893F8B8VYWt87BYnmsEEN4FikHbFK+tHwWw LmVbOLvMxQkUjRhS1OXw8gkCXStNqBBT2iVsr3GOVq6WgCr4GGJ08JAt+M2d4O8QhVvp wUQW+KwKutgy57+Fp/oAjAj6oeBtkorLUeASyvLzJ50duvae3P84Zw3Bw7ZBxa1LqAlu JXhiHNqwGJ8LoRG/lugNFm/VaAHlb2nGlTvdXZv/V5PfRbSlFcdQ0ciT3Jbn8MIzOYB4 xKJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NWRcIl4H7NR5wjNYHStWtcM865vMj76wc7Y4EJHzHWk=; b=Mtla4oH3nLJdZLsrENKV1807wHDWySz12+/aRv085bT+VrqgNgEb+H0KpH4bphj/nb yVdBmnN9vRIAOKAb9cYNpbDywv05Gggl14j9je6P3zgKEqgbfcfp0NbjyFhILhZyCbA8 tvK0jdhAYlAEkCHGnajoprR84h/KY0YqPl1FEce5pnXCXhdJ/E2WUWGL2L86TlvwzVhy /lm1p2mltyGIgzo9qBYROE1pUcxw8tzRlir1HxsAvJ1z4pKvFLvH9TqHSNYI75nExrgw 4pLAMGbE2E6OwPYbtb1upEa+IEMWukknOVpxBtaJUOmwHGoPecI1QxSdYw8J3PQmh7F1 nLOA== X-Gm-Message-State: AOAM533lrVXRaWwzqSvDt2Pw+XNZCnp2RUueUmE9U/iMPutbJd6XTSWJ 9yW5vNVKxqRckU58MwbowzA8USq1btuQwgd1ZIY= X-Google-Smtp-Source: ABdhPJwjE+8Vth572W+dNh6A8WM0UhDVuIqFRfy1nr1NrlLlFhSLdMEmG9Fhy30SKKlKIoIyIuRGQqzFANhVi6gsMbc= X-Received: by 2002:a9d:6498:: with SMTP id g24mr2742514otl.179.1601986385044; Tue, 06 Oct 2020 05:13:05 -0700 (PDT) MIME-Version: 1.0 References: <20200929205746.6763-1-chang.seok.bae@intel.com> <20201005134534.GT6642@arm.com> <20201006092532.GU6642@arm.com> In-Reply-To: <20201006092532.GU6642@arm.com> From: "H.J. Lu" Date: Tue, 6 Oct 2020 05:12:29 -0700 Message-ID: Subject: Re: [RFC PATCH 0/4] x86: Improve Minimum Alternate Stack Size To: Dave Martin Cc: "Chang S. Bae" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "the arch/x86 maintainers" , Len Brown , Dave Hansen , Michael Ellerman , Tony Luck , "Ravi V. Shankar" , GNU C Library , linux-arch , Linux API , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Tue, Oct 6, 2020 at 2:25 AM Dave Martin wrote: > > On Mon, Oct 05, 2020 at 10:17:06PM +0100, H.J. Lu wrote: > > On Mon, Oct 5, 2020 at 6:45 AM Dave Martin wrote: > > > > > > On Tue, Sep 29, 2020 at 01:57:42PM -0700, Chang S. Bae wrote: > > > > During signal entry, the kernel pushes data onto the normal userspace > > > > stack. On x86, the data pushed onto the user stack includes XSAVE state, > > > > which has grown over time as new features and larger registers have been > > > > added to the architecture. > > > > > > > > MINSIGSTKSZ is a constant provided in the kernel signal.h headers and > > > > typically distributed in lib-dev(el) packages, e.g. [1]. Its value is > > > > compiled into programs and is part of the user/kernel ABI. The MINSIGSTKSZ > > > > constant indicates to userspace how much data the kernel expects to push on > > > > the user stack, [2][3]. > > > > > > > > However, this constant is much too small and does not reflect recent > > > > additions to the architecture. For instance, when AVX-512 states are in > > > > use, the signal frame size can be 3.5KB while MINSIGSTKSZ remains 2KB. > > > > > > > > The bug report [4] explains this as an ABI issue. The small MINSIGSTKSZ can > > > > cause user stack overflow when delivering a signal. > > > > > > > > In this series, we suggest a couple of things: > > > > 1. Provide a variable minimum stack size to userspace, as a similar > > > > approach to [5] > > > > 2. Avoid using a too-small alternate stack > > > > > > I can't comment on the x86 specifics, but the approach followed in this > > > series does seem consistent with the way arm64 populates > > > AT_MINSIGSTKSZ. > > > > > > I need to dig up my glibc hacks for providing a sysconf interface to > > > this... > > > > Here is my proposal for glibc: > > > > https://sourceware.org/pipermail/libc-alpha/2020-September/118098.html > > Thanks for the link. > > Are there patches yet? I already had some hacks in the works, but I can > drop them if there's something already out there. I am working on it. > > > 1. Define SIGSTKSZ and MINSIGSTKSZ to 64KB. > > Can we do this? IIUC, this is an ABI break and carries the risk of > buffer overruns. > > The reason for not simply increasing the kernel's MINSIGSTKSZ #define > (apart from the fact that it is rarely used, due to glibc's shadowing > definitions) was that userspace binaries will have baked in the old > value of the constant and may be making assumptions about it. > > For example, the type (char [MINSIGSTKSZ]) changes if this #define > changes. This could be a problem if an newly built library tries to > memcpy() or dump such an object defined by and old binary. > Bounds-checking and the stack sizes passed to things like sigaltstack() > and makecontext() could similarly go wrong. With my original proposal: https://sourceware.org/pipermail/libc-alpha/2020-September/118028.html char [MINSIGSTKSZ] won't compile. The feedback is to increase the constants: https://sourceware.org/pipermail/libc-alpha/2020-September/118092.html > > > 2. Add _SC_RSVD_SIG_STACK_SIZE for signal stack size reserved by the kernel. > > How about "_SC_MINSIGSTKSZ"? This was my initial choice since only the > discovery method is changing. The meaning of the value is exactly the > same as before. > > If we are going to rename it though, it could make sense to go for > something more directly descriptive, say, "_SC_SIGNAL_FRAME_SIZE". > > The trouble with including "STKSZ" is that is sounds like a > recommendation for your stack size. While the signal frame size is > relevant to picking a stack size, it's not the only thing to > consider. The problem is that AT_MINSIGSTKSZ is the signal frame size used by kernel. The minimum stack size for a signal handler is more likely AT_MINSIGSTKSZ + 1.5KB unless AT_MINSIGSTKSZ returns the signal frame size used by kernel + 6KB for user application. > > Also, do we need a _SC_SIGSTKSZ constant, or should the entire concept > of a "recommended stack size" be abandoned? glibc can at least make a > slightly more informed guess about suitable stack sizes than the kernel > (and glibc already has to guess anyway, in order to determine the > default thread stack size). Glibc should try to deduct signal frame size if AT_MINSIGSTKSZ isn't available. > > > 3. Deprecate SIGSTKSZ and MINSIGSTKSZ if _SC_RSVD_SIG_STACK_SIZE > > is in use. > > Great if we can do it. I was concerned that this might be > controversial. > > Would this just be a recommendation, or can we enforce it somehow? It is just an idea. We need to move away from constant SIGSTKSZ and MINSIGSTKSZ. -- H.J.