From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 1/8] mm: remove unneeded includes of Date: Mon, 29 Jun 2020 17:41:43 +0200 Message-ID: References: <20200627143453.31835-1-rppt@kernel.org> <20200627143453.31835-2-rppt@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20200627143453.31835-2-rppt@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane-mx.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Mike Rapoport Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , Peter Zijlstra , "open list:BROADCOM NVRAM DRIVER" , Max Filippov , Satheesh Rajendran , linux-csky@vger.kernel.org, sparclinux , linux-riscv , Linux-Arch , Stephen Rothwell , "open list:QUALCOMM HEXAGON..." , Joerg Roedel , Mike Rapoport , Abdul Haleem , arcml , "open list:TENSILICA XTENSA PORT (xtensa)" , Arnd Bergmann , linux-s390 , linux-um List-Id: linux-arch.vger.kernel.org On Sat, Jun 27, 2020 at 4:35 PM Mike Rapoport wrote: > From: Mike Rapoport > > In the most cases header is required only for allocations > of page table memory. Most of the .c files that include that header do not > use symbols declared in and do not require that header. > > As for the other header files that used to include , it is > possible to move that include into the .c file that actually uses symbols > from and drop the include from the header file. > > The process was somewhat automated using > > sed -i -E '/[<"]asm\/pgalloc\.h/d' \ > $(grep -L -w -f /tmp/xx \ > $(git grep -E -l '[<"]asm/pgalloc\.h')) > > where /tmp/xx contains all the symbols defined in > arch/*/include/asm/pgalloc.h. > > Signed-off-by: Mike Rapoport For the m68k part: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds